From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.54725.1622533307344156865 for ; Tue, 01 Jun 2021 00:41:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fGxrBvdW; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622533305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L+QsgyqOaK3TS1qbUfSKvL1+kmboPI+d285FwT4pNG4=; b=fGxrBvdWOGP20UviuCCZJHAFrPb8XQSFAl5NIZC6HgBH8Oog65awKZmUr21mYIEiL46oVT yuxe4X4OkAKnRUSWKWablZWjvz2K1baos0QacwqHpKIpCd9v8P3Df+An/P8j6/yyUHjxdl vw69dhe1DlIiR/TTYZsPri288rEEzJ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-5VsfS5_YP5y0HQbJgZntqg-1; Tue, 01 Jun 2021 03:41:42 -0400 X-MC-Unique: 5VsfS5_YP5y0HQbJgZntqg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1176E107ACCD; Tue, 1 Jun 2021 07:41:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-181.ams2.redhat.com [10.36.114.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34570687E1; Tue, 1 Jun 2021 07:41:35 +0000 (UTC) Subject: Re: [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Ard Biesheuvel Cc: devel@edk2.groups.io, Andrew Fish , Anthony Perard , Ard Biesheuvel , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Michael D Kinney , Min Xu , Peter Grehan , Rebecca Cran , Tom Lendacky References: <20210526201446.12554-1-lersek@redhat.com> <8653efc8-6e63-c71a-35a9-80a8986117f6@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 1 Jun 2021 09:41:34 +0200 MIME-Version: 1.0 In-Reply-To: <8653efc8-6e63-c71a-35a9-80a8986117f6@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05/31/21 17:06, Philippe Mathieu-Daudé wrote: > On 5/27/21 10:55 AM, Laszlo Ersek wrote: >> On 05/27/21 09:34, Ard Biesheuvel wrote: >>> On Wed, 26 May 2021 at 22:15, Laszlo Ersek wrote: >>>> >>>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 >>>> Repo: https://pagure.io/lersek/edk2.git >>>> Branch: xen_split_bz_2122 >>>> >>>> This patch set removes dynamic Xen enlightenment from the following >>>> platforms: >>>> >>>> OvmfPkg/OvmfPkgIa32.dsc >>>> OvmfPkg/OvmfPkgIa32X64.dsc >>>> OvmfPkg/OvmfPkgX64.dsc >>>> >>>> In Xen guests, the following platform should be used: >>>> >>>> OvmfPkg/OvmfXen.dsc >>>> > >>> For the series, >>> >>> Reviewed-by: Ard Biesheuvel >> >> Thank you, Ard! >> >> I hope the large patch count (with the small patch bodies and the >> not-so-short commit messages) didn't get on your nerves! I really did >> make an effort to find a good balance. E.g. in the "clean up and sort >> #includes & INF files" patches. > > I certainly prefer a long series of little patches (so I can stop / > resume the review) rather than a short one of big patches which > burn my review cycle quicker. > > This one in particular made a complex refactor easy to review, > thanks! Thank you, Phil! Laszlo > > Phil. >