From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by mx.groups.io with SMTP id smtpd.web12.4490.1614155198488086607 for ; Wed, 24 Feb 2021 00:26:39 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: linux.alibaba.com, ip: 115.124.30.42, mailfrom: huangming@linux.alibaba.com) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=huangming@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UPRlhHk_1614155193; Received: from MingdeMacBook-Pro.local(mailfrom:huangming@linux.alibaba.com fp:SMTPD_---0UPRlhHk_1614155193) by smtp.aliyun-inc.com(127.0.0.1); Wed, 24 Feb 2021 16:26:34 +0800 Subject: Re: [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , guoheyi@linux.alibaba.com References: <20210223110642.90020-1-huangming@linux.alibaba.com> <20210223125808.GA1664@vanye> From: "Ming Huang" Message-ID: Date: Wed, 24 Feb 2021 16:26:33 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210223125808.GA1664@vanye> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2/23/21 8:58 PM, Leif Lindholm wrote: > On Tue, Feb 23, 2021 at 13:42:49 +0100, Ard Biesheuvel wrote: >> On Tue, 23 Feb 2021 at 12:07, Ming Huang wrote: >>> >>> The register address of GICR_IPRIORITYR is in SGI_base frame. Add >>> IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise >>> GIC RAS error(Uncorrected software error) may report in ArmGicDxe. >> >> NOTE: missing sign-off >> >> Patch seems fine to me >> >> Tested-by: Ard Biesheuvel # QEMU/kvm guest on ThunderX2 > > Also looks good in QEMU. > Reviewed-by: Leif Lindholm > > Ming, can you confirm that the contribution conforms to the developer > certificate of origin by replyint with your Signed-off-by: ? Sorry, I miss the Signed-off-by. please help to add my Signed-off-by: Signed-off-by: Ming Huang Thanks, Ming > >> >> >> >>> --- >>> ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c >>> index 8ef32b33a1..b4d3965acb 100644 >>> --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c >>> +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c >>> @@ -30,6 +30,9 @@ >>> #define ICENABLER_ADDRESS(base,offset) ((base) + \ >>> ARM_GICR_CTLR_FRAME_SIZE + ARM_GICR_ICENABLER + (4 * offset)) >>> >>> +#define IPRIORITY_ADDRESS(base,offset) ((base) + \ >>> + ARM_GICR_CTLR_FRAME_SIZE + ARM_GIC_ICDIPR + (4 * offset)) >>> + >>> /** >>> * >>> * Return whether the Source interrupt index refers to a shared interrupt (SPI) >>> @@ -236,7 +239,7 @@ ArmGicSetInterruptPriority ( >>> } >>> >>> MmioAndThenOr32 ( >>> - GicCpuRedistributorBase + ARM_GIC_ICDIPR + (4 * RegOffset), >>> + IPRIORITY_ADDRESS (GicCpuRedistributorBase, RegOffset), >>> ~(0xff << RegShift), >>> Priority << RegShift >>> ); >>> -- >>> 2.17.1 >>>