From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Meenakshi Aggarwal <meenakshi.aggarwal@oss.nxp.com>,
leif@nuviainc.com, michael.d.kinney@intel.com,
devel@edk2.groups.io
Cc: v.sethi@nxp.com, Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Subject: Re: [PATCH edk2-platforms 2/2] Platform/NXP:LX2160: Enable support of SATA controller
Date: Fri, 5 Jun 2020 15:01:36 +0200 [thread overview]
Message-ID: <cc25fec6-0b37-3973-a922-3e79fbd081d3@arm.com> (raw)
In-Reply-To: <1591372974-7860-3-git-send-email-meenakshi.aggarwal@oss.nxp.com>
On 6/5/20 6:02 PM, Meenakshi Aggarwal wrote:
> Enable support of SATA drives on lx2160 RDB board.
>
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
> Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +++++
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +++++++++++++++---
> 3 files changed, 22 insertions(+), 3 deletions(-)
>
> diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> index 55dd3b5442eb..6bd08d527aed 100644
> --- a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> +++ b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> @@ -40,8 +40,13 @@ [PcdsFixedAtBuild.common]
> gNxpQoriqLsTokenSpaceGuid.PcdUsbSize|0x10000
> gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|2
>
> + gNxpQoriqLsTokenSpaceGuid.PcdSataBaseAddr|0x3200000
> + gNxpQoriqLsTokenSpaceGuid.PcdSataSize|0x10000
> + gNxpQoriqLsTokenSpaceGuid.PcdNumSataController|0x4
> +
> [PcdsFeatureFlag]
> gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|TRUE
> + gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA009185|TRUE
>
> ################################################################################
> #
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> index ec27a1a219a5..2c65577eceab 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> @@ -44,4 +44,6 @@ [Components.common]
> }
>
> Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> +
> + Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> ##
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> index 5cb809e8b3a0..e8ac7658c011 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> @@ -23,10 +23,10 @@
>
> [FD.LX2160ARDB_EFI]
> BaseAddress = 0x82000000|gArmTokenSpaceGuid.PcdFdBaseAddress #The base address of the FLASH Device.
> -Size = 0x00160000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device
> +Size = 0x00180000|gArmTokenSpaceGuid.PcdFdSize #The size in bytes of the FLASH Device
> ErasePolarity = 1
> BlockSize = 0x10000
> -NumBlocks = 0x16
> +NumBlocks = 0x18
>
> ################################################################################
> #
> @@ -43,7 +43,7 @@ [FD.LX2160ARDB_EFI]
> # RegionType <FV, DATA, or FILE>
> #
> ################################################################################
> -0x00000000|0x00160000
> +0x00000000|0x00180000
> gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
> FV = FVMAIN_COMPACT
>
I don't mind these unrelated changes (but Leif might) but you should
make a note of them in the commit log.
> @@ -132,6 +132,18 @@ [FV.FvMain]
> INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
>
> INF Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> +
> + #
> + # AHCI Support
> + #
> + INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
> + INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> + INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
> + INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
> + INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
> +
> + INF Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> +
> #
> # UEFI application (Shell Embedded Boot Loader)
> #
>
next prev parent reply other threads:[~2020-06-05 13:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 16:02 [PATCH edk2-platforms 0/2] Add SATA driver support Meenakshi Aggarwal
2020-06-05 16:02 ` [PATCH edk2-platforms 1/2] Silicon/NXP: Add SATA controller initialization driver Meenakshi Aggarwal
2020-06-05 13:00 ` Ard Biesheuvel
2020-06-08 11:44 ` Meenakshi Aggarwal
2020-06-05 16:02 ` [PATCH edk2-platforms 2/2] Platform/NXP:LX2160: Enable support of SATA controller Meenakshi Aggarwal
2020-06-05 13:01 ` Ard Biesheuvel [this message]
2020-06-05 13:09 ` Leif Lindholm
2020-06-09 14:31 ` [PATCH edk2-platforms V2 0/2] Add SATA driver support Meenakshi Aggarwal
2020-06-09 14:31 ` [PATCH edk2-platforms V2 1/2] Silicon/NXP: Add SATA controller initialization driver Meenakshi Aggarwal
2020-06-09 14:31 ` [PATCH edk2-platforms V2 2/2] Platform/NXP:LX2160: Enable support of SATA controller Meenakshi Aggarwal
2020-06-17 11:55 ` [PATCH edk2-platforms V2 0/2] Add SATA driver support Leif Lindholm
2020-06-23 19:08 ` Meenakshi Aggarwal (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc25fec6-0b37-3973-a922-3e79fbd081d3@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox