From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.10285.1591362102354536470
 for <devel@edk2.groups.io>;
 Fri, 05 Jun 2020 06:01:42 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40FB631B;
	Fri,  5 Jun 2020 06:01:41 -0700 (PDT)
Received: from [192.168.1.69] (unknown [10.37.8.209])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0B8C3F305;
	Fri,  5 Jun 2020 06:01:39 -0700 (PDT)
Subject: Re: [PATCH edk2-platforms 2/2] Platform/NXP:LX2160: Enable support of SATA controller
To: Meenakshi Aggarwal <meenakshi.aggarwal@oss.nxp.com>, leif@nuviainc.com,
 michael.d.kinney@intel.com, devel@edk2.groups.io
Cc: v.sethi@nxp.com, Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
References: <1591372974-7860-1-git-send-email-meenakshi.aggarwal@oss.nxp.com>
 <1591372974-7860-3-git-send-email-meenakshi.aggarwal@oss.nxp.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <cc25fec6-0b37-3973-a922-3e79fbd081d3@arm.com>
Date: Fri, 5 Jun 2020 15:01:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <1591372974-7860-3-git-send-email-meenakshi.aggarwal@oss.nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/5/20 6:02 PM, Meenakshi Aggarwal wrote:
> Enable support of SATA  drives on lx2160 RDB board.
> 
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>   Silicon/NXP/LX2160A/LX2160A.dsc.inc          |  5 +++++
>   Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc |  2 ++
>   Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 18 +++++++++++++++---
>   3 files changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> index 55dd3b5442eb..6bd08d527aed 100644
> --- a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> +++ b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
> @@ -40,8 +40,13 @@ [PcdsFixedAtBuild.common]
>     gNxpQoriqLsTokenSpaceGuid.PcdUsbSize|0x10000
>     gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|2
>   
> +  gNxpQoriqLsTokenSpaceGuid.PcdSataBaseAddr|0x3200000
> +  gNxpQoriqLsTokenSpaceGuid.PcdSataSize|0x10000
> +  gNxpQoriqLsTokenSpaceGuid.PcdNumSataController|0x4
> +
>   [PcdsFeatureFlag]
>     gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|TRUE
> +  gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA009185|TRUE
>   
>   ################################################################################
>   #
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> index ec27a1a219a5..2c65577eceab 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> @@ -44,4 +44,6 @@ [Components.common]
>     }
>   
>     Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> +
> +  Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
>    ##
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> index 5cb809e8b3a0..e8ac7658c011 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> @@ -23,10 +23,10 @@
>   
>   [FD.LX2160ARDB_EFI]
>   BaseAddress   = 0x82000000|gArmTokenSpaceGuid.PcdFdBaseAddress  #The base address of the FLASH Device.
> -Size          = 0x00160000|gArmTokenSpaceGuid.PcdFdSize         #The size in bytes of the FLASH Device
> +Size          = 0x00180000|gArmTokenSpaceGuid.PcdFdSize         #The size in bytes of the FLASH Device
>   ErasePolarity = 1
>   BlockSize     = 0x10000
> -NumBlocks     = 0x16
> +NumBlocks     = 0x18
>   
>   ################################################################################
>   #
> @@ -43,7 +43,7 @@ [FD.LX2160ARDB_EFI]
>   # RegionType <FV, DATA, or FILE>
>   #
>   ################################################################################
> -0x00000000|0x00160000
> +0x00000000|0x00180000
>   gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
>   FV = FVMAIN_COMPACT
>   

I don't mind these unrelated changes (but Leif might) but you should 
make a note of them in the commit log.


> @@ -132,6 +132,18 @@ [FV.FvMain]
>     INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
>   
>     INF Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf
> +
> +  #
> +  # AHCI Support
> +  #
> +  INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
> +  INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> +  INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
> +  INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
> +  INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
> +
> +  INF Silicon/NXP/Drivers/SataInitDxe/SataInitDxe.inf
> +
>     #
>     # UEFI application (Shell Embedded Boot Loader)
>     #
>