public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: Abner Chang <abner.chang@hpe.com>, devel@edk2.groups.io
Cc: Wu Jiaxin <jiaxin.wu@intel.com>, Fu Siyuan <siyuan.fu@intel.com>,
	Nickle Wang <nickle.wang@hpe.com>
Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset
Date: Tue, 29 Sep 2020 15:46:59 +0200	[thread overview]
Message-ID: <cc41c6d4-59c9-469f-33b7-7d53472f21e8@linux.intel.com> (raw)
In-Reply-To: <20200928062934.505108-1-abner.chang@hpe.com>

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 28-Sep-20 08:29, Abner Chang wrote:
> BZ #2909,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2909
>
> When Http->Configure() is invoked with HttpConfigData set to
> NULL to reset the EFI HTTP instance, TLS child instance is
> destroyed but HttpInstance->TlsChildHandle is not set to
> NULL. After reconfiguring HTTP through Http->Configure()
> and sending the HTTP request to HTTPS URL, TLS child
> instance is not recreated because
> HttpInstance->TlsChildHandle is not NULL.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> ---
>   NetworkPkg/HttpDxe/HttpProto.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
> index 3c7c6ff9f0c..afc7db5a726 100644
> --- a/NetworkPkg/HttpDxe/HttpProto.c
> +++ b/NetworkPkg/HttpDxe/HttpProto.c
> @@ -873,6 +873,7 @@ HttpCleanProtocol (
>       // Destroy the TLS instance.
>       //
>       HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle);
> +    HttpInstance->TlsChildHandle = NULL;
>     }
>   
>     if (HttpInstance->Tcp4ChildHandle != NULL) {


  parent reply	other threads:[~2020-09-29 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  6:29 [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Abner Chang
2020-09-28  7:21 ` Wu, Jiaxin
2020-09-29 13:46 ` Maciej Rabeda [this message]
2020-10-08 13:50   ` Abner Chang
2020-10-08 16:17     ` [edk2-devel] " Maciej Rabeda
     [not found]     ` <163C10A7913BC273.18560@groups.io>
2020-10-09  9:38       ` Maciej Rabeda
2020-10-09 10:09         ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc41c6d4-59c9-469f-33b7-7d53472f21e8@linux.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox