From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.40.1601387229867892167 for ; Tue, 29 Sep 2020 06:47:09 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.65, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: n29CXeKwXLwBhMk4eM+0HSKrZ+EUU5ulX5mPjs0M/BsUdyccEcjA2ni7FZiWGDNATi0U/s1c1M m29weVZboRCg== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="162256086" X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="162256086" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 06:47:07 -0700 IronPort-SDR: fZbtHadxF5CP4jE0SI2ihSvJarFZSmyLQNGALHXS6wSxqXW//7svU2miiNryl1pWu74ZCC8+WK XngRWoVABueA== X-IronPort-AV: E=Sophos;i="5.77,318,1596524400"; d="scan'208";a="491286782" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.213.11.211]) ([10.213.11.211]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 06:47:05 -0700 Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset To: Abner Chang , devel@edk2.groups.io Cc: Wu Jiaxin , Fu Siyuan , Nickle Wang References: <20200928062934.505108-1-abner.chang@hpe.com> From: "Maciej Rabeda" Message-ID: Date: Tue, 29 Sep 2020 15:46:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200928062934.505108-1-abner.chang@hpe.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Reviewed-by: Maciej Rabeda On 28-Sep-20 08:29, Abner Chang wrote: > BZ #2909, > https://bugzilla.tianocore.org/show_bug.cgi?id=2909 > > When Http->Configure() is invoked with HttpConfigData set to > NULL to reset the EFI HTTP instance, TLS child instance is > destroyed but HttpInstance->TlsChildHandle is not set to > NULL. After reconfiguring HTTP through Http->Configure() > and sending the HTTP request to HTTPS URL, TLS child > instance is not recreated because > HttpInstance->TlsChildHandle is not NULL. > > Signed-off-by: Abner Chang > > Cc: Maciej Rabeda > Cc: Wu Jiaxin > Cc: Fu Siyuan > Cc: Nickle Wang > --- > NetworkPkg/HttpDxe/HttpProto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c > index 3c7c6ff9f0c..afc7db5a726 100644 > --- a/NetworkPkg/HttpDxe/HttpProto.c > +++ b/NetworkPkg/HttpDxe/HttpProto.c > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > // Destroy the TLS instance. > // > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle); > + HttpInstance->TlsChildHandle = NULL; > } > > if (HttpInstance->Tcp4ChildHandle != NULL) {