From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=Ua128tPa; spf=pass (domain: broadcom.com, ip: 209.85.210.48, mailfrom: vladimir.olovyannikov@broadcom.com) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by groups.io with SMTP; Mon, 09 Sep 2019 13:14:55 -0700 Received: by mail-ot1-f48.google.com with SMTP id y39so14399146ota.7 for ; Mon, 09 Sep 2019 13:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=kImvibR3ytUyIU0Ut8DZDELE33YqwaFplrfSjMOpTXY=; b=Ua128tPaLasvVeqAA4i+/owUdjTEpqwGskvaM5/1St4Tk/P1qTZ8yLu4cOAVS7NbaA JENlMdwJegNgbsvgU74En7xPPORW35trizUjs8C/7PY0KCHLnRzbj8toXdWenmA4AUtu xWRelhuxYr4jmTqzIbdfoJ/2HrKCnqz1BHKk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=kImvibR3ytUyIU0Ut8DZDELE33YqwaFplrfSjMOpTXY=; b=hW5yoWPy1dGkkqIesk6fLxEUld5UbqTNZpmW0qWXqWbiutGaKweucgcd4HZYkd5SIw JBpGxfowP83oeapj1paBfHnEA9rXLWaifukObNMvKf1ReHoRq2vHV48SpstBJVpN+AP6 ++DcRMrRDxc2WKo/eJj3xPrXAcdcwmhL/KKDZv2vPUXJIc54VutZCrQqfonEAJlVPyJ7 d5WxdtkfHlE79tC+3Ee41c6Oz2OJjK5SwLwB98gOp2gutuG40iygN+l3SV4tl93U/L8H r0Q46i5nEYH+7yFwzVXXi4TzmEm9rIu7+weXYAhPGYb5hfs7uoR0kbuw/gyesLN12RW2 p/4Q== X-Gm-Message-State: APjAAAVICoeW42hmjJcCuq/h7n/mQJuHOGE8e7Ok65aqTsTvJbqqWArK o68MkQTrzKlzY7E3XcGl1UMaQYCg2H/thD7kba9NSQ== X-Google-Smtp-Source: APXvYqwvGiw3oTCOn7PlEZG9AdVytDBObaleDDheG5Fh7mFNLkxTRi1GlKZc4zbY/pOujK+/1u+F8Iuf6nF+JPFUKtw= X-Received: by 2002:a05:6830:12d1:: with SMTP id a17mr5074777otq.40.1568060094681; Mon, 09 Sep 2019 13:14:54 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20190808122519.25516-1-steven.shi@intel.com> <20190808122519.25516-2-steven.shi@intel.com> <06C8AB66E78EE34A949939824ABE2B314013E0BC@shsmsx102.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D161532612@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D161532612@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQMH2gU38ZqfRFlZn6eKsD6vEFxZxwKAPtRpAfD0iEsBfLgC4QKOv+oBpHr1C+A= Date: Mon, 9 Sep 2019 13:14:52 -0700 Message-ID: Subject: Re: commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error To: "Feng, Bob C" , "Shi, Steven" , devel@edk2.groups.io Cc: "Gao, Liming" , "Rodriguez, Christian" , "Johnson, Michael" Content-Type: multipart/alternative; boundary="000000000000ee8743059224700f" --000000000000ee8743059224700f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Bob, Steven, Thank you for update. Yes, it fails with =E2=80=9Cbuild clean=E2=80=9D. Example: . ./edksetup.sh build -a AARCH64 -p BroadcomPlatformPkg/StingrayPkg/StingrayPkg.dsc -t GCC5 -b RELEASE -D PLAT=3DStingray -D TARGET=3DRELEASE -D EDK2_STAMP=3D"dev/bcm9= 58742k 59b754c9f697" cleanall Bob, with your patch it builds fine. Steven, in case I am missing something, how do you enable the build cache? Thank you, Vladimir *From:* Feng, Bob C [mailto:bob.c.feng@intel.com] *Sent:* Sunday, September 8, 2019 6:23 PM *To:* Shi, Steven ; Vladimir Olovyannikov < vladimir.olovyannikov@broadcom.com>; devel@edk2.groups.io *Cc:* Gao, Liming ; Rodriguez, Christian < christian.rodriguez@intel.com>; Johnson, Michael *Subject:* RE: commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error Hi Vladimir and Steven, I checked code and think when the build target are 'clean', 'cleanlib', 'cleanall', 'run' and 'fds', build will fail with the error like you mentioned. I filed a Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=3D2166 And provide a fix in https://edk2.groups.io/g/devel/message/47014 Thanks, Bob *From:* Shi, Steven *Sent:* Saturday, September 7, 2019 10:16 AM *To:* Vladimir Olovyannikov ; devel@edk2.groups.io *Cc:* Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Johnson, Michael < michael.johnson@intel.com> *Subject:* RE: commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error Hi Vladimir, Did you enable the build cache? Could you let me know your build steps and commands? Thanks Steven *From:* Vladimir Olovyannikov [mailto:vladimir.olovyannikov@broadcom.com ] *Sent:* Saturday, September 7, 2019 4:45 AM *To:* devel@edk2.groups.io; Shi, Steven *Cc:* Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Johnson, Michael < michael.johnson@intel.com> *Subject:* commit "BaseTools: Improve the cache hit in the edk2 build cache" causes build.py unknown fatal error Hi Steven, The commit 0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4 BaseTools: Improve the cache hit in the edk2 build cache Author: Shi, Steven 2019-08-15 07:26:17 Committer: Feng, Bob C 2019-08-19 23:06:05 Parent: 811328172841ce3f7ec1fe7033c130726ad189b7 (ShellPkg/UefiShellDriver1CommandsLib: Make array big enough) Child: 56c786b0a9fd4f08b1f0bc10b7718a7577cb0146 (BaseTools: Print first cache missing file for build cachle) Branches: master, remotes/origin/master Follows: edk2-stable201905 Precedes: edk2-stable201908 causes "unknown fatal error" in build.py when building our platform. Here is the log: ... build.py... : error C0DE: Unknown fatal error when processing [/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/ArmPkg/Library/Arm= GicArchSecLib/ArmGicArchSecLib.inf] (Please send email to devel@edk2.groups.io for help, attaching following call stack trace!) (Python 3.6.8 on linux) Traceback (most recent call last): File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/BinWrapp= ers/PosixLike/../../Source/Python/build/build.py", line 2493, in Main MyBuild.Launch() File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/BinWrapp= ers/PosixLike/../../Source/Python/build/build.py", line 2287, in Launch self._BuildPlatform() File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/BinWrapp= ers/PosixLike/../../Source/Python/build/build.py", line 1742, in _BuildPlatform self._BuildPa(self.Target, Pa, FfsCommand=3DCmdListDict,PcdMaList=3DPcdMaList) File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/BinWrapp= ers/PosixLike/../../Source/Python/build/build.py", line 1236, in _BuildPa AutoGenObject.CreateCodeFile(True) File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/Source/P= ython/Common/caching.py", line 18, in CallMeHere Value =3D self._function(obj, *args,**kwargs) File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/Source/P= ython/AutoGen/PlatformAutoGen.py", line 171, in CreateCodeFile Ma.CreateCodeFile(CreateModuleCodeFile) File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/Source/P= ython/AutoGen/ModuleAutoGen.py", line 1841, in CreateCodeFile LibraryAutoGen.CreateCodeFile() File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/Source/P= ython/AutoGen/ModuleAutoGen.py", line 1886, in CreateCodeFile with GlobalData.cache_lock: AttributeError: __enter__ - Failed - Build end time: 13:31:30, Sep.06 2019 Build total time: 00:00:04 Builds before the above mentioned commit was pushed, were fine. Thank you, Vladimir --000000000000ee8743059224700f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi Bob, Steven= ,

=C2=A0

Thank you for update.

Yes, it fails with =E2=80=9Cbuild clean=E2=80=9D.<= /span>

Example:

. ./edksetup.sh

build -a AARCH64 -p BroadcomPlatformPkg/StingrayPkg/StingrayPkg.dsc -t= GCC5 -b RELEASE -D PLAT=3DStingray -D TARGET=3DRELEASE -D EDK2_STAMP=3D&qu= ot;dev/bcm958742k 59b754c9f697" cleanall

=C2=A0

B= ob, with your patch it builds fine.

Steven, in case I am missing something, how do you enable the buil= d cache?

=C2=A0

<= p class=3D"MsoNormal">Thank you,
Vladimir

=

From: Feng, Bob C [mailto:<= a href=3D"mailto:bob.c.feng@intel.com">bob.c.feng@intel.com]
Sen= t: Sunday, September 8, 2019 6:23 PM
To: Shi, Steven <steven.shi@intel.com>; Vladimir = Olovyannikov <vlad= imir.olovyannikov@broadcom.com>; devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Rodriguez, Christian= <christian.rodriguez@i= ntel.com>; Johnson, Michael <michael.johnson@intel.com>
Subject: RE: commit &q= uot;BaseTools: Improve the cache hit in the edk2 build cache" causes b= uild.py unknown fatal error

= =C2=A0

Hi Vladimir and Steven,

=C2=A0

I checked code and think when the build target are= 'clean', 'cleanlib', 'cleanall', 'run' and= 'fds', build will fail with the error like you mentioned.

I filed a Bugzilla https://bugzilla= .tianocore.org/show_bug.cgi?id=3D2166

And provide a fix in https://edk2.groups.io/g/devel/message/47014

=C2=A0

<= span style=3D"font-size:11.0pt;font-family:"Calibri",sans-serif;c= olor:#1f497d">Thanks,

Bob

=C2=A0

From: Shi, Steven
Sent: Saturday, September 7, 2019 10:16 AM
To: Vladimir Olovyannikov = <vladimir.olovyann= ikov@broadcom.com>; devel@ed= k2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Rodriguez, Christian &= lt;christian.rodriguez@int= el.com>; Johnson, Michael <michael.johnson@intel.com>
Subject: RE: commit &quo= t;BaseTools: Improve the cache hit in the edk2 build cache" causes bui= ld.py unknown fatal error

=C2= =A0

Hi= Vladimir,

Did you enable the build cache? Could you let me know your build = steps and commands?

=C2=A0<= /span>

=C2=A0

Thanks

Steven

=C2=A0

From: Vladimir Olovyannikov [mailto:vladimir.olovyannikov@broadcom.c= om]
Sent: Saturday, September 7, 2019 4:45 AM
To: = devel@edk2.groups.io; Shi, Stev= en <steven.shi@intel.com>=
Cc: Gao, Liming <limi= ng.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Rodriguez, Christian <christian.rodriguez@intel.com>; = Johnson, Michael <michael.j= ohnson@intel.com>
Subject: commit "BaseTools: Improve= the cache hit in the edk2 build cache" causes build.py unknown fatal = error

=C2=A0

Hi Steven,

=C2=A0

The commit

0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4

BaseTools: Improve the cache hit in the edk2 build cache

Author: Shi, Steven <steven.shi@intel.com> =C2=A02019-08-15 07:26:17<= br>Committer: Feng, Bob C <bob.c= .feng@intel.com> =C2=A02019-08-19 23:06:05
Parent: 811328172841ce= 3f7ec1fe7033c130726ad189b7 (ShellPkg/UefiShellDriver1CommandsLib: Make arra= y big enough)
Child: =C2=A056c786b0a9fd4f08b1f0bc10b7718a7577cb0146 (Bas= eTools: Print first cache missing file for build cachle)
Branches: maste= r, remotes/origin/master
Follows: edk2-stable201905
Precedes: edk2-st= able201908

=C2=A0

causes "unknown fatal error" in build.py when bu= ilding our platform.

=C2=A0

<= div>

Here is the log:

...
build.py...
=C2=A0: error C0DE: Unknown fatal error when pr= ocessing [/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/ArmPkg/Li= brary/ArmGicArchSecLib/ArmGicArchSecLib.inf]

(Please send email to <= a href=3D"mailto:devel@edk2.groups.io">devel@edk2.groups.io for help, a= ttaching following call stack trace!)

(Python 3.6.8 on linux) Traceb= ack (most recent call last):
=C2=A0 File "/home/volovyan/otherwork/= sandbox/uefi-related/uefi-orig/BaseTools/BinWrappers/PosixLike/../../Source= /Python/build/build.py", line 2493, in Main
=C2=A0 =C2=A0 MyBuild.L= aunch()
=C2=A0 File "/home/volovyan/otherwork/sandbox/uefi-related/= uefi-orig/BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.p= y", line 2287, in Launch
=C2=A0 =C2=A0 self._BuildPlatform()
=C2= =A0 File "/home/volovyan/otherwork/sandbox/uefi-related/uefi-orig/Base= Tools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line = 1742, in _BuildPlatform
=C2=A0 =C2=A0 self._BuildPa(self.Target, Pa, Ffs= Command=3DCmdListDict,PcdMaList=3DPcdMaList)
=C2=A0 File "/home/vol= ovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/BinWrappers/PosixL= ike/../../Source/Python/build/build.py", line 1236, in _BuildPa
=C2= =A0 =C2=A0 AutoGenObject.CreateCodeFile(True)
=C2=A0 File "/home/vo= lovyan/otherwork/sandbox/uefi-related/uefi-orig/BaseTools/Source/Python/Com= mon/caching.py", line 18, in CallMeHere
=C2=A0 =C2=A0 Value =3D sel= f._function(obj, *args,**kwargs)
=C2=A0 File "/home/volovyan/otherw= ork/sandbox/uefi-related/uefi-orig/BaseTools/Source/Python/AutoGen/Platform= AutoGen.py", line 171, in CreateCodeFile
=C2=A0 =C2=A0 Ma.CreateCod= eFile(CreateModuleCodeFile)
=C2=A0 File "/home/volovyan/otherwork/s= andbox/uefi-related/uefi-orig/BaseTools/Source/Python/AutoGen/ModuleAutoGen= .py", line 1841, in CreateCodeFile
=C2=A0 =C2=A0 LibraryAutoGen.Cre= ateCodeFile()
=C2=A0 File "/home/volovyan/otherwork/sandbox/uefi-re= lated/uefi-orig/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py", lin= e 1886, in CreateCodeFile
=C2=A0 =C2=A0 with GlobalData.cache_lock:
A= ttributeError: __enter__


- Failed -
Build end time: 13:31:30,= Sep.06 2019
Build total time: 00:00:04

=C2=A0

Builds before the above me= ntioned commit was pushed, were fine.

= =C2=A0

Thank you,

Vladimir

--000000000000ee8743059224700f--