From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.191.1587140361985317769 for ; Fri, 17 Apr 2020 09:19:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qi1mhPcu; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587140361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jB0ZxHUGDDw6rqtHqZ99DACPeo0K5alaUINJltbqHnM=; b=Qi1mhPcuTboADPoNcnKo5lhox8U6eUp8MOkvZSC829dDQsD+BCurVwNsIembH9RIzHkopZ l2s11RxwzA2oll8nRn9zZzX7Z7kT8WOyqfLqZ4F6ylv1w8Q46/gdFq/B6hSwgeK4quneRr I4JrFR00mnq8kW3lYj8dQMErCNBZnC0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-Ve1MOU5MPhaNSmChPJDJ5Q-1; Fri, 17 Apr 2020 12:19:15 -0400 X-MC-Unique: Ve1MOU5MPhaNSmChPJDJ5Q-1 Received: by mail-ed1-f71.google.com with SMTP id y4so240966edq.7 for ; Fri, 17 Apr 2020 09:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QriIVIx46Xv6CGmHLckLnjMK6gvokbRkgLjuYb82rpE=; b=nGUdp3IHEsbEzKZ5iOgUNhhnb2jS6v61/S1HswHb20s+imYLwya+oPPRAMlHQmzegK X0+OoiERZLrZY3UiELLL/a6RQAcstrp4cGQriutmheOY5aniPu/q1YXg/4OBD8t7xkqa kza3NZjojcdg2sqNT035/hJ/rLziWYubN++06AfS0R/O3Dvu1AGRW2GLdpIXN6x87OHD 5lEM/F7VBPd4uoWpD1naeceCF9mJa7Sux/x6VA3MyC0G7Yj7JQRcnEWdSDCfJzVEfA3s yU5YShNn3A+ilePIxjhmW4R78aG0EEYfTVKnpOUv8WUetVhYOUTZ36Vi0HFhDmdZDWIj Rc4A== X-Gm-Message-State: AGi0Pub/6Iwed0NOii192ZaCWH/+5XC4kSPzOA2cQTqcyfDiD+btDwUo fsAO1Vy2XQEiQ0A7EoiLCYNzQw450o10t48FpyMQ2KViSXWcuajAyqy10fvGkHoQDgPR8o4oV8a JlLeSMOn8Sqprtw== X-Received: by 2002:aa7:db88:: with SMTP id u8mr3898249edt.366.1587140354046; Fri, 17 Apr 2020 09:19:14 -0700 (PDT) X-Google-Smtp-Source: APiQypLcnS5wllOr3sDgDNwIVKnNta4DI3ay/rVaAKiEz8os65LLyt3J8SftjhHiodNS0kxXWIzMnA== X-Received: by 2002:aa7:db88:: with SMTP id u8mr3898229edt.366.1587140353811; Fri, 17 Apr 2020 09:19:13 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id f21sm2302124ejw.55.2020.04.17.09.19.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2020 09:19:13 -0700 (PDT) Subject: Re: [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix To: Ard Biesheuvel , Laszlo Ersek , edk2-devel-groups-io Cc: Anthony Perard , Jordan Justen , Julien Grall , Rebecca Cran References: <20200417153751.7110-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Fri, 17 Apr 2020 18:19:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/17/20 5:59 PM, Ard Biesheuvel wrote: > On 4/17/20 5:37 PM, Laszlo Ersek wrote: >> Ref:=C2=A0=C2=A0=C2=A0 https://bugzilla.tianocore.org/show_bug.cgi?id=3D= 2675 >> Repo:=C2=A0=C2=A0 https://pagure.io/lersek/edk2.git >> Branch: rsl_cleanup >> >> Rebecca's >> >> =C2=A0=C2=A0 [PATCH 02/13] OvmfPkg: support powering off bhyve guests >> >> at >> >> =C2=A0=C2=A0 https://edk2.groups.io/g/devel/message/57450 >> =20 >> http://mid.mail-archive.com/e4e9b29189b83076e1d1a0b9c989938f5226cab6.158= 6991816.git.rebecca@bsdio.com=20 >> >> >> made me realize OvmfPkg/ResetSystemLib should be refreshed. This will >> let us add a simple bhyve-specific instance (later), and also allows us >> to fix a long time dormant bug (now). >> >> Cc: Anthony Perard >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Julien Grall >> Cc: Philippe Mathieu-Daud=C3=A9 >> Cc: Rebecca Cran >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (6): >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: wrap long lines >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: clean up library dependencies >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: improve coding style in ResetSystem= () >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: factor out ResetShutdown() >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib >> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib ins= tance >> >=20 > For the series, >=20 > Reviewed-by: Ard Biesheuvel >=20 > One nit: putting a diff block inside the commit log [6/6] doesn't help=20 > legibility a lot, and the issue of not being able to access memory that= =20 > is not mapped for runtime is so basic that it doesn't require that level= =20 > of detail to describe a reproducer and the Linux kernel log output when= =20 > the issue is triggered. Personally I find the kernel log relevant, it will help to understand th=20 e patch when looking at it in >5years from now. >=20 >> =20 >> OvmfPkg/OvmfPkgIa32.dsc = =20 >> |=C2=A0 8 +- >> =20 >> OvmfPkg/OvmfPkgIa32X64.dsc = =20 >> |=C2=A0 8 +- >> =20 >> OvmfPkg/OvmfPkgX64.dsc = =20 >> |=C2=A0 8 +- >> =20 >> OvmfPkg/OvmfXen.dsc = =20 >> |=C2=A0 6 +- >> =C2=A0 OvmfPkg/Library/ResetSystemLib/{ResetSystemLib.inf =3D>=20 >> BaseResetSystemLib.inf} | 12 ++- >> =20 >> OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf = =20 >> | 43 ++++++++++ >> =20 >> OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c = =20 >> | 51 ++++++++++++ >> =20 >> OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c = =20 >> | 62 +++++++++++++++ >> =20 >> OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c = =20 >> | 84 +++++--------------- >> =C2=A0 9 files changed, 209 insertions(+), 73 deletions(-) >> =C2=A0 rename OvmfPkg/Library/ResetSystemLib/{ResetSystemLib.inf =3D>=20 >> BaseResetSystemLib.inf} (65%) >> =C2=A0 create mode 100644 OvmfPkg/Library/ResetSystemLib/DxeResetSystemL= ib.inf >> =C2=A0 create mode 100644 OvmfPkg/Library/ResetSystemLib/BaseResetShutdo= wn.c >> =C2=A0 create mode 100644 OvmfPkg/Library/ResetSystemLib/DxeResetShutdow= n.c >> >=20