From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.8397.1583385452898369850 for ; Wed, 04 Mar 2020 21:17:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 21:17:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,516,1574150400"; d="scan'208";a="274952851" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 04 Mar 2020 21:17:32 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 21:17:32 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Mar 2020 13:17:30 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Thu, 5 Mar 2020 13:17:30 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms. Thread-Topic: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC in edk2-platforms. Thread-Index: AQHV5IP4NVG3lRGa0Uqvh5TUskv9Hqg5CCKAgACI3QA= Date: Thu, 5 Mar 2020 05:17:30 +0000 Message-ID: References: <77612c8b6fcf7c752e0fac21d114e6ab9e7ebeb6.1581828141.git.newexplorerj@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch is for [edk2-platform]. So, please generate the patch with it. B= elow command can be used.=20 git format-patch -1 --subject-prefix=3D"edk2-platform][patch" > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhang, Sh= englei > Sent: Thursday, March 5, 2020 1:05 PM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC= in edk2-platforms. >=20 > Please update the subject. " IntelSiliconPkg: Add periods in comments" > With this updated, Reviewed-by: Shenglei Zhang >=20 > Thanks, > Shenglei >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > GuoMinJ > > Sent: Sunday, February 16, 2020 12:43 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ > > Subject: [edk2-devel] [PATCH] IntelSiliconPkg: Issue reported by ECC i= n edk2- > > platforms. > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2518 > > > > ECC need '.' character at the end of line. > > > > Signed-off-by: GuoMinJ > > --- > > .../Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 6 +++--= - > > .../Library/BaseConfigBlockLib/BaseConfigBlockLib.c | 6 +++--= - > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlock= Lib.h > > b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > index 99b8ae4b5a..37a3968168 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h > > @@ -10,7 +10,7 @@ > > #define _CONFIG_BLOCK_LIB_H_ > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be alloca= ted for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to = a pointer > > to the beginning of Config Block Table Address > > @@ -27,7 +27,7 @@ CreateConfigBlockTable ( > > ); > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to = a pointer to > > the beginning of Config Block Address > > @@ -44,7 +44,7 @@ AddConfigBlock ( > > ); > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beg= inning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUI= D uses to > > search specific Config Block > > diff --git > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB= lockLi > > b.c > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB= lockLi > > b.c > > index 33e0c81e9d..c89699ea46 100644 > > --- > > a/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB= lockLi > > b.c > > +++ > > b/Silicon/Intel/IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB= lockLi > > b.c > > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > > > /** > > - Create config block table > > + Create config block table. > > > > @param[in] TotalSize - Max size to be alloca= ted for the Config > > Block Table > > @param[out] ConfigBlockTableAddress - On return, points to = a pointer > > to the beginning of Config Block Table Address > > @@ -51,7 +51,7 @@ CreateConfigBlockTable ( > > } > > > > /** > > - Add config block into config block table structure > > + Add config block into config block table structure. > > > > @param[in] ConfigBlockTableAddress - A pointer to the begi= nning of > > Config Block Table Address > > @param[out] ConfigBlockAddress - On return, points to = a pointer to > > the beginning of Config Block Address > > @@ -94,7 +94,7 @@ AddConfigBlock ( > > } > > > > /** > > - Retrieve a specific Config Block data by GUID > > + Retrieve a specific Config Block data by GUID. > > > > @param[in] ConfigBlockTableAddress - A pointer to the beg= inning of > > Config Block Table Address > > @param[in] ConfigBlockGuid - A pointer to the GUI= D uses to > > search specific Config Block > > -- > > 2.17.1 > > > > > > >=20 >=20 >=20