* [PATCH] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h
@ 2020-04-30 1:15 Rebecca Cran
2020-04-30 14:16 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2020-04-30 1:15 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, Laszlo Ersek, Jordan Justen, Ard Biesheuvel
bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info
structure to IndustryStandard/LegacyVgaBios.h
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
.../Include/IndustryStandard/LegacyVgaBios.h | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h b/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h
index 317dac3a56..38360a68b2 100644
--- a/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h
+++ b/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h
@@ -86,6 +86,44 @@ typedef struct {
UINT32 MaxPixelClockHz;
UINT8 Reserved[190];
} VBE_MODE_INFO;
+
+typedef struct {
+ UINT16 ModeAttr;
+ UINT8 WindowAAttr;
+ UINT8 WindowBAttr;
+ UINT16 WindowGranularityKB;
+ UINT16 WindowSizeKB;
+ UINT16 WindowAStartSegment;
+ UINT16 WindowBStartSegment;
+ UINT32 WindowPositioningAddress;
+ UINT16 BytesPerScanLine;
+
+ UINT16 Width;
+ UINT16 Height;
+ UINT8 CharCellWidth;
+ UINT8 CharCellHeight;
+ UINT8 NumPlanes;
+ UINT8 BitsPerPixel;
+ UINT8 NumBanks;
+ UINT8 MemoryModel;
+ UINT8 BankSizeKB;
+ UINT8 NumImagePagesLessOne;
+ UINT8 Vbe3;
+
+ UINT8 RedMaskSize;
+ UINT8 RedMaskPos;
+ UINT8 GreenMaskSize;
+ UINT8 GreenMaskPos;
+ UINT8 BlueMaskSize;
+ UINT8 BlueMaskPos;
+ UINT8 ReservedMaskSize;
+ UINT8 ReservedMaskPos;
+ UINT8 DirectColorModeInfo;
+
+ UINT32 LfbAddress;
+ UINT32 OffScreenAddress;
+ UINT16 OffScreenSizeKB;
+} VBE2_MODE_INFO;
#pragma pack ()
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-devel] [PATCH] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h
2020-04-30 1:15 [PATCH] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h Rebecca Cran
@ 2020-04-30 14:16 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2020-04-30 14:16 UTC (permalink / raw)
To: devel, rebecca; +Cc: Jordan Justen, Ard Biesheuvel
On 04/30/20 03:15, Rebecca Cran wrote:
> bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info
> structure to IndustryStandard/LegacyVgaBios.h
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
> .../Include/IndustryStandard/LegacyVgaBios.h | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h b/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h
> index 317dac3a56..38360a68b2 100644
> --- a/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h
> +++ b/OvmfPkg/Include/IndustryStandard/LegacyVgaBios.h
> @@ -86,6 +86,44 @@ typedef struct {
> UINT32 MaxPixelClockHz;
> UINT8 Reserved[190];
> } VBE_MODE_INFO;
> +
> +typedef struct {
> + UINT16 ModeAttr;
> + UINT8 WindowAAttr;
> + UINT8 WindowBAttr;
> + UINT16 WindowGranularityKB;
> + UINT16 WindowSizeKB;
> + UINT16 WindowAStartSegment;
> + UINT16 WindowBStartSegment;
> + UINT32 WindowPositioningAddress;
> + UINT16 BytesPerScanLine;
> +
> + UINT16 Width;
> + UINT16 Height;
> + UINT8 CharCellWidth;
> + UINT8 CharCellHeight;
> + UINT8 NumPlanes;
> + UINT8 BitsPerPixel;
> + UINT8 NumBanks;
> + UINT8 MemoryModel;
> + UINT8 BankSizeKB;
> + UINT8 NumImagePagesLessOne;
> + UINT8 Vbe3;
> +
> + UINT8 RedMaskSize;
> + UINT8 RedMaskPos;
> + UINT8 GreenMaskSize;
> + UINT8 GreenMaskPos;
> + UINT8 BlueMaskSize;
> + UINT8 BlueMaskPos;
> + UINT8 ReservedMaskSize;
> + UINT8 ReservedMaskPos;
> + UINT8 DirectColorModeInfo;
> +
> + UINT32 LfbAddress;
> + UINT32 OffScreenAddress;
> + UINT16 OffScreenSizeKB;
> +} VBE2_MODE_INFO;
> #pragma pack ()
>
> #endif
>
Merged as commit e54310451f1a, via
<https://github.com/tianocore/edk2/pull/571>.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-30 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-30 1:15 [PATCH] OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h Rebecca Cran
2020-04-30 14:16 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox