From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.159.1605312744538351300 for ; Fri, 13 Nov 2020 16:12:24 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U8soTXVt; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605312743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/E5XWca6SwO648HtYcwVbHFzwiCj+9TmAO7EnQjPUJI=; b=U8soTXVtYQndoCwKZoHOJBmBi5yYfgGp/8s+8XqGWjACllThLti78VJ2ETtGMlQzAqnrro aB7egIzwEajfGBiWnkEAnmKlVzDj8d891LHKMcAXVEci3MBBI9lemLE+q8Awoo2yL5H7BK LpG7R3eIM9GpfVGdDLHz6IjCHWmBFAA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-6b0O_SoYMbCxqORlUQeW-w-1; Fri, 13 Nov 2020 19:12:20 -0500 X-MC-Unique: 6b0O_SoYMbCxqORlUQeW-w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75CD1803F76; Sat, 14 Nov 2020 00:12:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-113.ams2.redhat.com [10.36.112.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58FF35B4A7; Sat, 14 Nov 2020 00:12:18 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V4 11/13] OvmfPkg/BhyveX64.dsc: Enable MD5 while enable iSCSI To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Ard Biesheuvel , Leif Lindholm References: <20201112055558.2348-1-zhichao.gao@intel.com> <20201112055558.2348-12-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: Date: Sat, 14 Nov 2020 01:12:17 +0100 MIME-Version: 1.0 In-Reply-To: <20201112055558.2348-12-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/12/20 06:55, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 > > There is a plan to make MD5 disable as default. > The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES > would be introduced to enable MD5. Make the > definition ahead of the change to avoid build > error after the MACRO changed. > > Enable iSCSI. > > Signed-off-by: Zhichao Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index 16d2233d77..77e31af5d5 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -1,6 +1,6 @@ > # > # Copyright (c) 2020, Rebecca Cran > -# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) 2014, Pluribus Networks, Inc. > # > @@ -41,6 +41,7 @@ > DEFINE NETWORK_IP6_ENABLE = FALSE > DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > + DEFINE NETWORK_ISCSI_ENABLE = TRUE > > !include NetworkPkg/NetworkDefines.dsc.inc > > @@ -83,6 +84,8 @@ > INTEL:*_*_*_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES > GCC:*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > +!include NetworkPkg/NetworkBuildOptions.dsc.inc > + > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > XCODE:*_*_*_DLINK_FLAGS = -seg1addr 0x1000 -segalign 0x1000 > Reviewed-by: Laszlo Ersek Also, on top of Rebecca's recently-merged series (662b42db76a5..5e9a8a6dfb15), it makes sense to *attempt* building this patch. So: Build-tested-by: Laszlo Ersek Thanks Laszlo