From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.5436.1588769153617314954 for ; Wed, 06 May 2020 05:45:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=mrtHINbl; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.65, mailfrom: pete@akeo.ie) Received: by mail-wr1-f65.google.com with SMTP id i15so1604370wrx.10 for ; Wed, 06 May 2020 05:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ftnMxhHG+7UbJOO+4A5rWQm7+hzijTPfQ7OzaKCWoIU=; b=mrtHINblrCV+USW7RxXdxo32XzPmnUIaNdSsyMT9oHhrFp8Wiq95GY+aKtBOBDNWnZ g7b9++WloiiiGq0r4jEE6k+10PDAIACDckDGbEGIBdNqIIpM8m+pW9dZVABn8+aoIBrh 7CpEHy4JlmOo6A8rSfwd1TCBHCA2+Pwg1XaeaikpzwwGS+KUsWLyHdfaehGox364kjEs cBoB2zvRXZX3US5BXhgCS5QkmfTnY7RLIzI6WPz+YHRkSjUaKz1Mm6TAbLbTaSE4BqhX 85Wnpn1meh/v6NiNjImz0SHxtzlzWljsdOwK0MJAs6BYT7uxOTmlLW3mp13EAW1Ro6UH SKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ftnMxhHG+7UbJOO+4A5rWQm7+hzijTPfQ7OzaKCWoIU=; b=GkHVQBklbG9UzFhNgP0Qk3Wvrw+zMQCtY1bkkfXa03nY1RrT58m4/h9P6aHV3fLxfe NZb69DKqCa0NSB5/hvuTjgshxt0zuXT9AWO0+7pWHTsKRZI7SaWWB1oETr2U6P09TdTC OX2gn0zhvHz9Gt72WMv//aw8/hy6mXGc7y728kySomstJRKfcbT9zZrw4hUlEZodRBmi 6OKRzIzQz3LwhxqTvZ9P8/clkj0HIiQJ6dxn2+/9rfv8OP9W1oe7dgeZ4JLcEx5OrZF4 c0ZstXtaVZ09GOiTCHBP5fCp5tnmftvYTYSRylvsYvCbgR1GC9olVPWotVLwZEbWUQ4l 9hxA== X-Gm-Message-State: AGi0PuYwAgwJRoTS7BGpRr+ikCqh8F91aYMWNYgs2W8wK45OYwr3DtPn mlwz4ord0bcVlOFc+aNJsz1Ajw== X-Google-Smtp-Source: APiQypIM0qRMjH3B4oin/Ve4GorGApypdUvwZIQEVFNRKevmHmyaTYGX8biKbxAr0Kae5nBBRlFtMg== X-Received: by 2002:adf:dd50:: with SMTP id u16mr7566787wrm.58.1588769152207; Wed, 06 May 2020 05:45:52 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.75.87]) by smtp.googlemail.com with ESMTPSA id h74sm2019242wrh.76.2020.05.06.05.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2020 05:45:51 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI To: Ard Biesheuvel , devel@edk2.groups.io Cc: leif@nuviainc.com, awarkentin@vmware.com References: <20200506113748.8060-1-pete@akeo.ie> <7fe273c7-f0f0-b60f-39a8-e4385271abb6@arm.com> From: "Pete Batard" Message-ID: Date: Wed, 6 May 2020 13:45:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <7fe273c7-f0f0-b60f-39a8-e4385271abb6@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2020.05.06 13:26, Ard Biesheuvel wrote: > On 5/6/20 1:37 PM, Pete Batard wrote: > ... >> Therefore, since we do see a need for ACPI 6.x features, and >> effectively have a 6.3 table with PPTT, and also since we have >> tested that we are not seeing ill effects from doing so for the >> most common OSes we support, we bring all of the relevant ACPI >> tables to version 6.3. >> >> This is mostly accomplished by simply altering the version of >> ACPI being references in the macros, > > OK, so even the macros that resolve to the exact same code are renamed. > I suppose this means a blanket rename of everything once ACPI 6.4 comes > out? No. I am considering that we are still in the process of introducing the platform, therefore we introduce it with the most up to date version of ACPI at that time. Though I could see some point in doing so, I have no plan to update out ACPI for the Pi's every time a new version is released, unless there is an actual need to do so for a specific table or there is a blanket request (from seeing lots of folks using our code as a starting point) that warrants it. In other words, even as RPi3 was introduced a year ago, I consider that we are still in the process of adding RPi3/RPi4 as a brand new platform, and therefore want to use the most up to date ACPI at the time of introduction. But I'm definitely not making a point of trying to follow ACPI updates past that this. > >> except for the new fields >> being initialized in the MADT table where we: >> * Use 1 for GICR Base Address in GICC_STRUCTURE_INIT because, even >>    as this field is not supposed to apply to any of our platforms, >>    this is what Microsoft used in the original Pi 3 hardcoded MADT >>    blobs and Windows 10 doesn't boot on the Pi 3 if set to 0. > > Fair enough. > >> * Use 2 for GIC version in GIC_DISTRIBUTOR_INIT, since the Pi 4 GIC >>    is v2 only. >> > > OK. But you are introducing new references to ACPI_6_0 macros here. If > the point is to rename everything for cosmetic reasons, shouldn't you > use 6.3 there as well? Well, EFI_ACPI_6_0_GIC_DISTRIBUTOR_INIT was not updated for 6_1, 6_2, 6_3 (most likely because the macro, which is defined in EmbeddedPkg/Include/Library/AcpiLib.h applies the same for all 6.x versions), so I just used the highest version I could find, which is 6_0. This is based on what I saw other platforms do. I don't mind sending an EDK2 patch to add the various EFI_ACPI_6_x_GIC_DISTRIBUTOR_INIT if that's what you request, but that seems a bit like overkill and may break existing platforms, because it will most likely require moving EFI_ACPI_6_0_GIC_DISTRIBUTOR_INIT to a different header (MdePkg/Include/IndustryStandard/Acpi60.h). Regards, /Pete