From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Pedro Falcato <pedro.falcato@gmail.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list
Date: Thu, 2 Nov 2023 15:00:42 -0400 [thread overview]
Message-ID: <cc8f97aa-0785-4676-b1ba-29d4cb1d9583@linux.microsoft.com> (raw)
In-Reply-To: <1793D9A65F755370.11290@groups.io>
Commit 8da978bf68535ec9fc41f400f22f09b033dd535a
On 11/2/2023 11:59 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> - Adds Apache License 2.0 as an acceptable source license per
> discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
> used by opensource.org.
> - The submodule list in this file is stale and is very prone to
> being forgotten. The list of submodules in the submodules setion
> is replaced with a link to .gitmodules which has an active list
> of submodules at any given time.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
>
> Notes:
> v2 changes:
>
> - Add R-b and A-b tags
> - Update exisitng license URLs from http to https
> - Rework submodule section to remove unnecessary text and
> move the ArmSoftFloatLib note to the bottom of the section.
>
> ReadMe.rst | 31 ++++++++------------
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..06fb122ef382 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project, follow these steps.
> copyright license as the base project. When that is not possible,
> then contributions using the following licenses can be accepted:
>
> -- BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> -- BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> -- MIT: http://opensource.org/licenses/MIT
> -- Python-2.0: http://opensource.org/licenses/Python-2.0
> -- Zlib: http://opensource.org/licenses/Zlib
> +- Apache License, Version 2.0: https://opensource.org/license/apache-2-0/
> +- BSD (2-clause): https://opensource.org/license/BSD-2-Clause
> +- BSD (3-clause): https://opensource.org/license/BSD-3-Clause
> +- MIT: https://opensource.org/license/MIT
> +- Python-2.0: https://opensource.org/license/Python-2.0
> +- Zlib: https://opensource.org/license/Zlib
>
> For documentation:
>
> @@ -243,19 +244,7 @@ Definitions for sample patch email
> Submodules
> ----------
>
> -Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains the following submodules
> -
> -- CryptoPkg/Library/OpensslLib/openssl
> -- ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> -- MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> -- MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> -- BaseTools/Source/C/BrotliCompress/brotli
> -
> -ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
> -in openssl-1.1.1 (since stable201905) for floating point parameter
> -conversion, but should be dropped once there's no such need in future
> -release of openssl.
> +The current submodules used in EDK II are in `.gitmodules <.gitmodules>`__.
>
> To get a full, buildable EDK II repository, use following steps of git
> command
> @@ -283,6 +272,12 @@ dependency on being able to reach servers we do not actually want
> any code from, as well as needlessly downloading code we will not
> use.
>
> +**Submodule Notes**
> +
> +ArmSoftFloatLib is required by OpensslLib. It's inevitable in openssl-1.1.1
> +(since stable201905) for floating point parameter conversion, but should be
> +dropped once there's no such need in future release of openssl.
> +
> .. ===================================================================
> .. This is a bunch of directives to make the README file more readable
> .. ===================================================================
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110564): https://edk2.groups.io/g/devel/message/110564
Mute This Topic: https://groups.io/mt/102345483/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next parent reply other threads:[~2023-11-02 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1793D9A65F755370.11290@groups.io>
2023-11-02 19:00 ` Michael Kubacki [this message]
2023-11-02 15:59 [edk2-devel] [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list Michael Kubacki
2023-11-02 16:27 ` Pedro Falcato
2023-11-02 16:41 ` Michael D Kinney
2023-11-03 6:00 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc8f97aa-0785-4676-b1ba-29d4cb1d9583@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox