From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web08.32349.1661477571080800445 for ; Thu, 25 Aug 2022 18:32:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=I1GEXpkt; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 695435C00A5; Thu, 25 Aug 2022 21:32:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Aug 2022 21:32:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1661477570; x=1661563970; bh=PyHf8t/z++ GIumDc5fYiq8Wpr8IMAjCkaYWUU3yuGdU=; b=I1GEXpktC8heiSxuy+sHjMOBD0 5wzV6o93pMQ8Jr9aH7o6Zqwt+yyIao6zfUQ+XoBRAwoCeG4e7NsqiJkKOszz87dw uUgWqOw3644v2ZNbWMVQ+fiQCmkZLEXsWEnHQx5evTTteiQNrWObwTyNPijaLrH2 Q0K1QsE2RxYot/rJvxFa2w0L91jt6Ze5SGgAnaYsQsHH7D2IHPK1KRFgehG2KG2i SaHRj1w1w+Gd0ef9YKz6CLeKpblAcZKwWVe/io+1poHouXsszGkBaxBwao4BZdlN A53waiGZ0H/Wex4c21hpNktzFeaNbLZFQyqNg8N5j158zUndAZ5WQ3rAYmYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661477570; x=1661563970; bh=PyHf8t/z++GIumDc5fYiq8Wpr8IM AjCkaYWUU3yuGdU=; b=3ypf4beJlJN6H/mOvkYckgyeKmqvfkP+9xNf4P7iV4EZ ePbPtHJaLwrJ6dqerJ6oYGpRwwV9YDxKHXNy8X+FgfxF2dRvKsclGpaTp4+M8TBP l6Q/Kpd/534UDkh7xXu3kAFTWs4Ch8nFsqhmm4DMoe3l+Tu7ClLSvUzuuyWyxot4 dgVTebWTgAEP7TqQh1Vt4mcfwvnCjA+hWa+vaF9WuRFAT10wb3r09UtoOeY9h5Yo o+qrRaK7XsDIkGkOXs9IeDL8mQ+afM1rHF/e3olPOEXd2gOa5F7jyfIs4sqa01m9 CoLGB1cZWASUPekur+OWc887SrZhnIeazyymIVoZLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejgedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfhfhfgjsegrtderredtfeejnecuhfhrohhmpeftvggsvggt tggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrghtth gvrhhnpeffuddvgfevlefgkeejjedutefhffffvefhffejkeeuleeuffeffefgtedvfedu vdenucffohhmrghinhepghhithhhuhgsrdgtohhmpdgsshguihhordgtohhmpdhgrhhouh hpshdrihhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Aug 2022 21:32:48 -0400 (EDT) Message-ID: Date: Fri, 26 Aug 2022 01:32:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [edk2-devel] BaseTools no longer builds on macOS: "error: unknown warning option '-Werror=stringop-overflow'" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "afish@apple.com" , "Gao, Liming" , Leif Lindholm References: <170EA793884203D0.22386@groups.io> <04d48cc6-a9da-ff39-3403-b1d0abd1f045@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Type: multipart/alternative; boundary="------------jz0c6qO1OoKZFOZkS0fx6aKq" Content-Language: en-US --------------jz0c6qO1OoKZFOZkS0fx6aKq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Thanks. I've submitted it - the subject is "[PATCH edk2-stable202208 1/1] BaseTools: Fix DevicePath GNUmakefile for macOS" -- Rebecca Cran On 8/25/2022 5:51 PM, Kinney, Michael D wrote: > > Hi Rebecca, > > +Liming > > This looks like a low risk change to me.But given that the release is > supposed to occur tonight, we may need to delay the release 1-2 days > to make sure there are no side effects. > > Can you please prepare a patch with this change for review and make > sure it is marked for this stable tag. > > There is one other revert being considered, so a delay of 1-2 days may > be appropriate for that issue as well. > > Mike > > *From:*Rebecca Cran > *Sent:* Thursday, August 25, 2022 4:13 PM > *To:* devel@edk2.groups.io; afish@apple.com > *Cc:* Kinney, Michael D > *Subject:* Re: [edk2-devel] BaseTools no longer builds on macOS: > "error: unknown warning option '-Werror=stringop-overflow'" > > Thanks, that patch works. Is it too late to get it in for the stable tag? > > Reviewed-by: Rebecca Cran > > On 8/25/22 11:49, Andrew Fish via groups.io wrote: > > Maybe having the check last would be cleaner. > > *diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile* > > *index c217674345b1..17f213879e82 100644* > > *--- a/BaseTools/Source/C/DevicePath/GNUmakefile* > > *+++ b/BaseTools/Source/C/DevicePath/GNUmakefile* > > @@ -16,10 +16,12 @@include $(MAKEROOT)/Makefiles/app.makefile > >  GCCVERSION = $(shell gcc -dumpversion | awk -F'.' '{print $$1}') > >  ifneq ("$(GCCVERSION)", "5") > >  ifneq ($(CXX), llvm) > > +ifneq ($(DARWIN),Darwin) > >  # gcc 12 trips over device path handling > >  BUILD_CFLAGS += -Wno-error=stringop-overflow > >  endif > >  endif > > +endif > >  LIBS = -lCommon > >  ifeq ($(CYGWIN), CYGWIN) > > > > Thanks, > > Andrew Fish > > > > On Aug 25, 2022, at 10:45 AM, Andrew Fish via groups.io > > wrote: > > Rebecca, > > FYI /usr/bin/gcc has been a redirector into clang for a lot of > years. > > The build picks different default sets of complier flags based > on build type. There is already code that assumes gcc == clang > here [1] > > I think the issue is the check that is wrapping "BUILD_CFLAGS > += -Wno-error=stringop-overflow”. It needs to skip the check > on macOS. > > *diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile* > > *index c217674345b1..f3c9739617f2 100644* > > *--- a/BaseTools/Source/C/DevicePath/GNUmakefile* > > *+++ b/BaseTools/Source/C/DevicePath/GNUmakefile* > > @@ -14,12 +14,14 @@OBJECTS = DevicePath.o UefiDevicePathLib.o > DevicePathFromText.o DevicePathUtili > >  include $(MAKEROOT)/Makefiles/app.makefile > >  GCCVERSION = $(shell gcc -dumpversion | awk -F'.' '{print $$1}') > > +ifneq ($(DARWIN),Darwin) > >  ifneq ("$(GCCVERSION)", "5") > >  ifneq ($(CXX), llvm) > >  # gcc 12 trips over device path handling > >  BUILD_CFLAGS += -Wno-error=stringop-overflow > >  endif > >  endif > > +endif > >  LIBS = -lCommon > >  ifeq ($(CYGWIN), CYGWIN) > > > > [1] > https://github.com/tianocore/edk2/blob/master/BaseTools/Source/C/Makefiles/header.makefile#L83 > > Thanks, > > Andrew Fish > > > > On Aug 25, 2022, at 9:20 AM, Rebecca Cran > wrote: > > BaseTools no longer builds on macOS (12.5.1, Monterey), > because 'gcc' in /usr/bin is really clang. > > I tried installing gcc 12 from Homebrew, but the build > then failed saying it couldn't find _stdio.h. > > It appears the breakage might have been introduced in this > commit back in March: > > commit 22130dcd98b4d4b76ac8d922adb4a2dbc86fa52c > Author: Gerd Hoffmann > > Date:   Thu Mar 24 20:04:36 2022 +0800 > >     Basetools: turn off gcc12 warning > > Running "make -C BaseTools" produces the following error: > > > /Library/Developer/CommandLineTools/usr/bin/make -C DevicePath > gcc  -c  -I .. -I ../Include/Common -I ../Include/ -I > ../Include/IndustryStandard -I ../Common/ -I .. -I . -I > ../Include/X64/ -MD -fshort-wchar -fno-strict-aliasing > -Wall -Werror -Wno-deprecated-declarations > -Wno-self-assign -Wno-unused-result -nostdlib -g -O2 > -Wno-error=stringop-overflow DevicePath.c -o DevicePath.o > error: unknown warning option '-Werror=stringop-overflow'; > did you mean '-Werror=shift-overflow'? > [-Werror,-Wunknown-warning-option] > make[2]: *** [DevicePath.o] Error 1 > make[1]: *** [DevicePath] Error 2 > make: *** [Source/C] Error 2 > > > bcran@procan edk2 % gcc -v > Configured with: > --prefix=/Library/Developer/CommandLineTools/usr > --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1 > Apple clang version 12.0.5 (clang-1205.0.22.9) > Target: x86_64-apple-darwin21.6.0 > Thread model: posix > InstalledDir: /Library/Developer/CommandLineTools/usr/bin > > bcran@procan edk2 % uname -a > Darwin procan.int.bsdio.com 21.6.0 Darwin Kernel Version > 21.6.0: Wed Aug 10 14:25:27 PDT 2022; > root:xnu-8020.141.5~2/RELEASE_X86_64 x86_64 > > -- > Rebecca Cran > > > --------------jz0c6qO1OoKZFOZkS0fx6aKq Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Thanks. I've submitted it - the subject is "[PATCH edk2-stable202208 1/1] BaseTools: Fix DevicePath GNUmakefile for macOS"


--

Rebecca Cran


On 8/25/2022 5:51 PM, Kinney, Michael D wrote:

Hi Rebecca,

 

+Liming

 

This looks like a low risk change to me.  But given that the release is supposed to occur tonight, we may need to delay the release 1-2 days to make sure there are no side effects.

 

Can you please prepare a patch with this change for review and make sure it is marked for this stable tag.

 

There is one other revert being considered, so a delay of 1-2 days may be appropriate for that issue as well.

 

Mike

 

From: Rebecca Cran <rebecca@bsdio.com>
Sent: Thursday, August 25, 2022 4:13 PM
To: devel@edk2.groups.io; afish@apple.com
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] BaseTools no longer builds on macOS: "error: unknown warning option '-Werror=stringop-overflow'"

 

Thanks, that patch works. Is it too late to get it in for the stable tag?

 

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>

 

On 8/25/22 11:49, Andrew Fish via groups.io wrote:

Maybe having the check last would be cleaner. 

 

diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile

index c217674345b1..17f213879e82 100644

--- a/BaseTools/Source/C/DevicePath/GNUmakefile

+++ b/BaseTools/Source/C/DevicePath/GNUmakefile

@@ -16,10 +16,12 @@ include $(MAKEROOT)/Makefiles/app.makefile

 GCCVERSION = $(shell gcc -dumpversion | awk -F'.' '{print $$1}')

 ifneq ("$(GCCVERSION)", "5")

 ifneq ($(CXX), llvm)

+ifneq ($(DARWIN),Darwin)

 # gcc 12 trips over device path handling

 BUILD_CFLAGS += -Wno-error=stringop-overflow

 endif

 endif

+endif

 

 LIBS = -lCommon

 ifeq ($(CYGWIN), CYGWIN)



 

Thanks,

 

Andrew Fish



On Aug 25, 2022, at 10:45 AM, Andrew Fish via groups.io <afish=apple.com@groups.io> wrote:

 

Rebecca,

 

FYI /usr/bin/gcc has been a redirector into clang for a lot of years. 

 

The build picks different default sets of complier flags based on build type. There is already code that assumes gcc == clang here [1]

 

I think the issue is the check that is wrapping "BUILD_CFLAGS += -Wno-error=stringop-overflow”. It needs to skip the check on macOS. 

 

diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile

index c217674345b1..f3c9739617f2 100644

--- a/BaseTools/Source/C/DevicePath/GNUmakefile

+++ b/BaseTools/Source/C/DevicePath/GNUmakefile

@@ -14,12 +14,14 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o  DevicePathUtili

 include $(MAKEROOT)/Makefiles/app.makefile

 

 GCCVERSION = $(shell gcc -dumpversion | awk -F'.' '{print $$1}')

+ifneq ($(DARWIN),Darwin)

 ifneq ("$(GCCVERSION)", "5")

 ifneq ($(CXX), llvm)

 # gcc 12 trips over device path handling

 BUILD_CFLAGS += -Wno-error=stringop-overflow

 endif

 endif

+endif

 

 LIBS = -lCommon

 ifeq ($(CYGWIN), CYGWIN)



 

 

Thanks,

 

Andrew Fish



On Aug 25, 2022, at 9:20 AM, Rebecca Cran <rebecca@bsdio.com> wrote:

 

BaseTools no longer builds on macOS (12.5.1, Monterey), because 'gcc' in /usr/bin is really clang.

I tried installing gcc 12 from Homebrew, but the build then failed saying it couldn't find _stdio.h.

It appears the breakage might have been introduced in this commit back in March:

commit 22130dcd98b4d4b76ac8d922adb4a2dbc86fa52c
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Thu Mar 24 20:04:36 2022 +0800

    Basetools: turn off gcc12 warning

Running "make -C BaseTools" produces the following error:


/Library/Developer/CommandLineTools/usr/bin/make -C DevicePath
gcc  -c  -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/X64/ -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g -O2  -Wno-error=stringop-overflow DevicePath.c -o DevicePath.o
error: unknown warning option '-Werror=stringop-overflow'; did you mean '-Werror=shift-overflow'? [-Werror,-Wunknown-warning-option]
make[2]: *** [DevicePath.o] Error 1
make[1]: *** [DevicePath] Error 2
make: *** [Source/C] Error 2


bcran@procan edk2 % gcc -v
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 12.0.5 (clang-1205.0.22.9)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

bcran@procan edk2 % uname -a
Darwin procan.int.bsdio.com 21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:25:27 PDT 2022; root:xnu-8020.141.5~2/RELEASE_X86_64 x86_64

--
Rebecca Cran

 

 

--------------jz0c6qO1OoKZFOZkS0fx6aKq--