From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web09.15415.1633377402144687217 for ; Mon, 04 Oct 2021 12:56:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=gICodkaW; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 194JCHwc028731; Mon, 4 Oct 2021 15:56:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=kcxoQlbwfuXA3ZeuAZgWqRExSCVdmPSSbBpk4Io1Nf8=; b=gICodkaWfLE3LJdGIk0SjmxYF+GG5R+zW3FJT+2t/TGJl/iCe6FdlWkI3khWVdA4+8Fv S1Fu/iagZzCYA9JrCAqioOmbcnbexJCbUTVXj4gVAfW9GJGlZpFpPnZuDBemHurh8x3i tNez49OeyfByeyBLPgLomA1TdO2MykoK5mE5NxiMzZK3gZs3m7Ta/ixl+NGPe0nbFNui A7J6tfCcIsQ3I34C7nsgfYOLcoVhWoMeYa9WchYivccxde9TU+kVJw1fNfQK298uYYvj YRntkm8wP8a4VZrYl6Hr1YaSJHARYTByCkoEZg+LmnPcoeNf0ZqTKWi87LBKCe69xvk8 CA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bg7j9gs1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 15:56:38 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 194JPcFt013690; Mon, 4 Oct 2021 15:56:38 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bg7j9gs19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 15:56:38 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 194JqXWK032382; Mon, 4 Oct 2021 19:56:37 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma01wdc.us.ibm.com with ESMTP id 3bef2a5fg4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 19:56:37 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 194JuaVa30409246 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Oct 2021 19:56:36 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7BA7378063; Mon, 4 Oct 2021 19:56:36 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 139A47805E; Mon, 4 Oct 2021 19:56:35 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 4 Oct 2021 19:56:35 +0000 (GMT) Subject: Re: [PATCH v4 0/3] ArmVirtPkg: Disable the TPM 2 platform hierarchy To: devel@edk2.groups.io, "Yao, Jiewen" Cc: marcandre.lureau@redhat.com, kraxel@redhat.com, ardb+tianocore@kernel.org, leif@nuviainc.com, sami.mujawar@arm.com References: <20210924114221.3132368-1-stefanb@linux.ibm.com> From: "Stefan Berger" Message-ID: Date: Mon, 4 Oct 2021 15:56:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210924114221.3132368-1-stefanb@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: G1V9xV9Du0XvTYavSI_5227dLDHJcBBk X-Proofpoint-GUID: NsFIHdioGgYbjSkRVkbAwXSFsoj-22Cw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-04_05,2021-10-04_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=957 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110040132 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-001b2d01.pphosted.com id 194JCHwc028731 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Yao, =C2=A0=C2=A0 I think this series has the needed R-b's and should be comm= it-able. Cheers! =C2=A0=C2=A0 Stefan On 9/24/21 7:42 AM, Stefan Berger wrote: > This series of patches disables the TPM 2 platform hierarchy. > We just added the same functionality to the OvmfPkg. However, on x86, w= e > could use the notification mechanism around gEfiDxeSmmReadyToLockProtoc= olGuid > to indirectly invoke ConfigureTpmPlatformHierarchy(). Since ARM does no= t > have an SMM mode this series now use direct invocation of this function > at the same place in PlatformBootManagerBeforeConsole() as it is done > on x86. > > Regards, > Stefan > > v4: > - Added Sami's R-b tag to 1/3 > > v3: > - Addressed Ard's comments on 1/3 > > v2: > - Move Null implementation to SecurityPkg > - Added suggested texts to commit messages and added Sami's R-b tags > > Stefan Berger (3): > ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib > ArmVirtPkg: Reference new TPM classes in the build system for > compilation > ArmVirtPkg: Disable the TPM2 platform hierarchy > > ArmVirtPkg/ArmVirtCloudHv.dsc | 1 + > ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > .../PlatformBootManagerLib/PlatformBm.c | 6 ++++ > .../PlatformBootManagerLib.inf | 2 ++ > .../PeiDxeTpmPlatformHierarchyLib.c | 22 +++++++++++++ > .../PeiDxeTpmPlatformHierarchyLib.inf | 31 ++++++++++++++++++= + > SecurityPkg/SecurityPkg.dsc | 1 + > 9 files changed, 67 insertions(+) > create mode 100644 SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibN= ull/PeiDxeTpmPlatformHierarchyLib.c > create mode 100644 SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibN= ull/PeiDxeTpmPlatformHierarchyLib.inf >