From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.70]) by mx.groups.io with SMTP id smtpd.web08.6599.1639750524795669216 for ; Fri, 17 Dec 2021 06:15:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=qVV68yEb; spf=pass (domain: arm.com, ip: 40.107.22.70, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRknmtNFFTBDHjHIw21cowWeGeYbqovkY5MyWBWx4XY=; b=qVV68yEbJUhpgicf8GyzuM+4iK0v0aHda4vV2o0QYkCh1rpl9FSl143rnbrapyzqmDNMlYtn42ak2YQEDm+mI67QjRL29a9tlpfh5ePthedjHI8x9HFO+iB3sSwIIoicVZGK2yaMfL42Xjdkg1sFmn8yaV73gFBsuCtS/Dh78LA= Received: from AM6P192CA0013.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::26) by VE1PR08MB4845.eurprd08.prod.outlook.com (2603:10a6:802:a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 14:15:20 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::7b) by AM6P192CA0013.outlook.office365.com (2603:10a6:209:83::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:15:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:15:20 +0000 Received: ("Tessian outbound 1cd1a01725a6:v110"); Fri, 17 Dec 2021 14:15:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3dcac4c970ac5291 X-CR-MTA-TID: 64aa7808 Received: from e516a1dbf5b0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B590A177-683A-4956-BE2D-0C4C155C35B5.1; Fri, 17 Dec 2021 14:15:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e516a1dbf5b0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Dec 2021 14:15:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frgcG2CgTiCSYUPEEfV60gu1bMicQgUaz8UlZUSxURStGNO5v8VcMOuIi3rmoj+Uo7k4+opGv8XGgqvKGpkx3EYHSl7ezdVCExke2WhdZW2P7hZTZ/yJaBvgPxdXi7yOikF68SXrHPHz8hAXkVW21T9AeDC8d6qRw95pDTVSA1rJtUhOtE2S5Yp80X7itTTvXCziY/ToJHGra7vaJZDRbjMeo83nU+xGOt8wg73M9/n9hAQrTiJqU3mrnV7BJq5sJV93hvXWVbD/VHOxA3BgEMUM5XFJG3xOHpwR0ew5+qx6s+Nll4FhiQpUreBPwNmqDEtsKjAE1XpgHMJjEBdA5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZRknmtNFFTBDHjHIw21cowWeGeYbqovkY5MyWBWx4XY=; b=NQ3Vp9TB68yxr8lOulRYdM+P/xG6J90B6N0lzrPj+QkGty9ZTmIBpmCCXB4MkLJyQfdfDdsTCLWm2XIdIYq+QumS9oUrLAFSoqqCWx8LwXL4limZvgF3CvsrOUeF0g0befEsxeEfpR+hTT5xOM7QohVBxZx/pwCxMpI7fyMEuNzjIPs73Nxqtc2ixWCIK7vhSBiISUY6eyDBIO8p7o2AoCYRk6XHCSMp/ndYeT1BvEuSsGjgSh5kdurJt8/Wwn8bwAp7THYUSgamWhTj4U7H89EV/nq7DfxdvnIFGhTs6+7qo5ffdTuyr6Y1mJE9cwbBrpcQiFyP4QfJvZXFKPlJUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRknmtNFFTBDHjHIw21cowWeGeYbqovkY5MyWBWx4XY=; b=qVV68yEbJUhpgicf8GyzuM+4iK0v0aHda4vV2o0QYkCh1rpl9FSl143rnbrapyzqmDNMlYtn42ak2YQEDm+mI67QjRL29a9tlpfh5ePthedjHI8x9HFO+iB3sSwIIoicVZGK2yaMfL42Xjdkg1sFmn8yaV73gFBsuCtS/Dh78LA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1650.eurprd08.prod.outlook.com (2603:10a6:203:2f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Fri, 17 Dec 2021 14:15:09 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 17 Dec 2021 14:15:08 +0000 Subject: Re: [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008 To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-7-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: Date: Fri, 17 Dec 2021 14:15:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211124162330.236813-7-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P265CA0035.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO4P265CA0035.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 17 Dec 2021 14:15:08 +0000 X-MS-Office365-Filtering-Correlation-Id: 3f296592-e78f-45bd-08a0-08d9c167a8bb X-MS-TrafficTypeDiagnostic: AM5PR0801MB1650:EE_|VE1EUR03FT023:EE_|VE1PR08MB4845:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VkXzU99FfPlNQzd1DVv/iZ1kcvvUAbGp4DJLRTgSc1ouIxqZj2vFaHbAwy+LhXWiNPolND5JPFC+xHmmjAITJhP1yloI82YSNZb0Hcvt46MbnC4/MbiZHtoP8PMFLcyRHSNA0E9iY1f8+0H34ekEXPSyjQmnnL4hWJkY3Gz0lbRvIllEOF7+Bpw12hBgXE8msKPIb9zG07GRJ0u04kUR6WEPU3B6r4Ac2zQf8GEKJYxR8Y0CH1QDy+VKltN/v5nBwMhWXDBJiWquqnY2Do6niIbbsO/TTjEFhmr1npKV1vUe2FsVCMqfQ65SEQawDqv2Pu7sOFNV40sCbjulmFnXVaE474MP+HPSbDO2EP3iXejwwxsbZQk8F8OmHHhgQOjYwNSMvD6IMIp0sBJxPr3Dn3MAEaDRuve4RmNB3lTH9QwWbhFSrekKM9Wbppy5XkQRX//oCyvfwyUW+rA++y3cZS/GIh9CTwTY+t0xopDopDJ5k01JKA+hHDsQwLOrkjZOKqwlYbq1U28Zky8NilIS2qAnVy4efYMueXNgz/NDA/szlESguMdmzRibGz6+n0AQTXgdIAA+p1dqU5cgplap/EiHKsW06wwX6KFB6a3qYmK7VykDjGRf2dsBAGsWnnGQfhhne5trMOrpHRRUMNJ14UmpZBpAX21ghr8g4Iiua5cW3CzIhcRqvJLrq2qy0Lrm/xwomTR8gJZ1uhp3xbdobEb6xjD7tjAU54t8x+mPortDomNaBZB65kMlulJThZ6nIeVhrtqafScmjFUsoUBUxg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6636002)(83380400001)(36756003)(38100700002)(37006003)(8936002)(16576012)(508600001)(26005)(316002)(31696002)(86362001)(31686004)(19627235002)(8676002)(38350700002)(53546011)(2616005)(186003)(956004)(52116002)(66946007)(44832011)(66556008)(6486002)(6666004)(66476007)(6862004)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1650 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 53575913-8a67-4177-3b86-08d9c167a1ae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hT7IaWfAqrej39pVDeBAlUxMB2obKcTzhVrd1ozaI98HB0Xzx1bz/FVrlLJ9z+rIuwvtWgNQnKBaRTC+e8+cJCp0vudm5/sD6hloYTgkhQAgAAZDaKEsF8Ri+FUNuJEEwTf+eBjs9eioouuQPK+sTgW2DVZeFj4aKPEuycygyFHGBY0bt/N5Puq+3nuPD3URmz9zlFiWoYnGAG0Hx3saYl55ZHPbuub79I5FL41XYQFywIMQVYX0ACVgzmitOHS/CYuTNuM/7uSLAPjn2YX2iGUHsQbgwDnS6a39fq4N56Ox/cVgEIkqxB+vY0lla0YpYWxSm8aesEn2uFhSDxQpszuTeUVVrDkrQpHCbGYTXBSKfPSFOkyMEzDsKOeFCmD3u68AUPCCo5QvyQZcmprtKGFZKyVy+Xqex5M1IzpnWp48w1/iXevR7zFgJJ5XprpscFGqqNKuJd+NB5u9T8yoo1Vzxew3tqDyt9UK7DWicxc/sbXFXJFoXAcggpWOLg7eUv6bnWns72eh5ChQqYorxj00MZ9KtM6VMvBz/0/4cbr7e0hkoUeBMb9Ptz1ci7+r2WtndLjR92utt8ZejYjBUe1cfbrDyxtC/8OzJR6Tr2lLubz3TTY77jZjzArqSvLBRxQhrEAj2LdXJDS6I5cUClbXD0ahBzaAX52PB8xSdsyn/6MUrBpnBVzzBLFn3Al3vP0cO1g3N0FVpI5Dje4OyUJx4RKdDZLDeIwH0yM8nU+7OYmIvxaybhNXI08qTcgqkzwAOF9swmGpMpAxA1BVE5roHSY6Zb8GfRTXKMi+JWo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(336012)(8676002)(956004)(37006003)(82310400004)(2616005)(83380400001)(6636002)(8936002)(26005)(81166007)(31696002)(19627235002)(36756003)(6666004)(186003)(16576012)(36860700001)(5660300002)(86362001)(47076005)(316002)(2906002)(53546011)(40460700001)(6862004)(508600001)(6486002)(70206006)(356005)(44832011)(31686004)(70586007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 14:15:20.5164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f296592-e78f-45bd-08a0-08d9c167a8bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4845 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > This patch fixes the following Ecc reported error: > File has invalid Non-ACSII char. > > Signed-off-by: Pierre Gondois > --- > .../Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDe= vice.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c > index b51e2b3fa1a6..90907bc19a8f 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c > @@ -259,7 +259,7 @@ UpdateMemorySize ( > } > > /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0= 134, > - Table 75 =E2=80=93 Memory Device (Type 17) structure, description f= or Size field. > + Table 75 - Memory Device (Type 17) structure, description for Size = field. > If the value is 0, no memory device is installed in the socket; if > the size is unknown, the field value is FFFFh. > */ > @@ -276,13 +276,13 @@ UpdateMemorySize ( > } > > /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0= 134, > - Table 75 =E2=80=93 Memory Device (Type 17) structure, description f= or Size field. > + Table 75 - Memory Device (Type 17) structure, description for Size = field. > If the size is 32 GB-1 MB or greater, the field value is 7FFFh and= the > actual size is stored in the Extended Size field. > */ > if (MemorySize < (SIZE_32GB - SIZE_1MB)) { > /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DS= P0134, > - section 7.18.5 Memory Device =E2=80=94 Extended Size > + section 7.18.5 Memory Device - Extended Size > For compatibility with older SMBIOS parsers, memory devices > smaller than (32 GB - 1 MB) should be represented using their > size in the Size field, leaving the Extended Size field set to 0= . > @@ -290,7 +290,7 @@ UpdateMemorySize ( > Type17Table->ExtendedSize =3D 0; > > /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DS= P0134, > - Table 75 =E2=80=93 Memory Device (Type 17) structure, description= for Size field. > + Table 75 - Memory Device (Type 17) structure, description for Siz= e field. > The granularity in which the value is specified depends on the s= etting > of the most-significant bit (bit 15). If the bit is 0, the value= is > specified in megabyte units; if the bit is 1, the value is speci= fied > @@ -308,7 +308,7 @@ UpdateMemorySize ( > } > > /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0= 134, > - section 7.18.5 Memory Device =E2=80=94 Extended Size > + section 7.18.5 Memory Device - Extended Size > The Extended Size field is intended to represent memory devices > larger than 32,767 MB (32 GB - 1 MB), which cannot be described > using the Size field. This field is only meaningful if the value > @@ -317,12 +317,12 @@ UpdateMemorySize ( > Type17Table->Size =3D 0x7FFF; > > /* Ref: SMBIOS Specifiation, Version 3.4.0, Document Identifier: DSP0= 134, > - section 7.18.5 Memory Device =E2=80=94 Extended Size > + section 7.18.5 Memory Device - Extended Size > Bit 31 is reserved for future use and must be set to 0. > Bits 30:0 represent the size of the memory device in megabytes. > EXAMPLE: 0000_8000h indicates a 32 GB memory device (32,768 MB), > 0002_0000h represents a 128 GB memory device (131,072 MB)= , and > - 0000_7FFFh represents a 32,767 MB (32 GB =E2=80=93 1 MB) d= evice. > + 0000_7FFFh represents a 32,767 MB (32 GB - 1 MB) device. > */ > Type17Table->ExtendedSize =3D (MemorySize >> 20) & (~BIT31); > return EFI_SUCCESS; > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.