From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 26 Apr 2019 12:37:15 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9DE703F725; Fri, 26 Apr 2019 19:37:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id B34A74501; Fri, 26 Apr 2019 19:37:09 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static To: "Wu, Hao A" , "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , "Bi, Dandan" References: <20190426010404.20624-1-zhichao.gao@intel.com> <20190426010404.20624-6-zhichao.gao@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7C4671@SHSMSX101.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 26 Apr 2019 21:37:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 26 Apr 2019 19:37:14 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/26/19 10:30, Wu, Hao A wrote: >> -----Original Message----- >> From: Gao, Zhichao >> Sent: Friday, April 26, 2019 4:12 PM >> To: Wu, Hao A; devel@edk2.groups.io; Laszlo Ersek >> Cc: Laszlo Ersek; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Bi, Dandan >> Subject: RE: [edk2-devel] [PATCH V3 5/8] >> MdeModulePkg/FirmwarePerformanceDxe: make global variable static >> >> >> >>> -----Original Message----- >>> From: Wu, Hao A >>> Sent: Friday, April 26, 2019 1:58 PM >>> To: devel@edk2.groups.io; Gao, Zhichao ; Laszlo >>> Ersek >>> Cc: Laszlo Ersek ; Wang, Jian J ; >>> Ni, Ray ; Zeng, Star ; Gao, Liming >>> ; Bi, Dandan >>> Subject: RE: [edk2-devel] [PATCH V3 5/8] >>> MdeModulePkg/FirmwarePerformanceDxe: make global variable static >>> >>>> -----Original Message----- >>>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>>> Gao, Zhichao >>>> Sent: Friday, April 26, 2019 9:04 AM >>>> To: devel@edk2.groups.io >>>> Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, >>>> Liming; Bi, Dandan >>>> Subject: [edk2-devel] [PATCH V3 5/8] >>>> MdeModulePkg/FirmwarePerformanceDxe: make global variable static >>> >>> After checking Laszlo's comment on V2: >>> >>> ''' >>> (1) in all of the subject lines, please replace >>> >>> Decrease the name collisions >>> >>> with >>> >>> make mExitBootServicesEvent STATIC >>> ''' >>> >>> I prefer the one suggested by Laszlo, the proposed subject here gives me >>> the feeling of changing all the global variables in the module. >>> >>> However, I am okay if you stick with the proposed subject. Anyway, >>> Reviewed-by: Hao Wu >> >> I want to use that subject too. But the actual variable name ' >> mExitBootServicesEvent' is too long. If the changed driver name is also long >> such as patch #5, then the subject would be out of size. And the actual changed >> global variable is mentioned in the commit message. That is why I didn't take >> Laszlo's suggestion. > > Got it. > > Just my opinion, the 72 characters limit for subject can be violated in > special cases. And I believe this is one of the cases when keeping the > title short makes it misleading. I agree. But, I think three versions of this patch series should be plenty :) So I'm not requesting a repost. Thanks Laszlo > > Best Regards, > Hao Wu > >> >> Thanks, >> Zhichao >> >>> >>> Best Regards, >>> Hao Wu >>> >>>> >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 >>>> >>>> Add a 'static' storage-class specifier to the global variables that >>>> only used in a single file to minimize the name collisions. >>>> This is only for the variable named 'mExitBootServicesEvent'. >>>> >>>> Cc: Laszlo Ersek >>>> Cc: Jian J Wang >>>> Cc: Hao Wu >>>> Cc: Ray Ni >>>> Cc: Star Zeng >>>> Cc: Liming Gao >>>> Cc: Dandan Bi >>>> Signed-off-by: Zhichao Gao >>>> --- >>>> .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 4 >>>> ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git >>>> >>> a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firm >>> wa >>>> rePerformanceDxe.c >>>> >>> b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firm >>> wa >>>> rePerformanceDxe.c >>>> index 9713048f1f..61a7704b37 100644 >>>> --- >>>> >>> a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firm >>> wa >>>> rePerformanceDxe.c >>>> +++ >>>> >>> b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firm >>> wa >>>> rePerformanceDxe.c >>>> @@ -5,7 +5,7 @@ >>>> for Firmware Basic Boot Performance Record and other boot >>>> performance records, >>>> and install FPDT to ACPI table. >>>> >>>> - Copyright (c) 2011 - 2018, Intel Corporation. All rights >>>> reserved.
>>>> + Copyright (c) 2011 - 2019, Intel Corporation. All rights >>>> + reserved.
>>>> SPDX-License-Identifier: BSD-2-Clause-Patent >>>> >>>> **/ >>>> @@ -40,7 +40,7 @@ EFI_RSC_HANDLER_PROTOCOL >>> *mRscHandlerProtocol >>>> = NULL; >>>> BOOLEAN mLockBoxReady = FALSE; >>>> EFI_EVENT mReadyToBootEvent; >>>> EFI_EVENT mLegacyBootEvent; >>>> -EFI_EVENT mExitBootServicesEvent; >>>> +static EFI_EVENT mExitBootServicesEvent; >>>> UINTN mFirmwarePerformanceTableTemplateKey = 0; >>>> BOOLEAN mDxeCoreReportStatusCodeEnable = FALSE; >>>> >>>> -- >>>> 2.21.0.windows.1 >>>> >>>> >>>> >