public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>
To: <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BaseTools: Fix typo in FDF parser for OptionROM override
Date: Mon, 29 Oct 2018 16:53:21 +0000	[thread overview]
Message-ID: <cca93a5e-d3da-3dbb-bea4-c6ee9d60b7a6@solarflare.com> (raw)
In-Reply-To: <18d8624d-b68c-c1f1-2ab3-3b10fc1b999c@solarflare.com>

Turns out this is a merge conflict. Respinning.

On 29/10/2018 16:40, Tomas Pilar (tpilar) wrote:
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> ---
>  BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source/Python/GenFds/FdfParser.py
> index 1c9a5130bf..71cce8f61e 100644
> --- a/BaseTools/Source/Python/GenFds/FdfParser.py
> +++ b/BaseTools/Source/Python/GenFds/FdfParser.py
> @@ -4396,7 +4396,7 @@ class FdfParser:
>                          raise Warning.ExpectedEquals(self.FileName, self.CurrentLineNumber)
>                      # Get a list of PCI IDs
>                      Overrides.PciDeviceId = ""
> -                    while (self.__GetNextHexNumber()):
> +                    while (self._GetNextHexNumber()):
>                          Overrides.PciDeviceId = "{} {}".format(Overrides.PciDeviceId, self.__Token)
>                      if not Overrides.PciDeviceId:
>                          raise Warning.Expected("one or more Hex device ids", self.FileName, self.CurrentLineNumber)



      reply	other threads:[~2018-10-29 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 16:40 [PATCH] BaseTools: Fix typo in FDF parser for OptionROM override Tomas Pilar (tpilar)
2018-10-29 16:53 ` Tomas Pilar (tpilar) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cca93a5e-d3da-3dbb-bea4-c6ee9d60b7a6@solarflare.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox