From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 306AD2118C519 for ; Wed, 28 Nov 2018 12:03:13 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AECBB30C1CA0; Wed, 28 Nov 2018 20:03:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-170.rdu2.redhat.com [10.10.120.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0BB45D787; Wed, 28 Nov 2018 20:03:08 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Liming Gao , edk2-devel@lists.01.org References: <20181128140318.19436-1-liming.gao@intel.com> <74ecbe76-0ceb-51da-d00f-4bcf711191c0@redhat.com> From: Laszlo Ersek Message-ID: Date: Wed, 28 Nov 2018 21:03:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <74ecbe76-0ceb-51da-d00f-4bcf711191c0@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 28 Nov 2018 20:03:12 +0000 (UTC) Subject: Re: [Patch v2] Maintainers.txt: Add the rule to hand over the package maintain role X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 20:03:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/28/18 16:13, Philippe Mathieu-Daudé wrote: > Hi, > > On 28/11/18 15:03, Liming Gao wrote: >> In V2, change his to the, and add new maintainers follow up. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Liming Gao >> --- >> Maintainers.txt | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 91a4657adc..e102114c34 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -6,7 +6,10 @@ EDK II. >> >> In general, you should not privately email the maintainer. You should >> email the edk2-devel list, and Cc the package maintainers and >> -reviewers. >> +reviewers. If the package maintainer wants to hand over the role to > > I'd move this to another paragraph, the first one is directed to > contributors, the second one would be to maintainers. > >> +other people, the package maintainer should send the patch to update >> +Maintainers.txt with new maintainer, and the new maintainer should >> +follow up with an Acked-by or a Reviewed-by. > > I noticed an extra space at the end of the lines you added, which > resulted in the following errors when applying: > > Applying: Maintainers.txt: Add the rule to hand over the package > maintain role > .git/rebase-apply/patch:14: trailing whitespace. > reviewers. If the package maintainer wants to hand over the role to > .git/rebase-apply/patch:15: trailing whitespace. > other people, the package maintainer should send the patch to update > .git/rebase-apply/patch:16: trailing whitespace. > Maintainers.txt with new maintainer, and the new maintainer should > error: patch failed: Maintainers.txt:6 > error: Maintainers.txt: patch does not apply > > > Thanks for adding the maintainership handover clarification, I appreciate :) > > With space fixed (same or another paragraphs): > Reviewed-by: Philippe Mathieu-Daudé Good observations! My R-b stands, but if Liming decides to fix up the two warts that you point out (just before pushing), that is, breaking the new sentence to a new paragraph, and removing trailing whitespace, my R-b stands in that case too. Thanks! Laszlo