public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Abner Chang <abner.chang@amd.com>,
	Daniel Schaefer <git@danielschaefer.me>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5
Date: Tue, 6 Sep 2022 23:27:09 -0400	[thread overview]
Message-ID: <cce400b7-8038-44bb-fd47-4381e94ccc03@linux.microsoft.com> (raw)
In-Reply-To: <1712738C00A60617.17907@groups.io>

I forgot to add .azurepipelines maintainers to this patch. To avoid 
resending the whole series to the list +Cc here and v2 will include the 
maintainers directly on this patch.

Thanks,
Michael

On 9/6/2022 10:36 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046
> 
> This package currently does not build on non-GCC toolchains.
> 
> This change adds the package to edk2 CI so it can benefit from
> ongoing CI and only tests the package against GCC.
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 0e4ad019bf03..54a74a1a9873 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -21,6 +21,10 @@ jobs:
>     #Use matrix to speed up the build process
>     strategy:
>       matrix:
> +      ${{ if eq(parameters.tool_chain_tag, 'GCC5') }}:
> +        TARGET_GCC_ONLY:
> +          Build.Pkgs: 'EmbeddedPkg'
> +          Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_ARM_ARMPLATFORM:
>           Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'

  parent reply	other threads:[~2022-09-07  3:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  2:36 [PATCH v1 0/3] EmbeddedPkg: Enable CI Michael Kubacki
2022-09-07  2:36 ` [PATCH v1 1/3] EmbeddedPkg/AcpiLib: Fix code formatting errors Michael Kubacki
2022-09-07  2:36 ` [PATCH v1 2/3] EmbeddedPkg: Add CI YAML file Michael Kubacki
2022-09-07  2:36 ` [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5 Michael Kubacki
     [not found] ` <1712738C00A60617.17907@groups.io>
2022-09-07  3:27   ` Michael Kubacki [this message]
2022-09-09  1:37     ` [edk2-devel] " Michael D Kinney
2022-09-07  7:37 ` [PATCH v1 0/3] EmbeddedPkg: Enable CI Ard Biesheuvel
2022-09-07 15:00   ` [edk2-devel] " Michael Kubacki
2022-09-07 15:16     ` Ard Biesheuvel
2022-09-15 19:46       ` Michael Kubacki
2022-09-15 20:47         ` Ard Biesheuvel
2022-09-15 20:51           ` Michael D Kinney
2022-09-15 21:02             ` Ard Biesheuvel
2022-09-15 21:54               ` Michael D Kinney
2022-09-23  1:09                 ` Michael Kubacki
2022-09-23 11:47                   ` Ard Biesheuvel
2022-09-23 15:30                     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cce400b7-8038-44bb-fd47-4381e94ccc03@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox