From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.3670.1662521232249256493
 for <devel@edk2.groups.io>;
 Tue, 06 Sep 2022 20:27:12 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=gwuLgc57;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.195.228.134])
	by linux.microsoft.com (Postfix) with ESMTPSA id 98583204A584;
	Tue,  6 Sep 2022 20:27:10 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 98583204A584
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1662521231;
	bh=2qalPffqtu8a/kl0+QR9f4nil2GSKCWhzrCNOKIWXTk=;
	h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From;
	b=gwuLgc57FspswEO7C/pgpsXSWRo3+DGMB6Pg+fQph+W6tT/WxqKsvVN7nQpFIeKZx
	 IISG5PmdCqT4FQVMotPO6balM5wzLZd1Wjyt7ERc4FUhigP4LYNUXA0PpYPf9n4e+M
	 UixmV69bR6mfQ2EkNvGCsv/o6bvClHYTRSY9XNn4=
Message-ID: <cce400b7-8038-44bb-fd47-4381e94ccc03@linux.microsoft.com>
Date: Tue, 6 Sep 2022 23:27:09 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [edk2-devel] [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>, Abner Chang
 <abner.chang@amd.com>, Daniel Schaefer <git@danielschaefer.me>,
 Sean Brogan <sean.brogan@microsoft.com>,
 Bret Barkelew <Bret.Barkelew@microsoft.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>
Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com
References: <20220907023649.312-1-mikuback@linux.microsoft.com>
 <1712738C00A60617.17907@groups.io>
In-Reply-To: <1712738C00A60617.17907@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I forgot to add .azurepipelines maintainers to this patch. To avoid 
resending the whole series to the list +Cc here and v2 will include the 
maintainers directly on this patch.

Thanks,
Michael

On 9/6/2022 10:36 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046
> 
> This package currently does not build on non-GCC toolchains.
> 
> This change adds the package to edk2 CI so it can benefit from
> ongoing CI and only tests the package against GCC.
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 0e4ad019bf03..54a74a1a9873 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -21,6 +21,10 @@ jobs:
>     #Use matrix to speed up the build process
>     strategy:
>       matrix:
> +      ${{ if eq(parameters.tool_chain_tag, 'GCC5') }}:
> +        TARGET_GCC_ONLY:
> +          Build.Pkgs: 'EmbeddedPkg'
> +          Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_ARM_ARMPLATFORM:
>           Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'