From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web09.9061.1655912477981224435
 for <devel@edk2.groups.io>;
 Wed, 22 Jun 2022 08:41:18 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF3DF12FC;
	Wed, 22 Jun 2022 08:41:17 -0700 (PDT)
Received: from [10.57.70.141] (unknown [10.57.70.141])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D517B3F792;
	Wed, 22 Jun 2022 08:41:16 -0700 (PDT)
Message-ID: <cd15874d-733d-88d2-b52b-7adfe61550c4@arm.com>
Date: Wed, 22 Jun 2022 16:41:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [edk2-devel] [PATCH] ArmPlatformPkg: Add PCD for serial debug port interrupt
To: Ard Biesheuvel <ardb@kernel.org>,
 edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Sami Mujawar <sami.mujawar@arm.com>
References: <20220622101210.21354-1-thomas.abraham@arm.com>
 <CAMj1kXHp-P-Gs-PNQhBOU7tdrOQYZYFHUmQwqR7OBBjzPXvS5w@mail.gmail.com>
From: "Thomas Abraham" <thomas.abraham@arm.com>
In-Reply-To: <CAMj1kXHp-P-Gs-PNQhBOU7tdrOQYZYFHUmQwqR7OBBjzPXvS5w@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 22/06/2022 15:52, Ard Biesheuvel wrote:
> On Wed, 22 Jun 2022 at 12:12, Thomas Abraham <thomas.abraham@arm.com> wrote:
>>
>> Add a PCD to specify the interrupt number of the serial debug port
>> controller.
>>
> 
> Why do we need this?

The commit message will be updated in next version of this patch the 
describes the need for this change.

> 
>> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
>> Change-Id: I4ce6d29cdf5e8b5fcbfe740269d966a53f2b852a
> 
> Please drop the change id

Apologies, I missed this, will fix in the next version.

Thanks Ard for your review.

> 
>> ---
>>   ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
>> index 3a25ddcdc8..dd6e78f62a 100644
>> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
>> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
>> @@ -94,6 +94,7 @@
>>     gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>>     gArmPlatformTokenSpaceGuid.PcdSerialDbgUartBaudRate|0x00000000|UINT64|0x00000031
>>     gArmPlatformTokenSpaceGuid.PcdSerialDbgUartClkInHz|0x00000000|UINT32|0x00000032
>> +  gArmPlatformTokenSpaceGuid.PcdSerialDbgInterrupt|0x00000000|UINT32|0x00000041
>>
>>     ## PL061 GPIO
>>     gArmPlatformTokenSpaceGuid.PcdPL061GpioBase|0x0|UINT32|0x00000025
>> --
>> 2.17.1
>>
>>
>>
>> 
>>
>>