From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6A106AC1705 for ; Mon, 11 Sep 2023 13:16:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1oh6ELf+3mAzkRTG5dJ8Lo8PV9IqrPzmeApI6pbCK0Q=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694438196; v=1; b=i5cYjgvCiKObuWbl9hPOO3X1Ms77+74f1Nq/EHOO1D1fogirq4WLFbFPcoj/wpodKK81FSBq jt2knRDFQC49m3qhSAQoGQUKH11WGYpFeRtq7JlYqV/hlmWpBRVTWDFYeG1+ZiOpIA36uZ0A/iS w97JGk1SPXzabTzOVD4cIRc4= X-Received: by 127.0.0.2 with SMTP id qc0yYY7687511xbNhmW7FcJa; Mon, 11 Sep 2023 06:16:36 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.58180.1694438195298380492 for ; Mon, 11 Sep 2023 06:16:35 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-wXJ2Pnv3Nf-O0Y3lCsO19g-1; Mon, 11 Sep 2023 09:16:31 -0400 X-MC-Unique: wXJ2Pnv3Nf-O0Y3lCsO19g-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D6C883810D35; Mon, 11 Sep 2023 13:16:30 +0000 (UTC) X-Received: from [10.39.195.23] (unknown [10.39.195.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 940AF10F1BE7; Mon, 11 Sep 2023 13:16:29 +0000 (UTC) Message-ID: Date: Mon, 11 Sep 2023 15:16:28 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt/README.md: bring your own OpenSBI To: Sunil V L Cc: edk2-devel-groups-io , Andrei Warkentin , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen References: <20230907145825.87830-1-lersek@redhat.com> <32d053f7-5740-6bdb-f34b-ea9a0262783c@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ASw08XGcm0N7O4GQf4dppygXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=i5cYjgvC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/11/23 12:15, Sunil V L wrote: > On Mon, Sep 11, 2023 at 09:07:46AM +0200, Laszlo Ersek wrote: >> On 9/11/23 08:22, Sunil V L wrote: >>> On Mon, Sep 11, 2023 at 08:15:26AM +0200, Laszlo Ersek wrote: >>>> On 9/11/23 07:32, Laszlo Ersek wrote: >>>>> On 9/8/23 08:13, Sunil V L wrote: >>>>>> Hi Laszlo, >>>>>> >>>>>> On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote: >>>>>>> Explain how users can compose their pre-OS environment purely from >>>>>>> binaries they've built themselves. >>>>>>> >>>>>>> Cc: Andrei Warkentin >>>>>>> Cc: Ard Biesheuvel >>>>>>> Cc: Gerd Hoffmann >>>>>>> Cc: Jiewen Yao >>>>>>> Cc: Jordan Justen >>>>>>> Cc: Sunil V L >>>>>>> Signed-off-by: Laszlo Ersek >>>>>>> --- >>>>>>> >>>>>>> Notes: >>>>>>> rendered version: >>>>>>> =20 >>>>>>> https://github.com/lersek/edk2/tree/bring-your-own-opensbi/Ovmf= Pkg/RiscVVirt#test-with-your-own-opensbi-binary >>>>>>> >>>>>>> OvmfPkg/RiscVVirt/README.md | 17 +++++++++++++++++ >>>>>>> 1 file changed, 17 insertions(+) >>>>>>> >>>>>>> diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README= .md >>>>>>> index 8c3ac37b802a..dbb40bbe89b0 100644 >>>>>>> --- a/OvmfPkg/RiscVVirt/README.md >>>>>>> +++ b/OvmfPkg/RiscVVirt/README.md >>>>>>> @@ -69,3 +69,20 @@ Below example shows how to boot openSUSE Tumblew= eed E20. >>>>>>> -device virtio-net-pci,netdev=3Dnet0 \ >>>>>>> -device virtio-blk-device,drive=3Dhd0 \ >>>>>>> -drive file=3DopenSUSE-Tumbleweed-RISC-V-E20-efi.riscv64.r= aw,format=3Draw,id=3Dhd0 >>>>>>> + >>>>>>> +## Test with your own OpenSBI binary >>>>>>> +Using the above QEMU command line, **RISCV_VIRT_CODE.fd** is launc= hed by the >>>>>>> +OpenSBI binary that is bundled with QEMU. You can build your own O= penSBI binary >>>>>>> +as well: >>>>>>> + >>>>>>> + OPENSBI_DIR=3D... >>>>>>> + git clone https://github.com/riscv/opensbi.git $OPENSBI_DIR >>>>>>> + make -C $OPENSBI_DIR \ >>>>>>> + -j $(getconf _NPROCESSORS_ONLN) \ >>>>>>> + CROSS_COMPILE=3Driscv64-linux-gnu- \ >>>>>>> + PLATFORM=3Dgeneric >>>>>>> + >>>>>> Do we need to duplicate these OpenSBI build instructions in EDK2? IM= O, >>>>>> we should just document how to use -bios to use custom OpenSBI image= . >>>>>> The build instructions for other software repos can change at any >>>>>> time. >>>>> >>>>> Can we include the opensbi project URL at least? >>>> >>>> BTW, I disagree with your larger message (as I perceive it). >>>> >>>> While it's true that build instructions may change at any time, that's >>>> just a generic statement about any software and any documentation in >>>> existence. All documentation goes stale at some point. >>>> >>> Agreed. But my point is, this documentation which provides build >>> instructions of opensbi doesn't belong to edk2 but opensbi. If somethin= g >>> is missing in the opensbi build instructions like you mentioned, it >>> should be submitted as a patch to opensbi repo rather edk2, right? >> >> I don't know. >> >> If two projects are used in conjunction, which project's documentation >> should cover the combined use? >> > Okay, fair enough. Let's add it. It appears to be very useful for any > one new to RISC-V+edk2 and OpenSBI. Do you want to update the -kernel > option also in v2 or will it be separate patch? I think I'd like -kernel etc to be an incremental (=3D separate) patch, because first I need to test it. Thanks! Laszlo >=20 > Thanks, > Sunil >> Laszlo >> >>> >>> -Sunil >>> >>>> And in this particular case, I needed to fish out the build commands, >>>> and the resultant "fw_dynamic.bin" filename, from the QEMU tree, not t= he >>>> OpenSBI tree. I'm not aware of any documentation that makes a dedicate= d >>>> statement about building OpenSBI *for* running edk2. >>>> >>>> The OpenSBI root "README.md" @ b20bd479eff1 only says "For example, to >>>> compile the platform library and the firmware examples for the QEMU >>>> RISC-V *virt* machine, ** should be *generic*". It do= es >>>> not mention the build output pathname >>>> "build/platform/generic/firmware/fw_dynamic.bin". >>>> >>>> Laszlo >>>> >>> >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108487): https://edk2.groups.io/g/devel/message/108487 Mute This Topic: https://groups.io/mt/101216052/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-