From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA6B821199558 for ; Mon, 17 Dec 2018 01:58:26 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48D7CC062EDC; Mon, 17 Dec 2018 09:58:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-46.rdu2.redhat.com [10.10.120.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2151D17D94; Mon, 17 Dec 2018 09:58:24 +0000 (UTC) To: Fu Siyuan , edk2-devel@lists.01.org References: <20181217013406.17864-1-siyuan.fu@intel.com> From: Laszlo Ersek Message-ID: Date: Mon, 17 Dec 2018 10:58:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181217013406.17864-1-siyuan.fu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 17 Dec 2018 09:58:26 +0000 (UTC) Subject: Re: [PATCH 1/1] ArmVirtPkg: Remove redundant library instances in ArmVirtQemuKernel.dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 09:58:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/17/18 02:34, Fu Siyuan wrote: > Commit 9a67ba261fe9 ("ArmVirtPkg: Replace obsoleted network drivers > from platform DSC/FDF") incorrectly added the BaseCryptLib, OpensslLib > and IntrinsicLib to "ArmVirtPkg/ArmVirtQemuKernel.dsc", it's redundant > and the library instances from "ArmVirt.dsc.inc" is already sufficient. > > This patch also adjust the order of network drivers in "ArmVirtPkg/ > ArmVirtQemuFvMain.fdf.inc" to make it same as the DSC file. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Fu Siyuan > --- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index 3316f982695f..dc6a0a2bcdc7 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -126,9 +126,9 @@ [FV.FvMain] > INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > + INF NetworkPkg/TcpDxe/TcpDxe.inf > INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > INF NetworkPkg/IScsiDxe/IScsiDxe.inf > - INF NetworkPkg/TcpDxe/TcpDxe.inf > !if $(NETWORK_IP6_ENABLE) == TRUE > INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 812c71e772ec..6c2d6488d499 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -67,9 +67,6 @@ [LibraryClasses.common] > > [LibraryClasses.common.UEFI_DRIVER] > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > - BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > - OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > - IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > > [BuildOptions.common.EDKII.SEC, BuildOptions.common.EDKII.BASE] > # > Reviewed-by: Laszlo Ersek Thank you for the quick update! Laszlo