From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.18058.1606478170389615526 for ; Fri, 27 Nov 2020 03:56:10 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8461A31B; Fri, 27 Nov 2020 03:56:09 -0800 (PST) Received: from [192.168.1.81] (unknown [10.37.8.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC4F23F71F; Fri, 27 Nov 2020 03:56:08 -0800 (PST) Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBoxMm: increase FV size To: Leif Lindholm Cc: devel@edk2.groups.io References: <20201126154046.6841-1-ard.biesheuvel@arm.com> <20201126162248.GX1664@vanye> <20201127115005.GY1664@vanye> From: "Ard Biesheuvel" Message-ID: Date: Fri, 27 Nov 2020 12:56:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201127115005.GY1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/27/20 12:50 PM, Leif Lindholm wrote: > On Thu, Nov 26, 2020 at 16:22:48 +0000, Leif Lindholm wrote: >> On Thu, Nov 26, 2020 at 16:40:46 +0100, Ard Biesheuvel wrote: >>> Due to recent changes in core EDK2, the DeveloperBoxMM standalone MM >>> build no longer fits when built in DEBUG or NOOPT mode. So increase >>> the FD size a little bit - we still have some spare room available in >>> the FIP image. >>> >>> Signed-off-by: Ard Biesheuvel >> >> Reviewed-by: Leif Lindholm >> >> I will push this with (after) the VariablePolicy set since the problem >> doesn't actually trigger until then. > > Urgh. This fixes DEBUG, but in my setup NOOPT is still too big. > Would it be OK if I folded in an increase from 0x50000 to 0x60000 > before pushing? > Yeah that's fine. > / > Leif > >> / >> Leif >> >>> --- >>> Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf >>> index 83a3c4660cb3..58efed89b26e 100644 >>> --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf >>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.fdf >>> @@ -21,12 +21,12 @@ >>> >>> [FD.STANDALONE_MM] >>> BaseAddress = 0xfc000000 >>> -Size = 0x00040000 >>> +Size = 0x00050000 >>> ErasePolarity = 1 >>> >>> # This one is tricky, it must be: BlockSize * NumBlocks = Size >>> BlockSize = 0x00010000 >>> -NumBlocks = 0x4 >>> +NumBlocks = 0x5 >>> >>> ################################################################################ >>> # >>> @@ -44,7 +44,7 @@ [FD.STANDALONE_MM] >>> # >>> ################################################################################ >>> >>> -0x00000000|0x00040000 >>> +0x00000000|0x00050000 >>> FV = FvStandaloneMmCompact >>> >>> ################################################################################ >>> -- >>> 2.17.1 >>>