From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=marc.zyngier@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id EB86E22603AE1 for ; Mon, 12 Mar 2018 03:42:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD56D15AB; Mon, 12 Mar 2018 03:49:01 -0700 (PDT) Received: from [10.1.207.62] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4B2B3F25C; Mon, 12 Mar 2018 03:49:00 -0700 (PDT) To: Ard Biesheuvel , Guo Heyi Cc: "edk2-devel@lists.01.org" , Yi Li , Leif Lindholm References: <1520837611-94728-1-git-send-email-heyi.guo@linaro.org> <1520837611-94728-2-git-send-email-heyi.guo@linaro.org> <54c4aab8-cc61-b4cc-6ab0-325dd42cca35@arm.com> <20180312102643.GC60232@SZX1000114654> <20180312103808.GD60232@SZX1000114654> From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Mon, 12 Mar 2018 10:48:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 10:42:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit On 12/03/18 10:38, Ard Biesheuvel wrote: > On 12 March 2018 at 10:38, Guo Heyi wrote: >> Hi Marc, >> >> I just tested with an ISB and it also worked for our platform. >> >> So is it acceptable to add an ISB after reloading timer compare value? >> > > I am fine with that if Marc is. An ISB makes a lot more sense to me. You can put my ack on a modified version of that patch. Thanks, M. -- Jazz is not dead. It just smells funny...