From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D262E78003C for ; Wed, 15 Nov 2023 08:52:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nNEkceCJpuhRz8wF74eb5SNwlnuL9Ecqt35D95uqivM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700038366; v=1; b=cJMQ1tHcWX/WCfbplWtPmSEkgBTuYgWkY3h1Pwpp5mgC8A0HH9Knmv1AujRpdOOXesXIukcs ffO/NzOGLkXZBsJ9Yb093qet0AqGZw27z2dmGYnoF2CIa/d13OcDBuD4KmKi1bQ3B35keTQ5gX3 rJd+tnySxk0DBY419qRWxm/I= X-Received: by 127.0.0.2 with SMTP id uIIiYY7687511x4TcKEU0XqE; Wed, 15 Nov 2023 00:52:46 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.9159.1700038365733217020 for ; Wed, 15 Nov 2023 00:52:45 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-FeCNly-gMimYFN22AYI3NA-1; Wed, 15 Nov 2023 03:52:40 -0500 X-MC-Unique: FeCNly-gMimYFN22AYI3NA-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 598C3821BC2; Wed, 15 Nov 2023 08:52:40 +0000 (UTC) X-Received: from [10.39.192.211] (unknown [10.39.192.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0569AC1596F; Wed, 15 Nov 2023 08:52:38 +0000 (UTC) Message-ID: Date: Wed, 15 Nov 2023 09:52:37 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: Rebecca Cran , devel@edk2.groups.io, Pedro Falcato Cc: Michael Kubacki , Michael Kinney , Andrew Fish , Marcin Juszkiewicz , "Leif Lindholm (Quic)" References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> <45488f96-0251-4cb4-9816-11733aeeb501@os.amperecomputing.com> From: "Laszlo Ersek" In-Reply-To: <45488f96-0251-4cb4-9816-11733aeeb501@os.amperecomputing.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cvrVHvdicn6E8TXO0l2PRwWHx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cJMQ1tHc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/14/23 16:12, Rebecca Cran wrote: > On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote: > >> Funnily enough, my stance is quite the opposite. I happen to disagree >> with some patterns that uncrustify enforces, but I'm thankful that at >> any given state of CI (= using any given version of uncrustify), we >> can't have any more debates about patch formatting (that is, it's >> especially its central nature that I like). I've found uncrustify >> relatively easy to use locally, too. > > There's _one_ place we can still have a debate, but I'm hoping we can > easily agree, and update CI to enforce it. > > I'd like to scrub the tree of all the NT-style function documentation > blocks and replace them with Doxygen style. > > As an example of the NT style, see OvmfPkg/QemuVideoDxe/Gop.c: > > EFI_STATUS > EFIAPI > QemuVideoGraphicsOutputQueryMode ( >   IN  EFI_GRAPHICS_OUTPUT_PROTOCOL          *This, >   IN  UINT32                                ModeNumber, >   OUT UINTN                                 *SizeOfInfo, >   OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION  **Info >   ) > > /*++ > > Routine Description: > >   Graphics Output protocol interface to query video mode > >   Arguments: >     This                  - Protocol instance pointer. >     ModeNumber            - The mode number to return information on. >     Info                  - Caller allocated buffer that returns > information about ModeNumber. >     SizeOfInfo            - A pointer to the size, in bytes, of the Info > buffer. > >   Returns: >     EFI_SUCCESS           - Mode information returned. >     EFI_BUFFER_TOO_SMALL  - The Info buffer was too small. >     EFI_DEVICE_ERROR      - A hardware error occurred trying to retrieve > the video mode. >     EFI_NOT_STARTED       - Video display is not initialized. Call > SetMode () >     EFI_INVALID_PARAMETER - One of the input args was NULL. > > --*/ > { >   QEMU_VIDEO_PRIVATE_DATA  *Private; >   QEMU_VIDEO_MODE_DATA     *ModeData; > ... > I strongly support that motion; the cited comment style is an eyesore. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111243): https://edk2.groups.io/g/devel/message/111243 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-