From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.6682.1628003367718023976 for ; Tue, 03 Aug 2021 08:09:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=JUEWZ4ei; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 23C3320B36E0; Tue, 3 Aug 2021 08:09:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 23C3320B36E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1628003367; bh=3Bk+pbs1WoD0aT89UrPVz2N5bU+YALNsvBOD1suu+7U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=JUEWZ4eiiqJsaJTqTHWk5OATz+3QXzyziBZWJwGjxhXKLQuXpBYcfs/9IKLb4bcWT 6cgJ/v0dsngp0JXzx999yeSlKCOothDJ71G6p0VEjc+jLKTnLduTF5hSXCSpFPz4xh p7eY6/B0YoIuY35WYSNVmc+kytSODxl8wm5sSHRM= Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 21/46] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: "Desimone, Nathaniel L" , Jeremy Soller References: <20210803023914.1569-1-mikuback@linux.microsoft.com> <20210803023914.1569-22-mikuback@linux.microsoft.com> From: "Michael Kubacki" Message-ID: Date: Tue, 3 Aug 2021 11:09:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Yes, patches were missing because the mailing list chose to unsort and retain non-consecutive patches (they were sent in order) after they exceeded the autoresponder mail loop guard of 40 messages. The following were missing: 0, 10, 11, 15, 23, 32, 43 I sent the missing patches a few minutes ago. Thanks, Michael On 8/3/2021 3:38 AM, Chiu, Chasel wrote: > > Please see my comments below inline. > > Thanks, > Chasel > > >> -----Original Message----- >> From: mikuback@linux.microsoft.com >> Sent: Tuesday, August 3, 2021 10:39 AM >> To: devel@edk2.groups.io >> Cc: Chiu, Chasel ; Desimone, Nathaniel L >> ; Jeremy Soller >> Subject: [edk2-platforms][PATCH v5 21/46] KabylakeOpenBoardPkg: Update >> SpiFvbService & SpiFlashCommonLib >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 >> >> Updates KabylakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in >> IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. >> >> Cc: Chasel Chiu >> Cc: Nate DeSimone >> Cc: Jeremy Soller >> Signed-off-by: Michael Kubacki >> Reviewed-by: Nate DeSimone >> Reviewed-by: Chasel Chiu >> --- >> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 7 >> +++++-- >> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | 2 +- >> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 7 >> +++++-- >> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 2 +- >> 4 files changed, 12 insertions(+), 6 deletions(-) >> >> diff --git >> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> index 302cb679b5eb..89be744a9038 100644 >> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> @@ -228,7 +228,7 @@ [LibraryClasses.X64.DXE_SMM_DRIVER] >> ####################################### >> # Silicon Initialization Package >> ####################################### >> - >> SpiFlashCommonLib|$(PLATFORM_SI_PACKAGE)/Pch/Library/SmmSpiFlashCom >> monLib/SmmSpiFlashCommonLib.inf >> + >> + >> SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF >> + lashCommonLib.inf >> >> ####################################### >> # Platform Package >> @@ -377,6 +377,10 @@ [Components.X64] >> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf >> $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf >> >> +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE >> + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> +!endif >> + > > > I encountered build failure because this file not found, did I miss any prerequisite patch? > > > >> ####################################### >> # Platform Package >> ####################################### >> @@ -393,7 +397,6 @@ [Components.X64] >> >> !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE >> >> - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >> >> $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf { diff --git >> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf >> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf >> index 39432d21b8b5..239b6b720a6a 100644 >> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf >> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf >> @@ -401,7 +401,7 @@ [FV.FvOsBootUncompact] !if >> gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE INF >> $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf >> INF >> $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >> -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> >> INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf >> INF $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf >> diff --git >> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> index 8523ab3f4fc1..f29393579c06 100644 >> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> @@ -268,7 +268,7 @@ [LibraryClasses.X64.DXE_SMM_DRIVER] >> ####################################### >> # Silicon Initialization Package >> ####################################### >> - >> SpiFlashCommonLib|$(PLATFORM_SI_PACKAGE)/Pch/Library/SmmSpiFlashCom >> monLib/SmmSpiFlashCommonLib.inf >> + >> + >> SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF >> + lashCommonLib.inf >> >> ####################################### >> # Platform Package >> @@ -456,6 +456,10 @@ [Components.X64] >> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf >> $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf >> >> +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE >> + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> +!endif >> + >> ####################################### >> # Platform Package >> ####################################### >> @@ -472,7 +476,6 @@ [Components.X64] >> >> !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE >> >> - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >> >> $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf { diff --git >> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf >> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf >> index f003dda0ddfc..23f9be5cf2a2 100644 >> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf >> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf >> @@ -408,7 +408,7 @@ [FV.FvOsBootUncompact] !if >> gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE INF >> $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf >> INF >> $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >> -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >> >> INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf >> INF $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf >> -- >> 2.28.0.windows.1 > > > > >