public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sssky307@163.com" <sssky307@163.com>,
	"'announce@edk2.groups.io'" <announce@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"afish@apple.com" <afish@apple.com>
Subject: Re: [edk2-devel] EDK II Stable Tag release edk2-stable201905 completed
Date: Tue, 11 Jun 2019 12:08:34 +0200	[thread overview]
Message-ID: <cdb95f70-d8b9-2858-d984-99266894c6f1@redhat.com> (raw)
In-Reply-To: <20190610140014.botd5fxrrrrus4a5@bivouac.eciton.net>

On 06/10/19 16:00, Leif Lindholm wrote:
> On Mon, Jun 10, 2019 at 01:50:43PM +0000, Gao, Liming wrote:
>> edk2 submodule are from github openssl and berkeley-softfloat-3. If you can access edk2, you can also access them. Why you system redirect github openssl to boringssl?
>>
>> * [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl/blob/50eaac9f3337667259de725451f201e784599687/LICENSE)
>> * [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3/blob/b64af41c3276f97f0e181920400ee056b9c88037/COPYING.txt)
> 
> Argh, no. OpenSSL has boringssl as a git submodule.
> 
> edk2/CryptoPkg/Library/OpensslLib/openssl$ cat .gitmodules
> [submodule "boringssl"]
>         path = boringssl
>         url = https://boringssl.googlesource.com/boringssl
> ...
> 

That's right, but it shouldn't matter. In edk2, I always use

$ git submodule update --init --force

and I never pass the "--recursive" flag. This is also how I tested the
upgrade to OpenSSL-1.1.1b, before edk2-stable201905 was tagged. The
boringssl sub-sub-module is not needed for edk2's purposes.

We might want to drop "--recursive" from "OpenSSL-HOWTO.txt", instead.

Thanks
Laszlo

  parent reply	other threads:[~2019-06-11 10:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  9:54 EDK II Stable Tag release edk2-stable201905 completed Liming Gao
2019-06-10  9:06 ` [edk2-devel] " krishnaLee
2019-06-10 13:50   ` Liming Gao
2019-06-10 14:00     ` Leif Lindholm
2019-06-10 14:16       ` Liming Gao
2019-06-12  5:24         ` krishnaLee
2019-06-11 10:08       ` Laszlo Ersek [this message]
2019-06-11 10:30         ` Leif Lindholm
2019-06-11 15:46           ` Laszlo Ersek
2019-06-11 16:08             ` Leif Lindholm
2019-06-12  8:18               ` Laszlo Ersek
2019-06-12  9:21                 ` Leif Lindholm
2019-06-12  9:37                   ` Laszlo Ersek
2019-06-12 13:30                     ` Liming Gao
2019-06-12 17:00                       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdb95f70-d8b9-2858-d984-99266894c6f1@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox