Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg

["Daniel Schaefer" <daniel.schaefer@hpe.com>]

On 12/2/20 12:59 AM, Heinrich Schuchardt wrote:
> On 12/1/20 5:17 PM, Daniel Schaefer wrote:
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>>
>> With this patch series we can build the UEFI SCT for RISCV64. It was confirmed
>> to be working on the U-Boot UEFI implementation by Heinrich.
>> It hasn't been tested on EDK2 yet.
>>
>> Build requirements are the same as for the EDK2 RISCV64 port and detailed here:
>> https://github.com/riscv/riscv-uefi-edk2-docs
>>
>> The second patch is a big one because it adds architecture specific files by
>> copying them from the Aarch64 directory. Only a single file, an assembly file
>> needed modifications. I'm not sure why the other ones are in an architecture
>> specific directory. They're all C files and seem to be generic. We can probably
>> unify them.
> 
> Hello Daniel,
> 
> thanks a lot for your patches.
> 
> You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory.
> 
> Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV too?

I grepped the repo for strings related to arm64 and aarch64. I ported what I found.
Do you see anything that's not ported?

The only thing I see, is in Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c
where some code is not used for ARM because:

   // Note: This function uses the EDKII Glu library from EDKII compatibility pkg.

   // which is not ported to ARM yet. Hence for the time being just return success.


I'm not yet sure what library that's referring to, but most likely it's also
not implemented for RISC-V.

Thanks for testing!
Does the SCT result look like what you expect? Or are some tests failing that you expect to succeed?

- Daniel