From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.13451.1606842741353670577 for ; Tue, 01 Dec 2020 09:12:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=SXnPPTm+; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=060493cc9a=daniel.schaefer@hpe.com) Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B1Gtupu003467; Tue, 1 Dec 2020 17:12:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=q8Oq2klN9fDi5Xl074cSvQm4xbdvaHkltJQTiwqDZyc=; b=SXnPPTm+AWROyz775vxndAOAmxZ4yIa3VAedjXmpvAYoP2MyYDs4sVSEjcn+QiTwmK8I SPLqxy4dSa8TxxpmsgrOMxivcunfBDUiFXQ4PTALf06s9RADXQqO5fAwC0WX3BvBTN7x GAld6zTl+qsgysZEzMagn6S9ZSd7cyaZlzVUy3uCMkPl4yJSqap48wVV1DdDi6Bmtetq Vnpl1uxjWf2PoslAb4ojroGGf5cJi54pWtZLioAELaNtW6jG6iJquA8HcFtwSbjNGsh/ CkRbNWFR4rS3+USLp3AfHu9F4vWgKg9wUoxLKeCXiYbVf54qmvI2eKdx5LhJLloTFEyg qg== Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 355qfvskf7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Dec 2020 17:12:14 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id 0335593; Tue, 1 Dec 2020 17:12:12 +0000 (UTC) Received: from G4W9325.americas.hpqcorp.net (16.208.32.94) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Dec 2020 17:12:04 +0000 Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G4W9325.americas.hpqcorp.net (2002:10d0:205e::10d0:205e) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Dec 2020 17:12:04 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 1 Dec 2020 17:12:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQ2mrCx+ezgV746nRjSUed+ewEzokTbYChaZrKoKgr1uUgtGvz7Pa4HD/Haw7yy2CHqfvAFb6w0PWMCNSLhbQm6Zh7CxeuM0zvViLRg8p1NHOeNCMO8zdgwuDvHAQ/y/7iQH0s/i2iNnXwT+MaBkzKXNPh6mQQ672ziO4A1ksxu1bSBjNflJ4Crw/SowEP2TIV7399hz9qDFR7zpqwhG+rlQ1bjyL8vKFidSqvGcqEmmAanvAt4/U/VhBVnzv2AxuZrOR51fNqlVRctvfHhU2L2vFRvQeYFyH3/TtstaVMFvhDUrenTWrdYepUD1/in0DC04xIoX3rg+UHBuEF2Hxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAKn2Zer3ikRLZthbJFy6rcUQ4ekQTzOSBZfM9iiWAE=; b=nxGlF8yNH38hUTJKXSnjiFBJmdGdv0+SWG2IDU7k7jQi4AsPanRxSnKEHIeCxP9oqc/ed7Fn7Ee9U17ggmN7d/Wz0UHb+SStL79a5rEIRjAuHG19uNyCR7sUn8GD5qtzxmhJ+44Y3CYAmx2k0yzJrIYL40kC3Ozu4ROFOqgfJ+65docHBXfzQ3t0HJ4TEsB2/ErVzjW+JswxkO000ZIn8svEU5Ujulbp7Nq0HHLVdn2+0SWFixg3K8o0LoMz4mSR+L1m8P80hUuk+5JcdGW9nstNOb5nDrbpdEwim6QTec2innzYKlFWvSDtDVm59EQsRWJLqWdv1fur6ebpklFWPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB0346.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Tue, 1 Dec 2020 17:12:03 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::691c:7962:6e56:c91f]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::691c:7962:6e56:c91f%8]) with mapi id 15.20.3611.025; Tue, 1 Dec 2020 17:12:03 +0000 Subject: Re: [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg To: Heinrich Schuchardt , CC: Leif Lindholm , Abner Chang , Gilbert Chen , Eric Jin , "G Edhaya Chandran" , Barton Gao , "Samer El-Haj-Mahmoud" References: <20201201161752.23734-1-daniel.schaefer@hpe.com> From: "Daniel Schaefer" Message-ID: Date: Wed, 2 Dec 2020 01:11:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 In-Reply-To: X-Originating-IP: [123.193.51.23] X-ClientProxiedBy: HKAPR03CA0026.apcprd03.prod.outlook.com (2603:1096:203:c9::13) To DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.24] (123.193.51.23) by HKAPR03CA0026.apcprd03.prod.outlook.com (2603:1096:203:c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.6 via Frontend Transport; Tue, 1 Dec 2020 17:12:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0271cb52-525f-48d2-28a0-08d8961c38f7 X-MS-TrafficTypeDiagnostic: DF4PR8401MB0346: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ljYIfFN7ajg+2yKdkAFDC435U8+YWhsD7zcAxflBBesDmILHQNefzdDKYhjuqqrAWi3AQFsStzpIzsCeXJVacEPekvU1BvB5FjEYocQlWpZhrQTC8lx3g/sXknrAF0zkyqeUHZq2wsznZBCTKTcnVFNotXVH1yU13mSm8E8iuyUvFCTomsOFNwr9cGQWyTS102nBHT/H2CEy4o7dnNCec7OEuvqY55w587oDN2M6+e58regLldoWenKzV+I54QuFU9iSxFuVGD5q23QiNYcnmDIZaiMqJfZRJFPE+S5oW6m6xA1BSbgas8cv0sitkuwE5jvS3J1dFC1EYPrnIg1/lQIfzI4uo3IGmQX16JpwuPwtl6LPC+W9S3uHiXfuKnSaVEgjb9vhP0+RYVsD62NrZ17F3LGMv5VDVTJJFx1v5XLafVVtEGb3FVALiiJU7e8hyyacgR7N5+Vk7k1MBV1wP3iZhuI0p/v1U8kSsAwil1fUOgMgsH5yOEiIVhYokyst X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(366004)(376002)(136003)(396003)(39860400002)(66476007)(8676002)(8936002)(6486002)(36756003)(2906002)(66946007)(66556008)(31686004)(16526019)(6666004)(4326008)(52116002)(83380400001)(5660300002)(86362001)(54906003)(966005)(186003)(2616005)(31696002)(956004)(53546011)(26005)(478600001)(44832011)(316002)(16576012)(17423001)(156123004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?KzB4VTVHSnk1OTE2eGtkeDdEZ1RIMUp6bTV6c3VyRCswT3dnclJMdWtockl0?= =?utf-8?B?cUd1N1NxSjU1NHlzVXN2UStVd0NlTHlLdWZNUjZ5a2U2WHZBelRyb1BnS3NI?= =?utf-8?B?SnJHNHVmSnlYazBqcUNOVjgrdFFxZFZPOHQ4cWtQTmpvQkV2Y3VvUnZRaHl2?= =?utf-8?B?RWlHTEJRc3BqK1E0UWtub0k2emVieERIekMzTVM3eGlrNmtIVEt6V1NDaFVX?= =?utf-8?B?WmFUbzB4OEZyK1lEQWQ4N2FEM2ZUR1N6WDFGMldqYU5RY3JqWkZCMWVWYlhl?= =?utf-8?B?cTBRN2RKbWh0Z1M1dXJSd0t1UVkyNHdSTWVJVEFzV01GL25qWUtlVEwveHJU?= =?utf-8?B?bDJkUTRwM1dwcldxLzlKZVhnRWs0WDNRTkZNVFU3Q3B2bTRpTXQvWEgzRFNu?= =?utf-8?B?VnM2dncvZUJlSFVLSUc4TmIxN2FWdVJQRnlRKzZnWS9ENDNmaXRvSDBxQjkr?= =?utf-8?B?aVFOWk1yZFpUYXJJR0RtbTA4SGhaTDdxWlkrUGJNYUJ1N1ZrdGtONU5qVC8y?= =?utf-8?B?SFBnNUl2RnRlSlUrQUxuVTNKNVhTRDJ1Q1R6d0YvTFppTSszUERMN1pYa2dy?= =?utf-8?B?SFJqWExsNVBSVGZYQjQrYkkwdjd0ZHkwR3ZBKzFFeG91cmtsYzBlaGRQRGow?= =?utf-8?B?a2VTTWJkSnBicWVlYTdrWnBTa25FVEo5cEUrYmRaWk1FMVR3S2FuRnZMQjRN?= =?utf-8?B?Yy90TTZGcVhSZDVsTkFTdlJhM0F1anpEbDhCbmRrdjczK0p6MGFseVFqSlB0?= =?utf-8?B?NDVPUlgxM05LK2dJaDQxdFh2Ukd3UmgvT3E2eXNKbGltVlV5YUlWZVhBZUxL?= =?utf-8?B?V1B2TjkvM1A5V2xxSXVJUHY2aWxZYytPb1VnZkFCVzNnWEVMS1lURFpnd0JK?= =?utf-8?B?eXZ4bG5PVkYyS3lKNFNaK2hCWVl1Wk92bjR1aXJsWW9QaU1wY0w0Q1RWWXBy?= =?utf-8?B?QUx1L1p0enNHRHFiWnNsZ0h0YzI5Zzg2ZFFlNTFzcGpycnlVWVZQVCtIeDM5?= =?utf-8?B?UUF6N3RKTHpoZGQ2KzZnMXFVZjdXNUY0aU5WYnhrWlBCNi91M0Y3YVVSNVJK?= =?utf-8?B?am1yYmxNUkxBT24vbWg5ODU3VnFWcnhKbGl4cG53S01uT0k3Tno5bVc2TUpX?= =?utf-8?B?RHZMTHNvV1lvNzhmUVVCZXlTNkhZUyt4K2xDSGYwV2RURGNZeUFkZVRXVHBl?= =?utf-8?B?REtXV25velgwbDN4dHVYbWUycjJHdTRPOGcyMzg1QjJkTkVJRWNWd1ZOanBh?= =?utf-8?B?YlB1dkdoNk9oTWFTa2t3RXBScHJrNVlBN0Mrejh2OWFNckpUSnBaemU4eWUx?= =?utf-8?Q?dYlFcSLuxqEGb1TDjZ/RjVBcdDmN7e9n+n?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0271cb52-525f-48d2-28a0-08d8961c38f7 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2020 17:12:03.3557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5yUDfabGp4Up92LpfKdA0GHOMwTKTOOsjaqh7twZSZS3I4OXcDUIpct7LL98196mKpsdp9l9pUbURRyR1vSXyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0346 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 1 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-12-01_07:2020-11-30,2020-12-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012010104 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: > On 12/1/20 5:17 PM, Daniel Schaefer wrote: >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 >> >> With this patch series we can build the UEFI SCT for RISCV64. It was confirmed >> to be working on the U-Boot UEFI implementation by Heinrich. >> It hasn't been tested on EDK2 yet. >> >> Build requirements are the same as for the EDK2 RISCV64 port and detailed here: >> https://github.com/riscv/riscv-uefi-edk2-docs >> >> The second patch is a big one because it adds architecture specific files by >> copying them from the Aarch64 directory. Only a single file, an assembly file >> needed modifications. I'm not sure why the other ones are in an architecture >> specific directory. They're all C files and seem to be generic. We can probably >> unify them. > > Hello Daniel, > > thanks a lot for your patches. > > You address the uefi-sct/SctPkg/TestCase/UEFI/EFI directory. > > Are you planning future patches for uefi-sct/SctPkg/TestCase/UEFI/IHV too? I grepped the repo for strings related to arm64 and aarch64. I ported what I found. Do you see anything that's not ported? The only thing I see, is in Protocol/UsbIo/BlackBoxTest/UsbIoTestConformance.c where some code is not used for ARM because: // Note: This function uses the EDKII Glu library from EDKII compatibility pkg. // which is not ported to ARM yet. Hence for the time being just return success. I'm not yet sure what library that's referring to, but most likely it's also not implemented for RISC-V. Thanks for testing! Does the SCT result look like what you expect? Or are some tests failing that you expect to succeed? - Daniel