From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED13A21A16EFF for ; Thu, 18 May 2017 15:12:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 668AB72465; Thu, 18 May 2017 22:12:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 668AB72465 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 668AB72465 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-86.phx2.redhat.com [10.3.116.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96B3917D3D; Thu, 18 May 2017 22:12:33 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Jordan Justen References: <20170518151436.16566-1-lersek@redhat.com> <20170518151436.16566-2-lersek@redhat.com> Message-ID: Date: Fri, 19 May 2017 00:12:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170518151436.16566-2-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 18 May 2017 22:12:34 +0000 (UTC) Subject: Re: [PATCH v2 1/5] OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2017 22:12:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/18/17 17:14, Laszlo Ersek wrote: > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > Regression-tested-by: Gary Lin > --- > > Notes: > v2: > - no changes > - add Gary's R-t-b > > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h | 16 +++---- > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 44 ++++++++++---------- > 2 files changed, 30 insertions(+), 30 deletions(-) > > diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > index f34fad2cdd48..4247d21d72f8 100644 > --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > +++ b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h > @@ -1,18 +1,18 @@ > /*++ > > Copyright (c) 2006, Intel Corporation. All rights reserved.
> -This program and the accompanying materials > -are licensed and made available under the terms and conditions of the BSD License > -which accompanies this distribution. The full text of the license may be found at > -http://opensource.org/licenses/bsd-license.php > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +This program and the accompanying materials > +are licensed and made available under the terms and conditions of the BSD License > +which accompanies this distribution. The full text of the license may be found at > +http://opensource.org/licenses/bsd-license.php > + > +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > Module Name: > > FwBlockService.h > - > + > Abstract: > > Firmware volume block driver for Intel Firmware Hub (FWH) device > diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c > index 9f9babc9cc33..30f69b999ab0 100644 > --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c > +++ b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c > @@ -120,14 +120,14 @@ FvbVirtualAddressChangeEvent ( > only for memory-mapped firmware volumes. > > @param This Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance. > - > + > @param Address Pointer to a caller-allocated > EFI_PHYSICAL_ADDRESS that, on successful > return from GetPhysicalAddress(), contains the > base address of the firmware volume. > - > + > @retval EFI_SUCCESS The firmware volume base address is returned. > - > + > @retval EFI_NOT_SUPPORTED The firmware volume is not memory mapped. > > **/ > @@ -168,9 +168,9 @@ FvbProtocolGetPhysicalAddress ( > blocks in this range have a size of > BlockSize. > > - > + > @retval EFI_SUCCESS The firmware volume base address is returned. > - > + > @retval EFI_INVALID_PARAMETER The requested LBA is out of range. > > **/ > @@ -246,7 +246,7 @@ FvbProtocolGetAttributes ( > settings of the firmware volume. Type > EFI_FVB_ATTRIBUTES_2 is defined in > EFI_FIRMWARE_VOLUME_HEADER. > - > + > @retval EFI_SUCCESS The firmware volume attributes were returned. > > @retval EFI_INVALID_PARAMETER The attributes requested are in > @@ -302,7 +302,7 @@ FvbProtocolSetAttributes ( > > @retval EFI_SUCCESS The erase request was successfully > completed. > - > + > @retval EFI_ACCESS_DENIED The firmware volume is in the > WriteDisabled state. > @retval EFI_DEVICE_ERROR The block device is not functioning > @@ -311,7 +311,7 @@ FvbProtocolSetAttributes ( > partially erased. > @retval EFI_INVALID_PARAMETER One or more of the LBAs listed > in the variable argument list do > - not exist in the firmware volume. > + not exist in the firmware volume. > > **/ > EFI_STATUS > @@ -420,29 +420,29 @@ FvbProtocolEraseBlocks ( > returns. > > @param This Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance. > - > + > @param Lba The starting logical block index to write to. > - > + > @param Offset Offset into the block at which to begin writing. > - > + > @param NumBytes Pointer to a UINTN. At entry, *NumBytes > contains the total size of the buffer. At > exit, *NumBytes contains the total number of > bytes actually written. > - > + > @param Buffer Pointer to a caller-allocated buffer that > contains the source for the write. > - > + > @retval EFI_SUCCESS The firmware volume was written successfully. > - > + > @retval EFI_BAD_BUFFER_SIZE The write was attempted across an > LBA boundary. On output, NumBytes > contains the total number of bytes > actually written. > - > + > @retval EFI_ACCESS_DENIED The firmware volume is in the > WriteDisabled state. > - > + > @retval EFI_DEVICE_ERROR The block device is malfunctioning > and could not be written. > > @@ -503,7 +503,7 @@ FvbProtocolWrite ( > aware that a read may be partially completed. > > @param This Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance. > - > + > @param Lba The starting logical block index > from which to read. > > @@ -519,15 +519,15 @@ FvbProtocolWrite ( > > @retval EFI_SUCCESS The firmware volume was read successfully > and contents are in Buffer. > - > + > @retval EFI_BAD_BUFFER_SIZE Read attempted across an LBA > boundary. On output, NumBytes > contains the total number of bytes > returned in Buffer. > - > + > @retval EFI_ACCESS_DENIED The firmware volume is in the > ReadDisabled state. > - > + > @retval EFI_DEVICE_ERROR The block device is not > functioning correctly and could > not be read. > @@ -715,9 +715,9 @@ InitializeFvAndVariableStoreHeaders ( > /** > Main entry point. > > - @param[in] ImageHandle The firmware allocated handle for the EFI image. > + @param[in] ImageHandle The firmware allocated handle for the EFI image. > @param[in] SystemTable A pointer to the EFI System Table. > - > + > @retval EFI_SUCCESS Successfully initialized. > > **/ > Commit 89f385ce0ad7.