From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6879.1589293723638562291 for ; Tue, 12 May 2020 07:28:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 62B6930E; Tue, 12 May 2020 07:28:42 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C78E33F71E; Tue, 12 May 2020 07:28:40 -0700 (PDT) Subject: Re: [PATCH edk2-platforms v2 0/7] Add Broadcom GENET driver for RPi4 To: devel@edk2.groups.io Cc: leif@nuviainc.com, philmd@redhat.com, Pete Batard , Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Jeremy Linton References: <20200512075512.12645-1-ard.biesheuvel@arm.com> From: "Ard Biesheuvel" Message-ID: Date: Tue, 12 May 2020 16:28:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200512075512.12645-1-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/12/20 9:55 AM, Ard Biesheuvel wrote: > This is a followup to Samer's v1 [0], and incorporates all the delta > changes posted for review over the past couple of days. This is a > roundup of all that work, and therefore supersedes it. > > It provides an implementation of the SimpleNetworkProtocol for the > Raspberry Pi4's GENET network controller, in a way that adheres to the > UEFI driver model. > > The original submission was provided by Jared, based on Jeremy's MAC > programming-only driver and the existing BSD driver for the GENET IP. > Cumulative changes and fixes as well as review feedback were provided > by all of the below. > > https://github.com/ardbiesheuvel/edk2-platforms/tree/rpi4_genet_combi_v2 > FYI in an off list discussion, Leif pointed out the the practice of having one 'master' .h file including everything, which is included by the .c files is not acceptable practice, even though it is widespread in EDK2. I pushed a delta patch to the branch above that fixes this, but I will wait for other feedback before sending it out, or sending out a v3, whichever is more appropriate.