public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Rebecca Cran <rebecca@bluestop.org>, edk2-devel@lists.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>,
	Daryl McDaniel <edk2-lists@mc2research.org>
Subject: Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.
Date: Mon, 25 Feb 2019 11:11:16 +0100	[thread overview]
Message-ID: <cdf5872e-05d8-b7c9-325d-6b823c081022@redhat.com> (raw)
In-Reply-To: <4bd92577-2a3a-6af8-9e3d-85dbca5f10b6@bluestop.org>

On 02/23/19 04:41, Rebecca Cran via edk2-devel wrote:
> Sorry, I've fixed the subject line and added maintainers to the Cc list.
> 
> This patch also changes the domain from intel.com to example.com, to be
> more applicable to consumers outside Intel.
> 
> 
> -- 
> 
> Rebecca Cran
> 
> 
> On 2/22/19 8:38 PM, Rebecca Cran wrote:
>> The current servers listed appear to be unusable. I suspect most
>> people will get correct DNS servers via DHCP, but the defaults
>> should work for anyone.
>> ---
>>   StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf
>> b/StdLib/Efi/StdLib/etc/resolv.conf
>> index 3ac16ac230..724e6297b2 100644
>> --- a/StdLib/Efi/StdLib/etc/resolv.conf
>> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
>> @@ -1,13 +1,13 @@
>>   #
>>   #   Domain name
>>   #
>> -domain          intel.com
>> +domain          example.com
>>     ;
>>   ;   Name Servers
>>   ;
>> -nameserver      206.63.63.61
>> -nameserver      216.251.100.1
>> +nameserver      8.8.8.8
>> +nameserver      8.8.4.4
>>     ; nameserver      10.248.2.1
>>   ; nameserver      10.22.224.204
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Can you please repost the patch with an updated subject line / commit
message? That way we can apply it with git-am without tweaking on the
maintainer side.

In v2, you can include:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(If reposting is too much burden, I can do the changes manually once the
ShellPkg maintainers okay the patch; it's just that the less a
maintainer has to update a patch, the safer / more robust the process is.)

Thanks
Laszlo


  reply	other threads:[~2019-02-25 10:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23  3:38 [PATCH] Update resolv.conf to use Google's DNS servers Rebecca Cran
2019-02-23  3:41 ` [PATCH] StdLib: " Rebecca Cran
2019-02-25 10:11   ` Laszlo Ersek [this message]
2019-02-25 14:40     ` Rebecca Cran
2019-02-25 15:56     ` Carsey, Jaben
  -- strict thread matches above, loose matches on Subject: below --
2019-03-08  2:14 Rebecca Cran
2019-03-08  9:26 ` Laszlo Ersek
2019-03-08 20:17 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdf5872e-05d8-b7c9-325d-6b823c081022@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox