From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B463208AE99C for ; Mon, 25 Feb 2019 02:11:19 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98A7A306161F; Mon, 25 Feb 2019 10:11:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-217.rdu2.redhat.com [10.10.120.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91F0060BE7; Mon, 25 Feb 2019 10:11:17 +0000 (UTC) To: Rebecca Cran , edk2-devel@lists.01.org Cc: Jaben Carsey , Daryl McDaniel References: <20190223033802.74083-1-rebecca@bluestop.org> <4bd92577-2a3a-6af8-9e3d-85dbca5f10b6@bluestop.org> From: Laszlo Ersek Message-ID: Date: Mon, 25 Feb 2019 11:11:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4bd92577-2a3a-6af8-9e3d-85dbca5f10b6@bluestop.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 25 Feb 2019 10:11:18 +0000 (UTC) Subject: Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 10:11:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02/23/19 04:41, Rebecca Cran via edk2-devel wrote: > Sorry, I've fixed the subject line and added maintainers to the Cc list. > > This patch also changes the domain from intel.com to example.com, to be > more applicable to consumers outside Intel. > > > -- > > Rebecca Cran > > > On 2/22/19 8:38 PM, Rebecca Cran wrote: >> The current servers listed appear to be unusable. I suspect most >> people will get correct DNS servers via DHCP, but the defaults >> should work for anyone. >> --- >>   StdLib/Efi/StdLib/etc/resolv.conf | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf >> b/StdLib/Efi/StdLib/etc/resolv.conf >> index 3ac16ac230..724e6297b2 100644 >> --- a/StdLib/Efi/StdLib/etc/resolv.conf >> +++ b/StdLib/Efi/StdLib/etc/resolv.conf >> @@ -1,13 +1,13 @@ >>   # >>   #   Domain name >>   # >> -domain          intel.com >> +domain          example.com >>     ; >>   ;   Name Servers >>   ; >> -nameserver      206.63.63.61 >> -nameserver      216.251.100.1 >> +nameserver      8.8.8.8 >> +nameserver      8.8.4.4 >>     ; nameserver      10.248.2.1 >>   ; nameserver      10.22.224.204 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel Can you please repost the patch with an updated subject line / commit message? That way we can apply it with git-am without tweaking on the maintainer side. In v2, you can include: Reviewed-by: Laszlo Ersek (If reposting is too much burden, I can do the changes manually once the ShellPkg maintainers okay the patch; it's just that the less a maintainer has to update a patch, the safer / more robust the process is.) Thanks Laszlo