From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.64]) by mx.groups.io with SMTP id smtpd.web12.4218.1642585077106412084 for ; Wed, 19 Jan 2022 01:37:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=4PqViURR; spf=pass (domain: arm.com, ip: 40.107.22.64, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OkG/5D2Cy2E0vsGMpXK0rtK5DI3M5Q7OLFMKR7A0Ro=; b=4PqViURRpoBX/hGJJA3iFsRd9kpUN6SeCjWH6/Qtwf1He4sJpn5c2SblUff36Jyk+VSGksowxfoBECJm9DgahPx0GhxsrfQ+oTqrsrRaPlYr5URHxaaexQ5NUgkpemc0ugskDOtSIf5BLODlBX59x+2jib5geprldadm0nQBl/Q= Received: from AM5PR0601CA0078.eurprd06.prod.outlook.com (2603:10a6:206::43) by AM0PR08MB4097.eurprd08.prod.outlook.com (2603:10a6:208:132::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Wed, 19 Jan 2022 09:37:52 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::5b) by AM5PR0601CA0078.outlook.office365.com (2603:10a6:206::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8 via Frontend Transport; Wed, 19 Jan 2022 09:37:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9 via Frontend Transport; Wed, 19 Jan 2022 09:37:52 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Wed, 19 Jan 2022 09:37:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fe5e05e68f6139bd X-CR-MTA-TID: 64aa7808 Received: from 9013034b031d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A798B89B-DCD7-4E82-A2ED-F2132F99741B.1; Wed, 19 Jan 2022 09:37:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9013034b031d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Jan 2022 09:37:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YJEroFfut5KlHhDwdVkqli2yUWIu4mhV+/9gdSvw06lYCrDAH9euB0r10MdNoTl1Y4wI5Yg4DWMQGBvEF1ep6mGetjLw+S0a73djiGlXfrBYJ/wtxJY8mCOvMGaqUPdQs0CVIfvDDapFHiSletBmTdxj23miqPOq/y7mXus6OjOHNe6dk+ojvYORc466w+WUg6zl7KFy9H6vKbSX59vD19MDHQNSNc3kpMJ1WoFfAosI/AFdDKnsywqzeo5TZGXH+U4O65ICZzC3BJH7fa4QvLAk6DsELWocYW20fxq08B82gXy8haagg8f5L0aSGkVbJ06pkDoKwe8kMnacxeBr+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4OkG/5D2Cy2E0vsGMpXK0rtK5DI3M5Q7OLFMKR7A0Ro=; b=Am1jyA3VgzZ7Jaaj0pp90HVATdoaQ83y0DDtSC0jsJhWpg1AgxUGqAeYfq2WBSTBfIrPKFO0HHV6cKCPpTH59P0t/ZTERZHQWZWkasrBbitTlEHKjNsofTGEgDV6p7e25WkbZjxwQ+zrIEN4Hcd5CW8jcQ1LvbWFF1nzpbU3lQIUzmtlDhsTWqGhANwgXueZFOTyuAq2yiqVquZJBkuwT7hvP2zWMVq57PVTWZ5HD5EOvN6MwziWI9QYmapXdFRD7cLeakk5EMkTLeL1zz59MEDhobG68FJt2lmBUydObAymzRhTyS2meNFiembN6McEDEgWpvy4OPRkBdiGKZ1hFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OkG/5D2Cy2E0vsGMpXK0rtK5DI3M5Q7OLFMKR7A0Ro=; b=4PqViURRpoBX/hGJJA3iFsRd9kpUN6SeCjWH6/Qtwf1He4sJpn5c2SblUff36Jyk+VSGksowxfoBECJm9DgahPx0GhxsrfQ+oTqrsrRaPlYr5URHxaaexQ5NUgkpemc0ugskDOtSIf5BLODlBX59x+2jib5geprldadm0nQBl/Q= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB5206.eurprd08.prod.outlook.com (2603:10a6:20b:e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Wed, 19 Jan 2022 09:37:43 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%5]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 09:37:43 +0000 Subject: Re: [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy To: devel@edk2.groups.io, kuqin12@gmail.com Cc: Jian J Wang , Liming Gao , Hao A Wu , Michael D Kinney , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , Bret Barkelew , Michael Kubacki , nd References: <20211221013334.1751-1-kuqin12@gmail.com> From: "Sami Mujawar" Message-ID: Date: Wed, 19 Jan 2022 09:37:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211221013334.1751-1-kuqin12@gmail.com> X-ClientProxiedBy: LO4P123CA0339.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::20) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 88fc7554-79a2-443d-096c-08d9db2f5d62 X-MS-TrafficTypeDiagnostic: AM6PR08MB5206:EE_|VE1EUR03FT024:EE_|AM0PR08MB4097:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4303;OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ti2iTFsuMK58H+Iu4Kw8Y0PR407mbPpMh07YbLfGqda+PXZiinCYv5tMeA0/SbHsjtm1JSxef1FcUsuDR3Xh2QaZjfYYAWXY7oJ3mV/ZNmfPaH8Qbiv3UwgJUgKNCxJcvnRlKOO8YcvfJ3Mx8hVD1F2qbxWJNZgR/6UVqbaWxcqq3AAd0ScumCs6Hi+09fYOHu8o48haujxo1pOfhU4GKVtvuzNZtCmyk2And7gpnQ4nejOvOA7pzoJ6Twyim/ohePCfFS7P448GAfqUVJ3zLA0ueC35zOYk+SIQDucEZx3y7CzqafmrJHmbkd1DVMK+mjJwxn9NIh1R4LI5uRT98J0/zzOpD2HEbpvtPmo4uFDy8gMzpPP3SCSlAdihsecuA6+9xCgq28R4lhVGbHrCvs4zNplebiJ/VA/WUF4p4QdPEUKWihke2jL1+dUVMPLPIisFlztmhSNs+56FwuLUsIbTeNepU2lM8x2ov2nGEwGIBdBZvXXcdR1U3V/DtwklUdm4Z/UTcM0IzY95+C+P0NOzybdgufLmlPzQdPFhkBHofSBRzO81rwozEwGb7QiBeyG09J+r4UkCMNEWKNxtFP6dFPZi7XBCt6kLZ200CzE7kyHHZZIXymmVmKb/2VtciCtY0LGX0UCaZ0K8tq67I3ROR8Pcp5WvxP4XFsr/ohkGS7aihduB4tY+yebNmNJ7XVkLEU7WfQejzCfSjRVlHgw1h+ZT0YVi0F+FfeNWShoPQ0jyqIQwNY2d+l73qkFyUmxYA8v2to7/J+yWNFYnPMfPZfZJJugm+I0n89GIBtUw5JDiIr1D5shIe620Ehhz8JgwPGtvs8gjRGhgKkGBsgqXrMQSHTcHw8t3P6I3geTP8MM8vAl7hBnN6BSiviCB21liECfpLOey1nxIjs0q9w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(86362001)(2906002)(7416002)(45080400002)(26005)(44832011)(186003)(66556008)(316002)(66476007)(31686004)(38100700002)(52116002)(38350700002)(966005)(83380400001)(19627235002)(6512007)(8676002)(5660300002)(8936002)(2616005)(31696002)(4326008)(36756003)(508600001)(53546011)(6506007)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5206 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b0d2b08b-f920-439a-3a86-08d9db2f5785 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 84Id17FgwOWC16oOxjVXh3bnFZkPhouonD7kyrQq4LEibmB+ajhd7pmOA+rNKtsZB8HlyyHM0WS/eTYiaCRN3GZlrb/B502LwrcdWjYSLKiSNwWhheVlrHn6aM2J0Fook2Xiu0IT7rF5kQr3Ve5NIms9p+MoSuXxxtTxUXNGriaHEhqayIWHkl4orY+rBdmxf9ol0rsl8NZzyLAmCsroxysRdyz2VIi6WJLBKYCUebfWHk1dQ/gaVuiEan+iHC07s2DlTAEaOl9pp17+BnMwAaEt2iAuzmQX+XO/4B6ZayVqL9ga2CjW9kjUyRd4tyhxEFCEguE31Kc7raNVXZ7/JsfbpCOtLM8YIi3KgaBw/fFx8uaLMhiuG1pt51K8jZrRo7GqlXWJTAkCOp9A+MYfo0DyTmLyaM4WKNM1Zs7I0HmpJifl2o5Lb//B43CkpgiD7KTtoaCXPmf37A+fYq0WqiheoRr244xgakjKZm4ksrGATXF/rr1ttQTz+460uv5sDB1CwVZLRDC/274BM2il0il7MbLc8xq6xU/fuU83vn0MkB4+cyxuOpMAa9woy0Tszlaewwz3nOS5U9brEspHmby7CEgyGWEgm833yU5j3t3yfrozzd1YlMDQPbHStBYTa1KBFdm4r8Vz96TX+ctaPW7w7MTDbYCxixAhr2cawjyZPzbyDpuprzEjGboaH3pVDpqXwE3N0aSHQCm4zFTkKyPb5d8POd9IU+nxdyi3MnTF5OMAM1TVF1qREbXutmCAfwTOib1iuL4TAuGK5TuPWbkmlfYW0YCdjTyEZq+cSZD81E5fLWIDoHblG5oSkDs/9hl/EdQCZF/cEUDSkRqVRwehRKaOz5nJ/GPT7gfnYpBcXcfx1GorlIJ7n8HyCnuuMkQ+WwV82VhNKUAza2ewbBuhNhtIcRyRR3jEu3WDFPg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(40470700002)(46966006)(36840700001)(186003)(70586007)(86362001)(70206006)(45080400002)(40460700001)(2616005)(81166007)(82310400004)(6506007)(8676002)(4326008)(54906003)(31696002)(316002)(47076005)(356005)(19627235002)(6486002)(36860700001)(8936002)(966005)(44832011)(2906002)(83380400001)(53546011)(336012)(36756003)(5660300002)(508600001)(31686004)(26005)(6512007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 09:37:52.5194 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88fc7554-79a2-443d-096c-08d9db2f5d62 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4097 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Kun, Thank you for this patch series. These changes look good to me. For this series Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 21/12/2021 01:33 AM, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751 > > This patch series is a follow up of previous submission: > https://edk2.groups.io/g/devel/message/84140 > > v2 patches mainly focus on feedback for commits submitted in v1 patches: > a. Splitted the original ArmPkg patch into 4 separate patches; > b. Updated patches according to Uncrustify scanning results; > > Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2 > > Cc: Jian J Wang > Cc: Liming Gao > Cc: Hao A Wu > Cc: Michael D Kinney > Cc: Zhiguang Liu > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Bret Barkelew > Cc: Michael Kubacki > > Kun Qin (6): > MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message > Length > MdePkg: MmCommunication2: Update MM communicate2 function description > ArmPkg: MmCommunicationDxe: MM communicate function argument > attributes > ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**` > checks > ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check > ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength` > check > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 46 ++++++++++++-------- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++--- > MdePkg/Include/Protocol/MmCommunication2.h | 13 +++--- > 3 files changed, 41 insertions(+), 28 deletions(-) >