public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Subject: Re: [Patch] UefiCpuPkg/MpInitLib: Remove useless code.
Date: Thu, 19 Jul 2018 15:08:55 +0200	[thread overview]
Message-ID: <ce46b06b-d97b-06fa-d922-0be2db6ff304@redhat.com> (raw)
In-Reply-To: <20180719121233.14180-1-eric.dong@intel.com>

On 07/19/18 14:12, Eric Dong wrote:
> Remove the useless code error added by change
> 58942277bcbf41abda5f6e3a1c89d571105d5983.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> index 06d966b227..e6e1b7c57d 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
> @@ -44,21 +44,6 @@ EFI_PEI_NOTIFY_DESCRIPTOR        mS3SmmInitDoneNotifyDesc = {
>    NotifyOnS3SmmInitDonePpi
>  };
>  
> -/**
> -  The function prototype for invoking a function on an Application Processor.
> -
> -  This definition is used by the UEFI MP Serices Protocol, and the
> -  PI SMM System Table.
> -
> -  @param[in,out] Buffer  The pointer to private data buffer.
> -**/
> -VOID
> -EmptyApProcedure (
> -  IN OUT VOID * Buffer
> -  )
> -{
> -}
> -
>  /**
>    S3 SMM Init Done notification function.
>  
> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>


      reply	other threads:[~2018-07-19 13:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 12:12 [Patch] UefiCpuPkg/MpInitLib: Remove useless code Eric Dong
2018-07-19 13:08 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce46b06b-d97b-06fa-d922-0be2db6ff304@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox