Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc

["Laszlo Ersek" <lersek@redhat.com>]

On 01/07/21 20:41, Leif Lindholm wrote:
> Commit 55ee36b0c490
> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> build of EmbeddedPkg.dsc.
> 
> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
>  EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index e88d76ab2f04..8e83e50c3ef0 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -103,6 +103,8 @@ [LibraryClasses.common]
>    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>    DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
>  
> +  TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> +
>  [LibraryClasses.common.DXE_DRIVER]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>    ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please:

OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found
        in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64]
        consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf]

Thanks,
Laszlo