* [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc
@ 2021-01-07 19:41 Leif Lindholm
2021-01-07 20:25 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 5+ messages in thread
From: Leif Lindholm @ 2021-01-07 19:41 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Nhi Pham
Commit 55ee36b0c490
("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
build of EmbeddedPkg.dsc.
Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
index e88d76ab2f04..8e83e50c3ef0 100644
--- a/EmbeddedPkg/EmbeddedPkg.dsc
+++ b/EmbeddedPkg/EmbeddedPkg.dsc
@@ -103,6 +103,8 @@ [LibraryClasses.common]
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
+ TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
+
[LibraryClasses.common.DXE_DRIVER]
PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc
2021-01-07 19:41 [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc Leif Lindholm
@ 2021-01-07 20:25 ` Laszlo Ersek
2021-01-08 9:13 ` Ard Biesheuvel
2021-01-08 14:15 ` Leif Lindholm
0 siblings, 2 replies; 5+ messages in thread
From: Laszlo Ersek @ 2021-01-07 20:25 UTC (permalink / raw)
To: devel, leif; +Cc: Ard Biesheuvel, Nhi Pham
On 01/07/21 20:41, Leif Lindholm wrote:
> Commit 55ee36b0c490
> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> build of EmbeddedPkg.dsc.
>
> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
> EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index e88d76ab2f04..8e83e50c3ef0 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -103,6 +103,8 @@ [LibraryClasses.common]
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
>
> + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> +
> [LibraryClasses.common.DXE_DRIVER]
> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please:
OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found
in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64]
consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf]
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc
2021-01-07 20:25 ` [edk2-devel] " Laszlo Ersek
@ 2021-01-08 9:13 ` Ard Biesheuvel
2021-01-08 14:24 ` Leif Lindholm
2021-01-08 14:15 ` Leif Lindholm
1 sibling, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2021-01-08 9:13 UTC (permalink / raw)
To: Laszlo Ersek, devel, leif; +Cc: Nhi Pham
On 1/7/21 9:25 PM, Laszlo Ersek wrote:
> On 01/07/21 20:41, Leif Lindholm wrote:
>> Commit 55ee36b0c490
>> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
>> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
>> build of EmbeddedPkg.dsc.
>>
>> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Nhi Pham <nhi@os.amperecomputing.com>
>> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> ---
>> EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
>> index e88d76ab2f04..8e83e50c3ef0 100644
>> --- a/EmbeddedPkg/EmbeddedPkg.dsc
>> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
>> @@ -103,6 +103,8 @@ [LibraryClasses.common]
>> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
>>
>> + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>> +
>> [LibraryClasses.common.DXE_DRIVER]
>> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please:
>
> OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found
> in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64]
> consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf]
>
> Thanks,
> Laszlo
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc
2021-01-07 20:25 ` [edk2-devel] " Laszlo Ersek
2021-01-08 9:13 ` Ard Biesheuvel
@ 2021-01-08 14:15 ` Leif Lindholm
1 sibling, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2021-01-08 14:15 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: devel, Ard Biesheuvel, Nhi Pham
On Thu, Jan 07, 2021 at 21:25:17 +0100, Laszlo Ersek wrote:
> On 01/07/21 20:41, Leif Lindholm wrote:
> > Commit 55ee36b0c490
> > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> > build of EmbeddedPkg.dsc.
> >
> > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Nhi Pham <nhi@os.amperecomputing.com>
> > Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> > ---
> > EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> > index e88d76ab2f04..8e83e50c3ef0 100644
> > --- a/EmbeddedPkg/EmbeddedPkg.dsc
> > +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> > @@ -103,6 +103,8 @@ [LibraryClasses.common]
> > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
> >
> > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> > +
> > [LibraryClasses.common.DXE_DRIVER]
> > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks.
Apologies for missing your R-b on the patch I just pushed.
> A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please:
>
> OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found
> in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64]
> consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf]
Agh, I mistakenly assumed we had only ARM consumers of that lib in the
main repo. Next time I'll actually grep. Patch sent.
/
Leif
> Thanks,
> Laszlo
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc
2021-01-08 9:13 ` Ard Biesheuvel
@ 2021-01-08 14:24 ` Leif Lindholm
0 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2021-01-08 14:24 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Laszlo Ersek, devel, Nhi Pham
On Fri, Jan 08, 2021 at 10:13:00 +0100, Ard Biesheuvel wrote:
> On 1/7/21 9:25 PM, Laszlo Ersek wrote:
> > On 01/07/21 20:41, Leif Lindholm wrote:
> >> Commit 55ee36b0c490
> >> ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib")
> >> added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks
> >> build of EmbeddedPkg.dsc.
> >>
> >> Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf.
> >>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> >> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Thanks!
Pushed as fabeffb09e3b.
> >> ---
> >> EmbeddedPkg/EmbeddedPkg.dsc | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> >> index e88d76ab2f04..8e83e50c3ef0 100644
> >> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> >> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> >> @@ -103,6 +103,8 @@ [LibraryClasses.common]
> >> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
> >>
> >> + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
> >> +
> >> [LibraryClasses.common.DXE_DRIVER]
> >> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> >> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >>
> >
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >
> > A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please:
> >
> > OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found
> > in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64]
> > consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf]
> >
> > Thanks,
> > Laszlo
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-08 14:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-07 19:41 [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc Leif Lindholm
2021-01-07 20:25 ` [edk2-devel] " Laszlo Ersek
2021-01-08 9:13 ` Ard Biesheuvel
2021-01-08 14:24 ` Leif Lindholm
2021-01-08 14:15 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox