From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.2594.1610051125518204331 for ; Thu, 07 Jan 2021 12:25:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MyzJGpiX; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610051124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sox0J0fTd/nEqEISy+4KdTEIa1PcWholCr1JJ4YzlcQ=; b=MyzJGpiXlcFFDlX5YEMB+IOqgSrQ52ZJc9O0YIpj0OHtprlRlURFCJ+tFc0OPszY9pabvN Q6mcvdvdkE4cU8df8xHwepkFEIj2pKAA0tDxyd6qygve0tc0EuYGwRSrJCiP22mumgbjJO 1qtpa/6MujXgvB3D9LPqQw/WGcrJKqA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-DbVCyuovNmWJxG7Lg80fWg-1; Thu, 07 Jan 2021 15:25:21 -0500 X-MC-Unique: DbVCyuovNmWJxG7Lg80fWg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80D898015F4; Thu, 7 Jan 2021 20:25:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-164.ams2.redhat.com [10.36.112.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B90C10016FB; Thu, 7 Jan 2021 20:25:18 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: add TimeBaseLib resolution to EmbeddedPkg.dsc To: devel@edk2.groups.io, leif@nuviainc.com Cc: Ard Biesheuvel , Nhi Pham References: <20210107194158.11539-1-leif@nuviainc.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 7 Jan 2021 21:25:17 +0100 MIME-Version: 1.0 In-Reply-To: <20210107194158.11539-1-leif@nuviainc.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/07/21 20:41, Leif Lindholm wrote: > Commit 55ee36b0c490 > ("EmbeddedPkg/RealTimeClockRuntimeDxe: Use helper functions from TimeBaseLib") > added a TimeBaseLib dependency to RealTimeClockRuntimeDxe, which now breaks > build of EmbeddedPkg.dsc. > > Add a resolution for EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf. > > Cc: Ard Biesheuvel > Cc: Nhi Pham > Signed-off-by: Leif Lindholm > --- > EmbeddedPkg/EmbeddedPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > index e88d76ab2f04..8e83e50c3ef0 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dsc > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > @@ -103,6 +103,8 @@ [LibraryClasses.common] > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf > > + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf > + > [LibraryClasses.common.DXE_DRIVER] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > Reviewed-by: Laszlo Ersek A similar patch is needed for "OvmfPkg/OvmfXen.dsc" please: OvmfPkg/OvmfXen.dsc(...): error 4000: Instance of library class [TimeBaseLib] is not found in [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] [X64] consumed by module [EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf] Thanks, Laszlo