From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68BCEAC09BE for ; Tue, 29 Aug 2023 02:35:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YbL6xo1ZlRAIS5+W017F4Lkc4c0BUhHzniYNZFvsSGE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693276553; v=1; b=Oq5J56Dugbf6YjHTDzQ0/KdwJcFnk0INKHQAAh7TKpNLNyzwfbB51Vao2ezkoLCwlzCFGphB CwitQGSAFoEJRvlPL2egfHCKs6qmD59uySfmyGEDis/nICWoX2MuKHkfsOiohcNLLx0WsK4r3I8 hSQBdMM1hJ3HdF1QuUkxpr84= X-Received: by 127.0.0.2 with SMTP id H7wLYY7687511xqjnwkaZfPj; Mon, 28 Aug 2023 19:35:53 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.131]) by mx.groups.io with SMTP id smtpd.web10.9216.1693276552259855913 for ; Mon, 28 Aug 2023 19:35:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MhG9laSk6qWhq9BVdIgmUEeTnpwD7q0osmnyt4WLtNFXU3dsHUZqwWxTkru8BQvk5AhMbc1dQlebKZGLBxUZdKgz6WEkWpBiK1wx60siiynhNXjy02ruPSzx1+3YV0u5CMHHW7W6p1GoPNAKQHIgi3ee5A7iK+DTFnVXU2TR5Fr9xNqURp8OByz/VZSSCjAROEZg7erR1kAsF6IABWpwmWK18PefZXRTqplnOgZuEFTQVxxUvuNrarTBsQpXkZgjJNeJdUwrXrubV+MacHKeneAGivdvOqhtHvHjtCV0FF3LjmjxVecVBpfQNhleOKeVkpNu+fMWpBdxCgjWIo4cPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1qKZjf3ZtRaP13fn7EmgdEd0vIz4HWrO2KC4Oxp1HZ0=; b=NrALmsnIZJ3P1yvGJthrzBPR4ML+zw4liK2dOZDkqo36ogL8N8ewVm2u+6lDJEjnvUa6z+BZgzkEd+Va/9vDPqdN9bSn6bWkJSfbIr3gyerhJxTOkFl4aS4w6WW3SvLMnLV7uVmGFq5k5qgoHSavFcjHNooii7U5hAfoNfVOFrShfekkmdQYFGszJXInRJVtWEMiRpU/QVRgXcjxkHUwVceO/ACvG4I6HubA4putbf5mMd1Dqk9+zJzyGO/7In9P36FgFGry1gsRQNOY2lNfdp3Nb/sZ4IJ/bQk1TGhr0HroqjPE8ztxvypM0HkFiP8L29uC1jT7cRkzLll7M+8Vlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none X-Received: from SA1PR01MB7279.prod.exchangelabs.com (2603:10b6:806:1f2::18) by LV2PR01MB7863.prod.exchangelabs.com (2603:10b6:408:14d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.34; Tue, 29 Aug 2023 02:35:49 +0000 X-Received: from SA1PR01MB7279.prod.exchangelabs.com ([fe80::ff39:69dd:edfb:6691]) by SA1PR01MB7279.prod.exchangelabs.com ([fe80::ff39:69dd:edfb:6691%5]) with mapi id 15.20.6699.034; Tue, 29 Aug 2023 02:35:48 +0000 Message-ID: Date: Tue, 29 Aug 2023 09:35:38 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID To: "Gao, Zhichao" , Nhi Pham , "devel@edk2.groups.io" References: <20230818065347.436331-1-nhi@os.amperecomputing.com> From: "Nhi Pham via groups.io" In-Reply-To: X-ClientProxiedBy: SI1PR02CA0023.apcprd02.prod.outlook.com (2603:1096:4:1f4::19) To SA1PR01MB7279.prod.exchangelabs.com (2603:10b6:806:1f2::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR01MB7279:EE_|LV2PR01MB7863:EE_ X-MS-Office365-Filtering-Correlation-Id: c72954bc-dcec-4f61-8748-08dba838a777 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: bKmlpPH9AbDtD28LrhY44tg60X++ON0gD3IyZEs9NqAeBFM/C1qtWI3PQXg5va7HO/b0bS3DiT132TD1J/5m6nzQrwOp33zxVRcRAqBljsHrv4/1hyK5zGrWOX/SOpbQz2xPrsMkTtKRT+rBIal3da1IBGPbOjlmGsHmMD4Oq1XWv7yRXBvDqst388ftztM4V3S2WLkTAOiHH7JWNj0WsLfNgo91Gttzd1sR0RRszDefbGeShOjZTKxBeRkF+HfIbXczFRllGZGuy3xc3UOGyMibtA5pQrUjoRsGRHMDZ4HLv5GcI2m4nJdRHMC/YRQBOlyl+JvSKJbFqLxnBWtFQCzKKxhB0KSLuLTO59ukkYp5UxltLHi7dmFEBylNmi6z7KiLTD+pjqGeyIFYdUrBO3ttth/WgxZJWMJgpEtUtojF4gJVxttmUauM3O/zX6JhPnPAw8xENFiyMswqmGqAGQfmXDtE4gqUrDruYE9VBBbHs5R1sXGUJjIPFmHL3AJV4PvV5rTAA9xrrOTAtF4fyrOhg+8xfdp/Yls0/2UEZun4xqHi1Rf0iKR/fEUSCZTun4IzA9IwN98U2Qp7OTOKqCwZUm8vRtIumeoMSh3/cQ4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEFFbEJCZ3NRZGI4WW45TWhOdm10V2N6ZHZQTWROVm1YNWl5Q3RxdGt1VTlz?= =?utf-8?B?ZS9YRHFCNUpuWkVLU1BNY25XMURBY2g5NTB1TDE2L3FpMDk3ZHlQbnRtVW1l?= =?utf-8?B?RUVpODNGdU8rb0tENFQxb0NmS3QxbzJhYnFLOStwYkVhdTEzaWxVZCtrbWdH?= =?utf-8?B?blEvamdjRExiRjRQWHM3UkgvKzlCTVdGZStrdjVwYmtNMy85ckc1eFZSdWxW?= =?utf-8?B?U2QyaVp6ZkhoNGthZVdMRUdLWVpXcW5lb1JVMHpRbkxTUExENHprWFh0T2dk?= =?utf-8?B?ZWE5dGRBU0FUbVNWbGdoSFErMUtDYjhJSWRBMitXM2FQVURXN1hSM1ZPRUJ3?= =?utf-8?B?b0Q2WlJ3eU1oK21NcGtiakFWWTJ3cVJSc3U0YVRtZDNGTVc3YkduNWViME5w?= =?utf-8?B?YmRYVGZvUG5mUDJkRGQzbi83cmJxWEZNNlN3NGFsdmtPT2hHZ1VEL2RsWTh5?= =?utf-8?B?eTNQaDdGWElTeStoWDJOTlpKOUpURWV1dExZbTl3RW54THdic2djd2djeHVY?= =?utf-8?B?SWJseVltcElsNVJuQVp4bTJ1T0JFby83ZCtEYTZuNkRCMWZEWm9GQkFCRFRT?= =?utf-8?B?cGozV0ZhQjRuNTRGZEdYZnNyYjBXa3phR21EWUdRVUt3OUlnMEJXd3NwNWJs?= =?utf-8?B?emxvanZSZVhCaEZHc3lQai9QMXQ2TFNvbUltNmk3OFlVQm9WeHhlaVJoaG5E?= =?utf-8?B?WUtIR2c2N0V1bVY0SExrWTgvSlNKRjdaMThiQ2IvUGdJTzRFUFlDZXliS3NW?= =?utf-8?B?TStiN2ZnSmlzeTB6T1l4VS9zZkYvRnQ3NFFzcTdUV08xNnIyZnBQYnJSRjNL?= =?utf-8?B?MEl0NWJpSVdtY3R6YXM0T3pxbCtkc0NodzRtU1gzYmpjd0wwWlhqM1lydjJT?= =?utf-8?B?TEFpYkFuTHVnbTNaZDBPeC96VXM3Y0NZdmtYQUQxVldQdDRjMm1MaGthMi8r?= =?utf-8?B?eDVpUTZWY1p2N2k1Ym9HVytLY1JxVWFFUDZXc0UvUWNxckthQ2Zmek9LMUF2?= =?utf-8?B?MjFpeUViek9CWEplT1RnY0JrdnRnSXJucGZzb3VMT0dhc25oYmZnNEVEMlRh?= =?utf-8?B?ZDJVUlRiTEF6Y2FxSmpheERMYzVrcWx6L0tLOTB3K2k2N24wQTkwWjRCbjVP?= =?utf-8?B?amFya2d5S3FMSm1IWFlOVU5sc3J1aWpwN3JoaU1rR1dWTE4zYnBpcWIrTzIw?= =?utf-8?B?cEVCY0oydUJxNFZtQnozNUVtdE1jWGhHbWRrdFVadUdJa0J6WldobkFjV0ll?= =?utf-8?B?TUFjNEZudktxaUVBMnZiOVVXTTA3dzVYdEZqUzhkbGo2dXBCcGg2SjBQQnUx?= =?utf-8?B?WUtCK2ZWbzRBOElVN3V5anFxQlM0K1kzWThiWWJ3aHJPL3ZUam9DZEhMMlc2?= =?utf-8?B?bklNUUIwaWR6d01pWjNLZGJvMjZUS0lGRE01T0VMWEs4T1RjSjJFQXNDU3JH?= =?utf-8?B?bkkrMUtobTBreXpkankwbHhwTFRIUlBqR3M2REhwbmxsNnZ0RUJzL0F3dDRT?= =?utf-8?B?cm12T3RGUkhjWW9jVkd1R1JveTZNWGJ6bkFKMWxJWERwdSsrMmpYdWNVcUgx?= =?utf-8?B?Sndnajc4VDJSc05TaFFoQUp5R2VpL0NJWHJxVDhJcGJFakJ3OFZ0K1dTdkJY?= =?utf-8?B?bExCWVZaY216N0Niam9iK0R6OG1QNVpkcENiOWtKcnlha0x4RjhHWVJ4SU9F?= =?utf-8?B?Z3ptU0Q1blIrSDRzcTBXOVZIQlNXL1FSTTYxR3llUE9xWUxvRWdvSUFFV1Az?= =?utf-8?B?d1ozWDNRN1VDelVTZ01rQlJkK2R2aXp6T2syanowZ3JHSHdRVE1IZlVEUG9E?= =?utf-8?B?aFFNeWEwMXdrYWdGbjRxTGNuaEdWb3Fncmh2MGg2T0dHWTFXZ00rc2ltK1pO?= =?utf-8?B?REdvbnZUK3VXWkI4MEdDL0RhU0ExOFJ1NGV6U1BaVEp6ZFRuNVZNSDV0dEdn?= =?utf-8?B?MWt1empBMnUzOHlLaVRZRmVVdm1MVk1MWGcwYVE5bU5heUxOK01QekNIMkw4?= =?utf-8?B?dU9ucm84cGVkYkZ6UmpFeFNCUzFZd1lPa2JSQko4RlltM2FZeE10ZTNqRTBM?= =?utf-8?B?ck5kS3J2QytqWkMrQzVwTlFNMEtyMGtJcGRKWWZwMTJaZXZ4bDJROHluWTNn?= =?utf-8?B?VVBxMDNqR2VUcjNRM2JpT25hdmFEdUp1U0tlUWdHT3RQeGN1Ri9hYW5PVThS?= =?utf-8?B?MHc9PQ==?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: c72954bc-dcec-4f61-8748-08dba838a777 X-MS-Exchange-CrossTenant-AuthSource: SA1PR01MB7279.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2023 02:35:48.7451 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hbi0JL5bn9f5S8wiVyYc82GHAO3K9hnfP1Hllui8K5miyJ+RgQ3RbMNg86FZt8qeOJKE8K9nao0DBA+p29PZDk6hEADRIRgS86U2Imp6dUA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7863 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jxNTbBrZhCRojVzUNqTyRWkqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Oq5J56Du; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Zhichao, I updated the commit message and also created a PR at=20 https://github.com/tianocore/edk2/pull/4767 Please help check. Regards, -Nhi On 8/21/2023 2:01 PM, Gao, Zhichao wrote: > Better to update the commit message with specific SMBIOS version. > Others looks good to me. > > Thanks, > Zhichao > >> -----Original Message----- >> From: Nhi Pham >> Sent: Friday, August 18, 2023 2:54 PM >> To: devel@edk2.groups.io >> Cc: Nhi Pham ; Gao, Zhichao >> >> Subject: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system >> slot ID >> >> This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond >> (0xC4) to cover modern PCIe Gen. >> >> Cc: Zhichao Gao >> Signed-off-by: Nhi Pham >> --- >> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 >> +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> index f55d5f953c04..b6968cb36acb 100644 >> --- >> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> +++ >> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> @@ -3105,7 +3105,7 @@ DisplaySystemSlotId ( >> break; >> >> >> >> default: >> >> - if (((SlotType >=3D 0x0E) && (SlotType <=3D 0x12)) || ((SlotType = >=3D 0xA6) && >> (SlotType <=3D 0xB6))) { >> >> + if (((SlotType >=3D 0x0E) && (SlotType <=3D 0x12)) || ((SlotType = >=3D 0xA6) && >> (SlotType <=3D 0xC4))) { >> >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >> (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle, >> SlotId); >> >> } else { >> >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >> (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID), >> gShellDebug1HiiHandle); >> >> -- >> 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108074): https://edk2.groups.io/g/devel/message/108074 Mute This Topic: https://groups.io/mt/100816049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-