* [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID @ 2023-08-18 6:53 Nhi Pham via groups.io 2023-08-21 7:01 ` Gao, Zhichao 0 siblings, 1 reply; 4+ messages in thread From: Nhi Pham via groups.io @ 2023-08-18 6:53 UTC (permalink / raw) To: devel; +Cc: Nhi Pham, Zhichao Gao This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond (0xC4) to cover modern PCIe Gen. Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index f55d5f953c04..b6968cb36acb 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -3105,7 +3105,7 @@ DisplaySystemSlotId ( break; default: - if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) && (SlotType <= 0xB6))) { + if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) && (SlotType <= 0xC4))) { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle, SlotId); } else { ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID), gShellDebug1HiiHandle); -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107843): https://edk2.groups.io/g/devel/message/107843 Mute This Topic: https://groups.io/mt/100816049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID 2023-08-18 6:53 [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID Nhi Pham via groups.io @ 2023-08-21 7:01 ` Gao, Zhichao 2023-08-29 2:35 ` Nhi Pham via groups.io 0 siblings, 1 reply; 4+ messages in thread From: Gao, Zhichao @ 2023-08-21 7:01 UTC (permalink / raw) To: Nhi Pham, devel@edk2.groups.io Better to update the commit message with specific SMBIOS version. Others looks good to me. Thanks, Zhichao > -----Original Message----- > From: Nhi Pham <nhi@os.amperecomputing.com> > Sent: Friday, August 18, 2023 2:54 PM > To: devel@edk2.groups.io > Cc: Nhi Pham <nhi@os.amperecomputing.com>; Gao, Zhichao > <zhichao.gao@intel.com> > Subject: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system > slot ID > > This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond > (0xC4) to cover modern PCIe Gen. > > Cc: Zhichao Gao <zhichao.gao@intel.com> > Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index f55d5f953c04..b6968cb36acb 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3105,7 +3105,7 @@ DisplaySystemSlotId ( > break; > > > > default: > > - if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) && > (SlotType <= 0xB6))) { > > + if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) && > (SlotType <= 0xC4))) { > > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle, > SlotId); > > } else { > > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID), > gShellDebug1HiiHandle); > > -- > 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107911): https://edk2.groups.io/g/devel/message/107911 Mute This Topic: https://groups.io/mt/100816049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID 2023-08-21 7:01 ` Gao, Zhichao @ 2023-08-29 2:35 ` Nhi Pham via groups.io 2023-08-30 6:20 ` Gao, Zhichao 0 siblings, 1 reply; 4+ messages in thread From: Nhi Pham via groups.io @ 2023-08-29 2:35 UTC (permalink / raw) To: Gao, Zhichao, Nhi Pham, devel@edk2.groups.io Thanks Zhichao, I updated the commit message and also created a PR at https://github.com/tianocore/edk2/pull/4767 Please help check. Regards, -Nhi On 8/21/2023 2:01 PM, Gao, Zhichao wrote: > Better to update the commit message with specific SMBIOS version. > Others looks good to me. > > Thanks, > Zhichao > >> -----Original Message----- >> From: Nhi Pham <nhi@os.amperecomputing.com> >> Sent: Friday, August 18, 2023 2:54 PM >> To: devel@edk2.groups.io >> Cc: Nhi Pham <nhi@os.amperecomputing.com>; Gao, Zhichao >> <zhichao.gao@intel.com> >> Subject: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system >> slot ID >> >> This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond >> (0xC4) to cover modern PCIe Gen. >> >> Cc: Zhichao Gao <zhichao.gao@intel.com> >> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> >> --- >> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 >> +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> index f55d5f953c04..b6968cb36acb 100644 >> --- >> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> +++ >> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c >> @@ -3105,7 +3105,7 @@ DisplaySystemSlotId ( >> break; >> >> >> >> default: >> >> - if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) && >> (SlotType <= 0xB6))) { >> >> + if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) && >> (SlotType <= 0xC4))) { >> >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >> (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle, >> SlotId); >> >> } else { >> >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >> (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID), >> gShellDebug1HiiHandle); >> >> -- >> 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108074): https://edk2.groups.io/g/devel/message/108074 Mute This Topic: https://groups.io/mt/100816049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID 2023-08-29 2:35 ` Nhi Pham via groups.io @ 2023-08-30 6:20 ` Gao, Zhichao 0 siblings, 0 replies; 4+ messages in thread From: Gao, Zhichao @ 2023-08-30 6:20 UTC (permalink / raw) To: Nhi Pham, Nhi Pham, devel@edk2.groups.io Already add me push tag. Once it pass the CI, it would be merged. Thanks, Zhichao > -----Original Message----- > From: Nhi Pham <nhi@amperemail.onmicrosoft.com> > Sent: Tuesday, August 29, 2023 10:36 AM > To: Gao, Zhichao <zhichao.gao@intel.com>; Nhi Pham > <nhi@os.amperecomputing.com>; devel@edk2.groups.io > Subject: Re: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe > system slot ID > > Thanks Zhichao, I updated the commit message and also created a PR at > https://github.com/tianocore/edk2/pull/4767 > > Please help check. > > Regards, > > -Nhi > > On 8/21/2023 2:01 PM, Gao, Zhichao wrote: > > Better to update the commit message with specific SMBIOS version. > > Others looks good to me. > > > > Thanks, > > Zhichao > > > >> -----Original Message----- > >> From: Nhi Pham <nhi@os.amperecomputing.com> > >> Sent: Friday, August 18, 2023 2:54 PM > >> To: devel@edk2.groups.io > >> Cc: Nhi Pham <nhi@os.amperecomputing.com>; Gao, Zhichao > >> <zhichao.gao@intel.com> > >> Subject: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe > >> system slot ID > >> > >> This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond > >> (0xC4) to cover modern PCIe Gen. > >> > >> Cc: Zhichao Gao <zhichao.gao@intel.com> > >> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> > >> --- > >> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> | 2 > >> +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> index f55d5f953c04..b6968cb36acb 100644 > >> --- > >> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> +++ > >> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> @@ -3105,7 +3105,7 @@ DisplaySystemSlotId ( > >> break; > >> > >> > >> > >> default: > >> > >> - if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) > && > >> (SlotType <= 0xB6))) { > >> > >> + if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType > >> + >= 0xA6) && > >> (SlotType <= 0xC4))) { > >> > >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > >> (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle, > >> SlotId); > >> > >> } else { > >> > >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > >> (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID), > >> gShellDebug1HiiHandle); > >> > >> -- > >> 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108114): https://edk2.groups.io/g/devel/message/108114 Mute This Topic: https://groups.io/mt/100816049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-30 6:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-18 6:53 [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID Nhi Pham via groups.io 2023-08-21 7:01 ` Gao, Zhichao 2023-08-29 2:35 ` Nhi Pham via groups.io 2023-08-30 6:20 ` Gao, Zhichao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox