From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.3611.1589368064612291907 for ; Wed, 13 May 2020 04:07:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bitqU/2C; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589368063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rQ/vD/4QoZwSUMk9ftIBnb741/baZDz0nZk+2iTqnQE=; b=bitqU/2CQJXliJIfAKe7L+KxjBA9kyXvjoSrCaQQ1UWM2hMGr9c2+WC+HrcudMkzZ3Lo2D ZWjotYogUyOwhm4nQd/LRrk5qDPAsYAZRiMvesT6X5TMMs32mfa2mHAlbuPU2j81W5cW97 FGAp6kjJhlLNbAkN07RzxH4YshxOTMQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-OfjYWR4RM1eFSuap7_BMPw-1; Wed, 13 May 2020 07:07:36 -0400 X-MC-Unique: OfjYWR4RM1eFSuap7_BMPw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA31C8014C0; Wed, 13 May 2020 11:07:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-95.ams2.redhat.com [10.36.115.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id D99561000337; Wed, 13 May 2020 11:07:34 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib To: devel@edk2.groups.io, cheptsov@ispras.ru Cc: Eric Dong , Ray Ni References: <20200512170237.19796-1-cheptsov@ispras.ru> <20200512170237.19796-25-cheptsov@ispras.ru> From: "Laszlo Ersek" Message-ID: Date: Wed, 13 May 2020 13:07:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200512170237.19796-25-cheptsov@ispras.ru> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/12/20 19:02, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > CC: Eric Dong > CC: Ray Ni > CC: Laszlo Ersek > Signed-off-by: Vitaly Cheptsov > --- > UefiCpuPkg/UefiCpuPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index d28cb5cccb..f5f407ad23 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -27,6 +27,7 @@ [LibraryClasses] > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > + DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCommonLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > Again, identical to the v4 counterpart. Should have picked up my R-b. http://mid.mail-archive.com/0d0b6b6f-39c8-4056-c496-07151e33cdd5@redhat.com https://edk2.groups.io/g/devel/message/59202 anyway Reviewed-by: Laszlo Ersek