public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, kraxel@redhat.com
Subject: Re: [edk2-devel] [PATCH 0/2] Quo vadis virtio-mmio?
Date: Wed, 9 Jun 2021 12:34:09 +0200	[thread overview]
Message-ID: <cec470ad-5142-10b1-8ec3-c3a87ec90ca1@redhat.com> (raw)
In-Reply-To: <20210609050601.2754389-1-kraxel@redhat.com>

On 6/9/21 7:05 AM, Gerd Hoffmann wrote:
> virtio-mmio support in ovmf seems to be the unloved child.  The final
> virto-1.0 specification was published five(!) years ago, nevertheless
> the mmio transport doesn't support it yet ...
> 
> Some people argue that it has been obsoleted by virtio-pci.  Which is a
> valid argument.  But IMHO isn't a good reason to just let virtio-mmio
> bitrot.  We should either remove it from the tree, or support it.
> 
> So, opening the discussion with this little patch series.  It does the
> latter and adds virtio 1.0 support.  For the mmio transport the
> difference between 0.9.5 and 1.0 is rather small (when compared to the
> pci transport), it is just a bunch of new registers for the changed
> virtio queue initialization.  So the patch series is small too ...
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (2):
>   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
>   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.
> 
>  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 +++++++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  1 +
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++++++---
>  .../VirtioMmioDeviceFunctions.c               | 31 +++++++++++++++++--
>  4 files changed, 54 insertions(+), 7 deletions(-)

Series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


      parent reply	other threads:[~2021-06-09 10:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  5:05 [PATCH 0/2] Quo vadis virtio-mmio? Gerd Hoffmann
2021-06-09  5:06 ` [PATCH 1/2] OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines Gerd Hoffmann
2021-06-09  5:06 ` [PATCH 2/2] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support Gerd Hoffmann
2021-06-09 10:34 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cec470ad-5142-10b1-8ec3-c3a87ec90ca1@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox