From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.5922.1623234854319449739 for ; Wed, 09 Jun 2021 03:34:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Doh2amsu; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623234853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BfIQyCCq7iN5WBg4JfJ6B45KcUvXA3Nh4Z/F8Z+Y57U=; b=Doh2amsu1Uhu2kJO1Bo4+3yJEfRYaG7ip0YrbgFqV27msDckGmMgx2GZ2whOSsInI9Gzt7 NYkCtPymTOdAhfOry2o4gK9I/BA2vnruT++kLn+5jtxWXgMhjrH8pm1nCMWsPe2ZVyGPBa pyTwARd8MCbWwv6vIIP/UErcPL8zVhM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-VZntEoJ4MfqK-A8hJqZkWg-1; Wed, 09 Jun 2021 06:34:12 -0400 X-MC-Unique: VZntEoJ4MfqK-A8hJqZkWg-1 Received: by mail-wr1-f72.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso10569629wrf.4 for ; Wed, 09 Jun 2021 03:34:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BfIQyCCq7iN5WBg4JfJ6B45KcUvXA3Nh4Z/F8Z+Y57U=; b=kZ5XgCfEyDpeay9v1Pr3oZcW+BNthqCEsUL0tGZtl1/kmvDnFWxPI1HXXYkYdkazVJ 2L4XzOJesb73NPeae3JblmHBHEmn00gUZQ0ZTzXgZUT7L/2VEo0Z3ewUWUvqRDX1ZZU+ KA32iXFKFCGjxh1OsbjjDr6oA3LQzv0OInlucYNpnWUnyeqJhaEK2Vn6bVxFePv8szUm K/bi9qF9NLCUd/fJ9yU5jfiB8Qjog2W1vfNHdp+OjB8QLsCdtrWpq6sDaYsI/PoJqW9R o70qhWxm8tiXweaO1mEK40Ea+3Ea+AsJGY3McIxIBydImsGsTFJRTgmuip78EErCnp4m dT2A== X-Gm-Message-State: AOAM532mlsA5kUpT1FVIa3042IrIGZIbee9agadVNBqHgANdgrfUS9h3 l2LyH+y4Gafkf4j+qJouL/ahK492Y9Ik82RNHUnt4GfSYRwY+EurhTLtzeJaaTbg5JBFWsBr2xl 3t/SPsD2k9ptBGg== X-Received: by 2002:a1c:5f86:: with SMTP id t128mr9155569wmb.165.1623234851029; Wed, 09 Jun 2021 03:34:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo67hB2YgB2XRwfbyhYnY5fmJgJteVOvEjh1Y3H43mG/SrSDFWokugC/x1jn6jVfmf5EIgzA== X-Received: by 2002:a1c:5f86:: with SMTP id t128mr9155557wmb.165.1623234850850; Wed, 09 Jun 2021 03:34:10 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id w11sm23290777wrv.89.2021.06.09.03.34.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:34:10 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 0/2] Quo vadis virtio-mmio? To: devel@edk2.groups.io, kraxel@redhat.com References: <20210609050601.2754389-1-kraxel@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 9 Jun 2021 12:34:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210609050601.2754389-1-kraxel@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/9/21 7:05 AM, Gerd Hoffmann wrote: > virtio-mmio support in ovmf seems to be the unloved child. The final > virto-1.0 specification was published five(!) years ago, nevertheless > the mmio transport doesn't support it yet ... > > Some people argue that it has been obsoleted by virtio-pci. Which is a > valid argument. But IMHO isn't a good reason to just let virtio-mmio > bitrot. We should either remove it from the tree, or support it. > > So, opening the discussion with this little patch series. It does the > latter and adds virtio 1.0 support. For the mmio transport the > difference between 0.9.5 and 1.0 is rather small (when compared to the > pci transport), it is just a bunch of new registers for the changed > virtio queue initialization. So the patch series is small too ... > > take care, > Gerd > > Gerd Hoffmann (2): > OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines > OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support. > > OvmfPkg/Include/IndustryStandard/Virtio10.h | 12 +++++++ > .../VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + > .../VirtioMmioDeviceLib/VirtioMmioDevice.c | 17 +++++++--- > .../VirtioMmioDeviceFunctions.c | 31 +++++++++++++++++-- > 4 files changed, 54 insertions(+), 7 deletions(-) Series: Reviewed-by: Philippe Mathieu-Daude