From: "Thomas Abraham" <thomas.abraham@arm.com>
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Wenyi Xie <xiewenyi2@huawei.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Omkar Anand Kulkarni <omkar.kulkarni@arm.com>,
Pranav Madhu <pranav.madhu@arm.com>,
Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
Subject: Re: [PATCH edk2-platforms 1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag
Date: Thu, 26 Jan 2023 09:34:37 +0000 [thread overview]
Message-ID: <cf2b5109-e4cd-dc80-a1be-869f13dc7978@arm.com> (raw)
In-Reply-To: <20230125102802.663790-2-Pierre.Gondois@arm.com>
On 25/01/2023 10:27, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> The '-march=armv8-a+nofp' flag abort the following build:
> build -a AARCH64 -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> -t GCC5 -D SECURE_STORAGE_ENABLE
> Error message:
> CryptoPkg/Library/OpensslLib/openssl/crypto/rand/drbg_lib.c:1009:12:
> error: ‘+nofp’ feature modifier is incompatible with the use of
> floating-point types
> static int drbg_add(const void *buf, int num, double randomness)
> ^~~~~~~~
>
> In SgiPlatformMm.dsc.inc, the '-march=armv8-a+nofp' flag was
> originally added in:
> commit 1974293d1975 ("Platform/ARM/SgiPkg: Build infrastructure for
> StandaloneMm image")
> as a linker flag. The flag seem to have been added to avoid triggering
> an exception due to the floating point unit missing in RTL. With the
> latest RTL, the exception is not triggered anymore.
>
> commit 936e8dd57524 ("Platform/Sgi: Cleanup build options for
> StandaloneMM context")
> moves the flag from the linker to the compiler, making the build fail.
>
> Remove the '-march=armv8-a+nofp' flag as it is not necessary anymore
> for SgiPlatformMm.dsc.inc, and is probably not necessary for
> PlatformStandaloneMmRpmb.dsc.
>
> CC: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
> CC: Pranav Madhu <pranav.madhu@arm.com>
> CC: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> index 01f0a7657c51..f9a516b341f0 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> @@ -146,5 +146,5 @@ [Components.AARCH64]
> #
> ###################################################################################################
> [BuildOptions.AARCH64]
> - GCC:*_*_*_CC_FLAGS = -mstrict-align -march=armv8-a+nofp -D DISABLE_NEW_DEPRECATED_INTERFACES
> + GCC:*_*_*_CC_FLAGS = -mstrict-align -D DISABLE_NEW_DEPRECATED_INTERFACES
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
Thanks for this fix.
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
next prev parent reply other threads:[~2023-01-26 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 10:27 [PATCH edk2-platforms 0/5] Build fixes for Arm/Hisilicon platforms PierreGondois
2023-01-25 10:27 ` [PATCH edk2-platforms 1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag PierreGondois
2023-01-26 9:34 ` Thomas Abraham [this message]
2023-01-27 9:01 ` [edk2-devel] " Sami Mujawar
2023-01-25 10:27 ` [PATCH edk2-platforms 2/5] Platform/StandaloneMm: " PierreGondois
2023-01-26 9:35 ` Thomas Abraham
2023-01-26 9:52 ` Ilias Apalodimas
2023-01-27 9:02 ` [edk2-devel] " Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 3/5] Silicon/Hisilicon/FlashFvbDxe: Update TokenSpace of PcdNorFlashCheckBlockLocked PierreGondois
2023-01-26 11:19 ` [edk2-devel] " Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 4/5] Platform/Hisilicon: Add VariableFlashInfoLib to Hisilicon.dsc.inc PierreGondois
2023-01-26 11:31 ` [edk2-devel] " Sami Mujawar
2023-01-26 11:59 ` Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 5/5] Platform/ARM/Sgi: Add VariableFlashInfoLib to SgiPlatformMm.dsc.inc PierreGondois
2023-01-26 9:36 ` Thomas Abraham
2023-01-27 9:03 ` [edk2-devel] " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2b5109-e4cd-dc80-a1be-869f13dc7978@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox