From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf"
Date: Thu, 19 Jul 2018 16:56:38 +0200 [thread overview]
Message-ID: <cf32e33e-f7a0-1fab-5af2-ff47c81c27b9@redhat.com> (raw)
In-Reply-To: <CAKv+Gu9LfUqWpKzQ0i-p=0LiAEBanUJ+=-bpC4EMJtcjYTmBnw@mail.gmail.com>
On 07/18/18 16:02, Ard Biesheuvel wrote:
> On 18 July 2018 at 21:52, Laszlo Ersek <lersek@redhat.com> wrote:
>> None of the source files referenced by "AcpiPlatformDxe.inf" #include
>> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared
>> therein, so drop DxeServicesLib from [LibraryClasses].
>>
>> "AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI
>> tables built into the firmware image from under "OvmfPkg/AcpiTables/", in
>> case dynamically generated ACPI tables are not available from Xen or QEMU.
>> For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for
>> that in [Protocols].
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Steven Shi <steven.shi@intel.com>
>> Reported-by: Steven Shi <steven.shi@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thank you, commit a3fffb4f5e15.
Laszlo
>
>> ---
>>
>> Notes:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: acpiplatform_redundant_tiano_1014
>>
>> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> index edc192e03d73..8440e7b343d8 100644
>> --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> @@ -46,7 +46,6 @@ [Packages]
>>
>> [LibraryClasses]
>> UefiLib
>> - DxeServicesLib
>> PcdLib
>> BaseMemoryLib
>> DebugLib
>> @@ -62,6 +61,7 @@ [LibraryClasses]
>>
>> [Protocols]
>> gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED
>> + gEfiFirmwareVolume2ProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
>> gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
>>
>> [Guids]
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
prev parent reply other threads:[~2018-07-19 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 12:52 [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf" Laszlo Ersek
2018-07-18 14:02 ` Ard Biesheuvel
2018-07-19 14:56 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf32e33e-f7a0-1fab-5af2-ff47c81c27b9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox