From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BBA952098C8DA for ; Thu, 19 Jul 2018 07:56:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 10B6D40200A9; Thu, 19 Jul 2018 14:56:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-95.rdu2.redhat.com [10.10.120.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B0F5111AF0C; Thu, 19 Jul 2018 14:56:38 +0000 (UTC) To: Ard Biesheuvel Cc: Jordan Justen , edk2-devel-01 References: <20180718125222.9047-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: Date: Thu, 19 Jul 2018 16:56:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 19 Jul 2018 14:56:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 19 Jul 2018 14:56:40 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 14:56:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/18/18 16:02, Ard Biesheuvel wrote: > On 18 July 2018 at 21:52, Laszlo Ersek wrote: >> None of the source files referenced by "AcpiPlatformDxe.inf" #include >> "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared >> therein, so drop DxeServicesLib from [LibraryClasses]. >> >> "AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI >> tables built into the firmware image from under "OvmfPkg/AcpiTables/", in >> case dynamically generated ACPI tables are not available from Xen or QEMU. >> For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for >> that in [Protocols]. >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Steven Shi >> Reported-by: Steven Shi >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek > > Reviewed-by: Ard Biesheuvel Thank you, commit a3fffb4f5e15. Laszlo > >> --- >> >> Notes: >> Repo: https://github.com/lersek/edk2.git >> Branch: acpiplatform_redundant_tiano_1014 >> >> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> index edc192e03d73..8440e7b343d8 100644 >> --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf >> @@ -46,7 +46,6 @@ [Packages] >> >> [LibraryClasses] >> UefiLib >> - DxeServicesLib >> PcdLib >> BaseMemoryLib >> DebugLib >> @@ -62,6 +61,7 @@ [LibraryClasses] >> >> [Protocols] >> gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED >> + gEfiFirmwareVolume2ProtocolGuid # PROTOCOL SOMETIMES_CONSUMED >> gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED >> >> [Guids] >> -- >> 2.14.1.3.gb7cf6e02401b >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >