From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 475D02095DE6F for ; Thu, 10 Aug 2017 07:14:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4B9846292; Thu, 10 Aug 2017 14:16:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B4B9846292 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-96.phx2.redhat.com [10.3.116.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9CE68AD94; Thu, 10 Aug 2017 14:16:44 +0000 (UTC) To: Leif Lindholm , Jun Nie Cc: haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org, linaro-uefi@lists.linaro.org, shawn.guo@linaro.org, jason.liu@linaro.org, edk2-devel@lists.01.org References: <1502287959-16806-1-git-send-email-jun.nie@linaro.org> <20170810130447.2d42o6gsmeuz7gdb@bivouac.eciton.net> From: Laszlo Ersek Message-ID: Date: Thu, 10 Aug 2017 16:16:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810130447.2d42o6gsmeuz7gdb@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 10 Aug 2017 14:16:47 +0000 (UTC) Subject: Re: [PATCH 1/4] Platforms: Add Sanchip Zx296718 basic library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 14:14:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks for the CC On 08/10/17 15:04, Leif Lindholm wrote: > You've reworked this to be targeted for edk2-platforms, which is > excellent! However: > - Please update subject line to match. > - Please also cc edk2-devel@lists.01.org (since you are with Linaro, > it makes sense to still cc linaro-uefi) > > To get the appropriate subject line for edk2-devel, as desribed by > https://github.com/tianocore/edk2-platforms/blob/about/Readme.md it > would also be helpful to add > --subject-prefix="edk2-platforms/master][PATCH" to git format-patch > command line (unless Laszlo can point out a better way of achieving > the same). I seem to recall a discussion (not necessarily related to the edk2-platforms tree, but to another edk2-related tree, still posted to edk2-devel) that we're fine if you put the tree identified right after the PATCH word, between the same brackets. So just use --subject-prefix="PATCH edk2-platforms/master" or even (if "master" is quite obvious) --subject-prefix="PATCH edk2-platforms" > > On Wed, Aug 09, 2017 at 10:12:36PM +0800, Jun Nie wrote: >> Add Sanchip Zx296718 basic library files for Zx296718 SoC >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jun Nie >> --- >> .../Library/Zx296718EvbLib/Zx296718Evb.c | 132 +++++++++++++++++++++ >> .../Library/Zx296718EvbLib/Zx296718EvbHelper.S | 50 ++++++++ >> .../Library/Zx296718EvbLib/Zx296718EvbLib.inf | 53 +++++++++ >> .../Library/Zx296718EvbLib/Zx296718EvbMem.c | 107 +++++++++++++++++ >> Silicon/Sanchip/Zx296718/Include/Zx296718.h | 30 +++++ >> Silicon/Sanchip/Zx296718/Zx296718.dec | 32 +++++ > > It is more clear (especially when submitting new ports) to generate > the patches with --stat=1000, to make the full file paths visible. Yes, please -- I recommend: --stat=1000 --stat-graph-width=20 ("--stat=1000" without "--stat-graph-width=20" won't be pleasant.) Thanks! Laszlo