public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Vu Nguyen" <vunguyen@os.amperecomputing.com>
To: Leif Lindholm <leif@nuviainc.com>,
	Vu Nguyen <vunguyen@os.amperecomputing.com>
Cc: devel@edk2.groups.io, patches@amperecomputing.com,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Chuong Tran <chuong@os.amperecomputing.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Phong Vo <phong@os.amperecomputing.com>,
	Thang Nguyen <thang@os.amperecomputing.com>
Subject: Re: [edk2-non-osi][PATCH v3 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package
Date: Wed, 9 Jun 2021 20:42:04 +0700	[thread overview]
Message-ID: <cf35f830-579a-4884-ae0e-beb47e907217@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20210604134345.rog6ow3u3nwutpyq@leviathan>

Hi Leif,

It's just fine. But I hope this patch will be pushed before 
edk2-platforms to prevent compile error.

Regards,

Vu

On 6/4/2021 20:43, Leif Lindholm wrote:
> Hi Vu,
>
> For this set:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> Is there any value to you in me pushing this before the edk2-platforms
> set goes in? If not, I'll hold back and push them both at the same
> time.
>
> Best Regards,
>
> Leif
>
> On Wed, May 26, 2021 at 17:18:28 +0700, Vu Nguyen wrote:
>> Create edk2-non-osi component holder for Ampere Libraries. This patchset
>> also adds PciePhyLib which provides function to initialize PCIe PHY on
>> Ampere Altra processor.
>>
>> Commits in this patchset can be found at:
>> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Chuong Tran <chuong@os.amperecomputing.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Phong Vo <phong@os.amperecomputing.com>
>> Cc: Thang Nguyen <thang@os.amperecomputing.com>
>>
>> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
>>
>> Change since v2:
>>    Remove unused macros and function prototypes from the header file.
>>    Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.
>>
>> Change since v1:
>>    Remove PciePhyLib.lib binary from the commit.
>>    Update header guard to align with coding standard.
>>
>> Vu Nguyen (2):
>>    AmpereAltraBinPkg: Add PciePhyLib library and header
>>    edk2-non-osi: Add AmpereAltraBinPkg maintainers
>>
>>   Maintainers.txt                               |   4 +
>>   Silicon/Ampere/License.txt                    |  25 ++++
>>   .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   |  16 +++
>>   .../Library/PciePhyLib/PciePhyLib.inf         |  23 ++++
>>   .../Include/Library/PciePhyLib.h              | 111 ++++++++++++++++++
>>   5 files changed, 179 insertions(+)
>>   create mode 100644 Silicon/Ampere/License.txt
>>   create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
>>   create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>>   create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
>>
>> -- 
>> 2.17.1
>>

      reply	other threads:[~2021-06-09 13:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 10:18 [edk2-non-osi][PATCH v3 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package Vu Nguyen
2021-05-26 10:18 ` [edk2-non-osi][PATCH v3 1/2] AmpereAltraBinPkg: Add PciePhyLib library and header Vu Nguyen
2021-05-26 10:18 ` [edk2-non-osi][PATCH v3 2/2] edk2-non-osi: Add AmpereAltraBinPkg maintainers Vu Nguyen
2021-06-04 13:43 ` [edk2-non-osi][PATCH v3 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package Leif Lindholm
2021-06-09 13:42   ` Vu Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf35f830-579a-4884-ae0e-beb47e907217@amperemail.onmicrosoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox